Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{vm-repair} Fix public IP turn off option #8160

Merged
merged 16 commits into from
Oct 25, 2024
Merged

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Oct 17, 2024


Taking over this PR: #7866

This PR fixes a longstanding bug where the option to not create a public IP was broken and would just create a public IP with the name False. Now a private ip will be used if the --associate-public-ip parameter is not provided by the user.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 17, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Sandido,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 17, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Oct 17, 2024

Hi @Sandido

Release Suggestions

Module: vm-repair

  • Update VERSION to 1.1.2 in src/vm-repair/setup.py

Notes

@Sandido Sandido marked this pull request as ready for review October 18, 2024 18:14
@yanzhudd
Copy link
Contributor

please resolve code conflicts

@Sandido
Copy link
Member Author

Sandido commented Oct 23, 2024

@yanzhudd please re-review!

@Sandido Sandido marked this pull request as draft October 23, 2024 18:51
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 23, 2024

This PR is still in draft status

@Sandido Sandido marked this pull request as ready for review October 24, 2024 01:49
@Sandido Sandido marked this pull request as draft October 24, 2024 01:52
@Sandido Sandido marked this pull request as ready for review October 24, 2024 01:58
@Sandido
Copy link
Member Author

Sandido commented Oct 24, 2024

@yonzhan , was temporarily in draft, ready for re-review!

@yanzhudd
Copy link
Contributor

yanzhudd commented Oct 24, 2024

It looks good to me.
But please note that Azure CLI is only responsible for code style and specification but not business logic, so it is better to involve service team to review it as well.

@yanzhudd yanzhudd changed the title Fix public IP turn off option {vm-repair} Fix public IP turn off option Oct 25, 2024
@yanzhudd yanzhudd merged commit ea4af4c into Azure:main Oct 25, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants