-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{vm-repair} Fix public IP turn off option #8160
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @Sandido, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
Hi @Sandido Release SuggestionsModule: vm-repair
Notes
|
please resolve code conflicts |
@yanzhudd please re-review! |
This PR is still in draft status |
@yonzhan , was temporarily in draft, ready for re-review! |
It looks good to me. |
Taking over this PR: #7866
This PR fixes a longstanding bug where the option to not create a public IP was broken and would just create a public IP with the name False. Now a private ip will be used if the --associate-public-ip parameter is not provided by the user.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.