Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation of Code for new api 2024-09-01 for workloads #8177

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jaskisin
Copy link
Contributor

@jaskisin jaskisin commented Oct 22, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 22, 2024

❌Azure CLI Extensions Breaking Change Test
❌workloads
rule cmd_name rule_message suggest_message
1007 - ParaRemove workloads sap-application-server-instance update cmd workloads sap-application-server-instance update removed parameter no_wait please add back parameter no_wait for cmd workloads sap-application-server-instance update
1010 - ParaPropUpdate workloads sap-application-server-instance update cmd workloads sap-application-server-instance update update parameter sap_virtual_instance_name: updated property options from ['--sap-virtual-instance-name', '--vis-name'] to ['--sap-virtual-instance-name'] please change property options from ['--sap-virtual-instance-name'] to ['--sap-virtual-instance-name', '--vis-name'] for parameter sap_virtual_instance_name of cmd workloads sap-application-server-instance update
1002 - CmdRemove workloads sap-availability-zone-detail cmd workloads sap-availability-zone-detail removed please confirm cmd workloads sap-availability-zone-detail removed
1007 - ParaRemove workloads sap-central-instance update cmd workloads sap-central-instance update removed parameter no_wait please add back parameter no_wait for cmd workloads sap-central-instance update
1010 - ParaPropUpdate workloads sap-central-instance update cmd workloads sap-central-instance update update parameter sap_virtual_instance_name: updated property options from ['--sap-virtual-instance-name', '--vis-name'] to ['--sap-virtual-instance-name'] please change property options from ['--sap-virtual-instance-name'] to ['--sap-virtual-instance-name', '--vis-name'] for parameter sap_virtual_instance_name of cmd workloads sap-central-instance update
1007 - ParaRemove workloads sap-database-instance update cmd workloads sap-database-instance update removed parameter no_wait please add back parameter no_wait for cmd workloads sap-database-instance update
1010 - ParaPropUpdate workloads sap-database-instance update cmd workloads sap-database-instance update update parameter sap_virtual_instance_name: updated property options from ['--sap-virtual-instance-name', '--vis-name'] to ['--sap-virtual-instance-name'] please change property options from ['--sap-virtual-instance-name'] to ['--sap-virtual-instance-name', '--vis-name'] for parameter sap_virtual_instance_name of cmd workloads sap-database-instance update
1008 - ParaPropAdd workloads sap-disk-configuration cmd workloads sap-disk-configuration update parameter app_location: added property required=True please remove property required=True for parameter app_location of cmd workloads sap-disk-configuration
1008 - ParaPropAdd workloads sap-disk-configuration cmd workloads sap-disk-configuration update parameter database_type: added property required=True please remove property required=True for parameter database_type of cmd workloads sap-disk-configuration
1008 - ParaPropAdd workloads sap-disk-configuration cmd workloads sap-disk-configuration update parameter db_vm_sku: added property required=True please remove property required=True for parameter db_vm_sku of cmd workloads sap-disk-configuration
1008 - ParaPropAdd workloads sap-disk-configuration cmd workloads sap-disk-configuration update parameter deployment_type: added property required=True please remove property required=True for parameter deployment_type of cmd workloads sap-disk-configuration
1008 - ParaPropAdd workloads sap-disk-configuration cmd workloads sap-disk-configuration update parameter environment: added property required=True please remove property required=True for parameter environment of cmd workloads sap-disk-configuration
1008 - ParaPropAdd workloads sap-disk-configuration cmd workloads sap-disk-configuration update parameter sap_product: added property required=True please remove property required=True for parameter sap_product of cmd workloads sap-disk-configuration
1008 - ParaPropAdd workloads sap-sizing-recommendation cmd workloads sap-sizing-recommendation update parameter app_location: added property required=True please remove property required=True for parameter app_location of cmd workloads sap-sizing-recommendation
1008 - ParaPropAdd workloads sap-sizing-recommendation cmd workloads sap-sizing-recommendation update parameter database_type: added property required=True please remove property required=True for parameter database_type of cmd workloads sap-sizing-recommendation
1008 - ParaPropAdd workloads sap-sizing-recommendation cmd workloads sap-sizing-recommendation update parameter db_memory: added property required=True please remove property required=True for parameter db_memory of cmd workloads sap-sizing-recommendation
1008 - ParaPropAdd workloads sap-sizing-recommendation cmd workloads sap-sizing-recommendation update parameter deployment_type: added property required=True please remove property required=True for parameter deployment_type of cmd workloads sap-sizing-recommendation
1008 - ParaPropAdd workloads sap-sizing-recommendation cmd workloads sap-sizing-recommendation update parameter environment: added property required=True please remove property required=True for parameter environment of cmd workloads sap-sizing-recommendation
1008 - ParaPropAdd workloads sap-sizing-recommendation cmd workloads sap-sizing-recommendation update parameter sap_product: added property required=True please remove property required=True for parameter sap_product of cmd workloads sap-sizing-recommendation
1008 - ParaPropAdd workloads sap-sizing-recommendation cmd workloads sap-sizing-recommendation update parameter saps: added property required=True please remove property required=True for parameter saps of cmd workloads sap-sizing-recommendation
1008 - ParaPropAdd workloads sap-supported-sku cmd workloads sap-supported-sku update parameter app_location: added property required=True please remove property required=True for parameter app_location of cmd workloads sap-supported-sku
1008 - ParaPropAdd workloads sap-supported-sku cmd workloads sap-supported-sku update parameter database_type: added property required=True please remove property required=True for parameter database_type of cmd workloads sap-supported-sku
1008 - ParaPropAdd workloads sap-supported-sku cmd workloads sap-supported-sku update parameter deployment_type: added property required=True please remove property required=True for parameter deployment_type of cmd workloads sap-supported-sku
1008 - ParaPropAdd workloads sap-supported-sku cmd workloads sap-supported-sku update parameter environment: added property required=True please remove property required=True for parameter environment of cmd workloads sap-supported-sku
1008 - ParaPropAdd workloads sap-supported-sku cmd workloads sap-supported-sku update parameter sap_product: added property required=True please remove property required=True for parameter sap_product of cmd workloads sap-supported-sku
⚠️ 1002 - CmdRemove workloads sap-application-server-instance wait cmd workloads sap-application-server-instance wait removed
⚠️ 1002 - CmdRemove workloads sap-central-instance wait cmd workloads sap-central-instance wait removed
⚠️ 1002 - CmdRemove workloads sap-database-instance wait cmd workloads sap-database-instance wait removed
⚠️ 1009 - ParaPropRemove workloads sap-virtual-instance create cmd workloads sap-virtual-instance create update parameter managed_resources_network_access_type: removed property aaz_default=Public
⚠️ 1009 - ParaPropRemove workloads sap-virtual-instance create cmd workloads sap-virtual-instance create update parameter managed_resources_network_access_type: removed property default=Public
⚠️ 1009 - ParaPropRemove workloads sap-virtual-instance list cmd workloads sap-virtual-instance list update parameter resource_group: removed property required=True
⚠️ 1009 - ParaPropRemove workloads sap-virtual-instance update cmd workloads sap-virtual-instance update update parameter managed_resources_network_access_type: removed property aaz_default=Public
⚠️ 1009 - ParaPropRemove workloads sap-virtual-instance update cmd workloads sap-virtual-instance update update parameter managed_resources_network_access_type: removed property default=Public
⚠️ 1010 - ParaPropUpdate workloads sap-virtual-instance update cmd workloads sap-virtual-instance update update parameter managed_resources_network_access_type: updated property options from ['--managed-resources-network-access-type'] to ['--managed-resources-network-access-type', '--mrg-network-access-typ']

Copy link

Hi @jaskisin,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 22, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Oct 22, 2024

Hi @jaskisin

⚠️ Release Requirements

Module: workloads

  • ⚠️ Please update VERSION to be 1.1.0b4 in src/workloads/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 22, 2024
@yonzhan yonzhan requested a review from kairu-ms October 22, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants