Add Maintenance Config Support #8190
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp env maintenance-config | sub group containerapp env maintenance-config added |
|
Hi @p-bouchon, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @p-bouchon Release SuggestionsModule: containerapp
Notes
|
yonzhan
requested review from
zhoxing-ms and
yanzhudd
and removed request for
jsntcy and
kairu-ms
src/containerapp/azext_containerapp/containerapp_maintenanceconfig_decorator.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_maintenance_config.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/containerapp_maintenanceconfig_decorator.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/containerapp_maintenance_config_decorator.py
Outdated
Show resolved
Hide resolved
| examples: | ||
| - name: Show Planned Maintenance | ||
| text: | | ||
| az containerapp env maintenance-config show --env-name myEnv -g MyResourceGroup |
There was a problem hiding this comment.
Please update the --environment, it still --env-name
src/containerapp/azext_containerapp/containerapp_maintenance_config_decorator.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_maintenance_config.py
Show resolved
Hide resolved
|
Hi @p-bouchon When I tracked whether some comments were fixed, I found that they were not processed but marked as resolved. Please confirm under these comments that they have been fixed or reply that they may not need to be addressed. |
src/containerapp/azext_containerapp/tests/latest/test_containerapp_maintenance_config.py
Show resolved
Hide resolved
|
Hi @Juliehzl |
|
ni: |
src/containerapp/azext_containerapp/tests/latest/test_containerapp_maintenance_config.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Zunli Hu <[email protected]>
|
Hi @Juliehzl This PR LGTM. Could you take a look again and check your comments addressed? |
|
It looks good to me. After Juliehzl signs off, I'll merge it. |
|
|
||
|
|
||
| # maintenance config | ||
| def add_maintenance_config(cmd, resource_group_name, env_name, duration, start_hour_utc, weekday): |
There was a problem hiding this comment.
Will you support customized name in the future? Current design is not very flexible for extensibility. Consider adding --name support for your commands with default value = "default" which will be extensible in the future.
There was a problem hiding this comment.
Hi @Juliehzl
only one maintenance config of name "default" is allowed.
If we want to support name in the future, we can add name in that time. If we add it now, it will be exposed to customer.
There was a problem hiding this comment.
@p-bouchon please correct me if I am wrong
There was a problem hiding this comment.
We currently have no plans to allow for non default names for maintenance configuration. If any were to be added, they would be specific non-customizable names to specify upgrades on specific aspects of the service
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.