Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing msrestazure library and methods from AZFW (Azure Firewall) #8225

Closed
wants to merge 2 commits into from

Conversation

jayaluru
Copy link

@jayaluru jayaluru commented Nov 4, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 4, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @jayaluru,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @jayaluru,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 4, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Nov 4, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 4, 2024
Copy link
Contributor

Thank you for your contribution jayaluru! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Nov 4, 2024

Hi @jayaluru

Release Suggestions

Module: azure-firewall

  • Update VERSION to 1.2.1 in src/azure-firewall/setup.py

Notes

@@ -2,6 +2,10 @@

Release History
===============
1.2.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls update the version in setup.py

@evelyn-ys
Copy link
Member

Since this extension's test recordings haven't been updated for some time. You need to re-record them with latest cli dev branch:

  • sync latest dev branch of azure-cli repo
  • run azdev setup -c -r $EXTENSION_FOLDER to update env
  • run azdev test $test_name --live to re-record failed tests

@necusjz
Copy link
Member

necusjz commented Nov 5, 2024

duplicate of #8230

@necusjz necusjz closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants