Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Fix the test failure of network isolated cluster feature #8257

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

bingosummer
Copy link
Member

@bingosummer bingosummer commented Nov 10, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --resource-group={resource_group} --name={name} --bootstrap-artifact-source Cache --bootstrap-container-registry-resource-id {acr_id} --outbound-type=none/block

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 10, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @bingosummer,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 10, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Nov 10, 2024

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

  • test_aks_network_isolated_cluster

@FumingZhang
Copy link
Member

Queued live test to validate the change.

  • test_aks_network_isolated_cluster

Case failed with the following error

E                   azure.cli.core.azclierror.BadRequestError: (InvalidNetworkIsolatedClusterConfiguration) When outbound type is none or block, the cluster must be private cluster or enables apiserver vnet integration
E                   Code: InvalidNetworkIsolatedClusterConfiguration
E                   Message: When outbound type is none or block, the cluster must be private cluster or enables apiserver vnet integration

Comment on lines 12 to 15
Pending
+++++++
* Fix the test failure of network isolated cluster feature.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May omit the note here as you only modified test cases, which is not visible to external users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, removed

@FumingZhang
Copy link
Member

Queued live test to validate the change.

  • test_aks_network_isolated_cluster

Case failed with the following error

E                   azure.cli.core.azclierror.BadRequestError: (InvalidNetworkIsolatedClusterConfiguration) When outbound type is none or block, the cluster must be private cluster or enables apiserver vnet integration
E                   Code: InvalidNetworkIsolatedClusterConfiguration
E                   Message: When outbound type is none or block, the cluster must be private cluster or enables apiserver vnet integration

Requeued live test

@bingosummer
Copy link
Member Author

bingosummer commented Nov 12, 2024

Requeued live test, test passed!

  • test_aks_network_isolated_cluster

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit 4a75319 into Azure:main Nov 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants