Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] az aks create/update: Update ACNS Enablement for 2024-09-02-preview #8263

Merged

Conversation

rayaisaiah
Copy link
Contributor

@rayaisaiah rayaisaiah commented Nov 12, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --enable-acns
az aks create --enable-acns --disable-acns-observability
az aks create --enable-acns --disable-acns-security

az aks update --enable-acns
az aks update --disable-acns
az aks update --enable-acns --disable-acns-observability
az aks update --enable-acns --disable-acns-security

Update ACNS enablement with new ACNS API changes from 2024-09-02-preview.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 12, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @rayaisaiah,
Since the current milestone time is less than 7 days, this pr may not catch up with this release.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 12, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@rayaisaiah rayaisaiah changed the title Update ACNS preview CLI for 2024-09-02-preview API Update ACNS preview CLI for 2024-09-02-preview Nov 12, 2024
Copy link

@rayaisaiah rayaisaiah changed the title Update ACNS preview CLI for 2024-09-02-preview [AKS] az aks create/update: Update ACNS Enablement for 2024-09-02-preview Nov 13, 2024
@rayaisaiah rayaisaiah marked this pull request as ready for review November 13, 2024 18:38
@rayaisaiah
Copy link
Contributor Author

rayaisaiah commented Nov 13, 2024

The live test validating the changes has passed.

test_aks_update_enable_acns
test_aks_create_with_enable_acns
test_aks_create_with_enable_acns_complex

@zhoxing-ms zhoxing-ms merged commit b530220 into Azure:main Nov 15, 2024
21 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=206556&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants