Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[containerapp] suspend/resume a container apps job #8270

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bgashirabake
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 13, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd containerapp job resume cmd containerapp job resume added
⚠️ 1001 - CmdAdd containerapp job suspend cmd containerapp job suspend added

Copy link

Hi @bgashirabake,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @bgashirabake,
Since the current milestone time is less than 7 days, this pr may not catch up with this release.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 13, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@bgashirabake bgashirabake changed the title [container app] suspend/resume a container apps job [containerapp] suspend/resume a container apps job Nov 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 13, 2024
Copy link
Contributor

Thank you for your contribution bgashirabake! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

Hi @bgashirabake

Release Suggestions

Module: containerapp

  • Update VERSION to 1.0.0b5 in src/containerapp/setup.py

Notes

@bgashirabake
Copy link
Contributor Author

@Greedygre can you help with initial reviews for this PR?

i'll get someone from my team to validate the logic too :)


r = send_raw_request(cmd.cli_ctx, "POST", request_url)
if r.status_code == 202:
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle other response codes as well. For example, if Job is not found, then we would return 404 from the RP, but in this case we would not return the correct information.

JMESPathCheck('name', job),
JMESPathCheck("properties.provisioningState", "Succeeded"),
JMESPathCheck('properties.runningStatus', "Suspended", case_sensitive=False),
])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an additional command here to try and start the suspended job which should return the message that the Job in suspended state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants