-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[containerapp] suspend/resume a container apps job #8270
base: main
Are you sure you want to change the base?
[containerapp] suspend/resume a container apps job #8270
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
containerapp job resume | cmd containerapp job resume added |
||
containerapp job suspend | cmd containerapp job suspend added |
Hi @bgashirabake, |
Hi @bgashirabake, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
Thank you for your contribution bgashirabake! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Release SuggestionsModule: containerapp
Notes
|
@Greedygre can you help with initial reviews for this PR? i'll get someone from my team to validate the logic too :) |
|
||
r = send_raw_request(cmd.cli_ctx, "POST", request_url) | ||
if r.status_code == 202: | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle other response codes as well. For example, if Job is not found, then we would return 404 from the RP, but in this case we would not return the correct information.
JMESPathCheck('name', job), | ||
JMESPathCheck("properties.provisioningState", "Succeeded"), | ||
JMESPathCheck('properties.runningStatus', "Suspended", case_sensitive=False), | ||
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an additional command here to try and start the suspended job which should return the message that the Job in suspended state.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.