Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OpenTelemetry in worker #1058

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Add support for OpenTelemetry in worker #1058

merged 2 commits into from
Apr 12, 2024

Conversation

andystaples
Copy link
Contributor

Issue describing the changes in this PR

resolves #1048
Cherry-pick commit from dev
Documentation Issue: #1057

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@andystaples
OpenTelemetry support in worker (#1049)
7d73c76 
* Detect if OpenTelemetry module is present and environment variable is set
* Pre-instrument invocations with a span using Invocation ID + parent span ID
* Forward all user logs to the module to be sent to OTel endpoint

(cherry picked from commit f0c7eec)
@Francisco-Gamino Francisco-Gamino requested review from Francisco-Gamino and AnatoliB and removed request for Francisco-Gamino April 12, 2024 19:21
@AnatoliB
Copy link
Contributor

Please fix the failing unit test (OpenTelemetryControllerTests.OpenTelemetryEnvironmentVariableCheckWorks). Most likely, it will pass if you invoke OpenTelemetryController.ResetOpenTelemetryModuleStatus() at the beginning.

AnatoliB
AnatoliB approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@AnatoliB AnatoliB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm signing off, as I believe the test failure is just a test code issue, but please fix it (see my other comment on this PR).

@andystaples
Copy link
Contributor Author

No sense in merging until the pipeline passes, since it builds the artifacts we need for release. Looks like that change did it - going now

@andystaples andystaples merged commit 684a843 into v4.x/ps7.2 Apr 12, 2024
2 of 4 checks passed
@andystaples andystaples deleted the andystaples/powershell-opentelemetry-72 branch April 12, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnatoliB AnatoliB AnatoliB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andystaples @AnatoliB