AllowBranchToBranch BugFixes #22584

ksteinmeyer2023 · 2023-08-15T18:00:05Z

Description

Adding AllowBranchToBranch for Route Server to New-AzRouteServer and Get-AzRouteServer cmdlets. Changing Update-AzRouteServer functionality so that changing HubRoutingPreference property does not disable AllowBranchToBranch. Changing AllowBranchToBranch property on Update-AzRouteServer cmdlet to be a bool rather than a switch.

Checklist

[ x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
SHOULD make the title of PR clear and informative, and in the present imperative tense.
SHOULD update ChangeLog.md file(s) appropriately
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT introduce breaking changes in Az minor release except preview version.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2023-08-15T18:41:15Z

️✔️Az.Accounts

️✔️Az.ApplicationInsights

️✔️Az.Batch

️✔️Az.CognitiveServices

️✔️Az.Compute

️✔️Az.ContainerRegistry

️✔️Az.CosmosDB

️✔️Az.DataLakeStore

️✔️Az.Dns

️✔️Az.EventHub

⚠️Az.KeyVault

️✔️Az.ManagedServiceIdentity

⚠️Az.Monitor

️✔️Az.NetAppFiles

⚠️Az.Network

️✔️Az.OperationalInsights

️✔️Az.PrivateDns

️✔️Az.RecoveryServices

️✔️Az.Resources

️✔️Az.Security

️✔️Az.ServiceBus

️✔️Az.SignalR

️✔️Az.Sql

️✔️Az.Storage

️✔️Az.Websites

YanaXu · 2023-08-16T09:08:52Z

Hi @ksteinmeyer2023 , this PR introduces breaking changes that can be avoided. Please update it.

github-actions · 2023-08-16T09:09:48Z

This PR was labeled needs-revision because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide (link TBD) to troubleshoot common CI failures.

This reverts commit 14d685c.

This reverts commit a063d5f.

github-actions · 2023-08-23T09:48:10Z

This PR was labeled needs-revision because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide (link TBD) to troubleshoot common CI failures.

YanaXu · 2023-08-28T06:42:27Z

Hi @ksteinmeyer2023, this is a breaking change. Please add the breaking change message now and hold this PR to major release.

github-actions · 2023-10-10T03:19:14Z

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.
According to our policy, breaking changes can only take place during major release and they must be preannounced.
Please follow our guide on the detailed steps.

VeryEarly · 2023-10-10T03:31:16Z

Simply resolve conflicts might be incorrect, please sync your branch with latest main.

…nmeyer2023/azure-powershell into ksteinmeyer/allowB2BBugFix

ksteinmeyer2023 added 10 commits June 8, 2023 11:52

adding hub routing preference column

ca4ec8c

merging pending changes on release-network-2023-02-01

e476d92

adding hrp property on object

8e8dd68

adding bug fix changes for allow b2b hrp scenario

17a3a93

changing b2b property

6d72a83

adding default value

9106d82

adding b2b to get for route server

27a01e8

changing so there's parity with vwan

5e4af85

recorded tests

3ca4444

changelog

e629b83

ksteinmeyer2023 added the needs-review label Aug 15, 2023

changing parent type back to switch

3aa0c97

YanaXu added needs-revision and removed needs-review labels Aug 16, 2023

updated markdown file

14d685c

ksteinmeyer2023 added needs-review and removed needs-revision labels Aug 22, 2023

ksteinmeyer2023 added 4 commits August 22, 2023 17:13

uploading updated md files

a063d5f

Revert "updated markdown file"

b57a224

This reverts commit 14d685c.

Revert "uploading updated md files"

1df94f4

This reverts commit a063d5f.

changing only two md files

be31e66

YanaXu added Breaking Change Release This PR contains breaking change needs-revision and removed needs-review labels Aug 23, 2023

VeryEarly removed the Breaking Change Release This PR contains breaking change label Oct 10, 2023

VeryEarly added the Breaking Change Release This PR contains breaking change label Oct 10, 2023

VeryEarly self-assigned this Oct 10, 2023

ksteinmeyer2023 and others added 7 commits October 16, 2023 16:50

Merge branch 'main' of https://github.com/Azure/azure-powershell

99ef855

resolve merge conflicts

fd1779b

updating help md

ddd2907

Update ChangeLog.md

461366b

suppressing breaking changes

54fd4ae

Merge branch 'ksteinmeyer/allowB2BBugFix' of https://github.com/kstei…

4a844e7

…nmeyer2023/azure-powershell into ksteinmeyer/allowB2BBugFix

adding line to breaking change suppression

62b2f8f

ksteinmeyer2023 added needs-review and removed needs-revision labels Oct 18, 2023

VeryEarly removed the Breaking Change Release This PR contains breaking change label Oct 19, 2023

VeryEarly approved these changes Oct 19, 2023

View reviewed changes

VeryEarly merged commit 867afd0 into Azure:main Oct 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AllowBranchToBranch BugFixes #22584

AllowBranchToBranch BugFixes #22584

ksteinmeyer2023 commented Aug 15, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Aug 15, 2023 •

edited

Loading

YanaXu commented Aug 16, 2023

github-actions bot commented Aug 16, 2023

github-actions bot commented Aug 23, 2023

YanaXu commented Aug 28, 2023

github-actions bot commented Oct 10, 2023

VeryEarly commented Oct 10, 2023

AllowBranchToBranch BugFixes #22584

AllowBranchToBranch BugFixes #22584

Conversation

ksteinmeyer2023 commented Aug 15, 2023 • edited Loading

Description

Checklist

azure-client-tools-bot-prd bot commented Aug 15, 2023 • edited Loading

YanaXu commented Aug 16, 2023

github-actions bot commented Aug 16, 2023

github-actions bot commented Aug 23, 2023

YanaXu commented Aug 28, 2023

github-actions bot commented Oct 10, 2023

VeryEarly commented Oct 10, 2023

ksteinmeyer2023 commented Aug 15, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Aug 15, 2023 •

edited

Loading