Make TrustedLaunch default in for VM and VMSS creation #22974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.ApplicationInsights
|
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| New-AzVmssConfig | 1 | 1 | Unassigned_Variable | New-AzVmssConfig -Location $Loc is a null-valued parameter value. | -Location | Assign value for $Loc. | |
| New-AzVmssConfig | 1 | 1 | Unassigned_Variable | New-AzVmssConfig -NetworkInterfaceConfiguration $NetCfg is a null-valued parameter value. | -NetworkInterfaceConfiguration | Assign value for $NetCfg. | |
| New-AzVmssConfig | 1 | 2 | Unassigned_Variable | Add-AzVmssNetworkInterfaceConfiguration -IPConfiguration $IPCfg is a null-valued parameter value. | -IPConfiguration | Assign value for $IPCfg. | |
| New-AzVmssConfig | 1 | 3 | Unassigned_Variable | Set-AzVmssOsProfile -AdminUsername $adminUsername is a null-valued parameter value. | -AdminUsername | Assign value for $adminUsername. | |
| New-AzVmssConfig | 1 | 3 | Unassigned_Variable | Set-AzVmssOsProfile -AdminPassword $AdminPassword is a null-valued parameter value. | -AdminPassword | Assign value for $AdminPassword. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceOffer $ImgRef.Offer is a null-valued parameter value. | -ImageReferenceOffer | Assign value for $ImgRef.Offer. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceSku $ImgRef.Skus is a null-valued parameter value. | -ImageReferenceSku | Assign value for $ImgRef.Skus. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceVersion $ImgRef.Version is a null-valued parameter value. | -ImageReferenceVersion | Assign value for $ImgRef.Version. | |
| New-AzVmssConfig | 1 | 6 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferencePublisher $ImgRef.PublisherName is a null-valued parameter value. | -ImageReferencePublisher | Assign value for $ImgRef.PublisherName. | |
| New-AzVmssConfig | 1 | 6 | Unassigned_Variable | Set-AzVmssStorageProfile -VhdContainer $VHDContainer is a null-valued parameter value. | -VhdContainer | Assign value for $VHDContainer. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -ComponentName $AUCComponentName is a null-valued parameter value. | -ComponentName | Assign value for $AUCComponentName. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -Content $AUCContent is a null-valued parameter value. | -Content | Assign value for $AUCContent. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -PassName $AUCPassName is a null-valued parameter value. | -PassName | Assign value for $AUCPassName. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -SettingName $AUCSetting is a null-valued parameter value. | -SettingName | Assign value for $AUCSetting. | |
| New-AzVmssConfig | 1 | 9 | Unassigned_Variable | New-AzVmss -ResourceGroupName $RGName is a null-valued parameter value. | -ResourceGroupName | Assign value for $RGName. | |
| New-AzVmssConfig | 1 | 9 | Unassigned_Variable | New-AzVmss -Name $VMSSName is a null-valued parameter value. | -Name | Assign value for $VMSSName. | |
| New-AzVmssConfig | 4 | 19 | Unassigned_Variable | New-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 19 | Unassigned_Variable | New-AzStorageAccount -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 20 | Unassigned_Variable | Get-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 24 | Unassigned_Variable | New-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 24 | Unassigned_Variable | New-AzVirtualNetwork -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 25 | Unassigned_Variable | Get-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 31 | Unassigned_Variable | New-AzVmssConfig -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 38 | Unassigned_Variable | New-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 40 | Unassigned_Variable | Get-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 5 | 36 | Mismatched_Parameter_Value_Type | Set-AzVmssOsProfile -AdminPassword $adminPassword is not an expected parameter value type. | -AdminPassword | Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command). | |
| Set-AzDiskSecurityProfile | 2 | 11 | Unassigned_Variable | New-AzKeyVault -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 17 | Unassigned_Variable | Get-AzKeyVault -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 23 | Unassigned_Variable | New-AzDiskEncryptionSet -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 24 | Unassigned_Variable | Get-AzDiskEncryptionSet -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 27 | Unassigned_Variable | Get-AzDiskEncryptionSet -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 28 | Unassigned_Variable | Set-AzKeyVaultAccessPolicy -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 35 | Unassigned_Variable | New-AzDisk -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 36 | Unassigned_Variable | Get-AzDisk -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| New-AzVmssConfig | 1 | 1 | Unassigned_Variable | New-AzVmssConfig -Location $Loc is a null-valued parameter value. | -Location | Assign value for $Loc. | |
| New-AzVmssConfig | 1 | 1 | Unassigned_Variable | New-AzVmssConfig -NetworkInterfaceConfiguration $NetCfg is a null-valued parameter value. | -NetworkInterfaceConfiguration | Assign value for $NetCfg. | |
| New-AzVmssConfig | 1 | 2 | Unassigned_Variable | Add-AzVmssNetworkInterfaceConfiguration -IPConfiguration $IPCfg is a null-valued parameter value. | -IPConfiguration | Assign value for $IPCfg. | |
| New-AzVmssConfig | 1 | 3 | Unassigned_Variable | Set-AzVmssOsProfile -AdminUsername $adminUsername is a null-valued parameter value. | -AdminUsername | Assign value for $adminUsername. | |
| New-AzVmssConfig | 1 | 3 | Unassigned_Variable | Set-AzVmssOsProfile -AdminPassword $AdminPassword is a null-valued parameter value. | -AdminPassword | Assign value for $AdminPassword. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceOffer $ImgRef.Offer is a null-valued parameter value. | -ImageReferenceOffer | Assign value for $ImgRef.Offer. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceSku $ImgRef.Skus is a null-valued parameter value. | -ImageReferenceSku | Assign value for $ImgRef.Skus. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceVersion $ImgRef.Version is a null-valued parameter value. | -ImageReferenceVersion | Assign value for $ImgRef.Version. | |
| New-AzVmssConfig | 1 | 6 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferencePublisher $ImgRef.PublisherName is a null-valued parameter value. | -ImageReferencePublisher | Assign value for $ImgRef.PublisherName. | |
| New-AzVmssConfig | 1 | 6 | Unassigned_Variable | Set-AzVmssStorageProfile -VhdContainer $VHDContainer is a null-valued parameter value. | -VhdContainer | Assign value for $VHDContainer. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -ComponentName $AUCComponentName is a null-valued parameter value. | -ComponentName | Assign value for $AUCComponentName. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -Content $AUCContent is a null-valued parameter value. | -Content | Assign value for $AUCContent. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -PassName $AUCPassName is a null-valued parameter value. | -PassName | Assign value for $AUCPassName. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -SettingName $AUCSetting is a null-valued parameter value. | -SettingName | Assign value for $AUCSetting. | |
| New-AzVmssConfig | 1 | 9 | Unassigned_Variable | New-AzVmss -ResourceGroupName $RGName is a null-valued parameter value. | -ResourceGroupName | Assign value for $RGName. | |
| New-AzVmssConfig | 1 | 9 | Unassigned_Variable | New-AzVmss -Name $VMSSName is a null-valued parameter value. | -Name | Assign value for $VMSSName. | |
| New-AzVmssConfig | 4 | 19 | Unassigned_Variable | New-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 19 | Unassigned_Variable | New-AzStorageAccount -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 20 | Unassigned_Variable | Get-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 24 | Unassigned_Variable | New-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 24 | Unassigned_Variable | New-AzVirtualNetwork -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 25 | Unassigned_Variable | Get-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 31 | Unassigned_Variable | New-AzVmssConfig -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 38 | Unassigned_Variable | New-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 40 | Unassigned_Variable | Get-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 5 | 36 | Mismatched_Parameter_Value_Type | Set-AzVmssOsProfile -AdminPassword $adminPassword is not an expected parameter value type. | -AdminPassword | Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command). | |
| Set-AzDiskSecurityProfile | 2 | 11 | Unassigned_Variable | New-AzKeyVault -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 17 | Unassigned_Variable | Get-AzKeyVault -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 23 | Unassigned_Variable | New-AzDiskEncryptionSet -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 24 | Unassigned_Variable | Get-AzDiskEncryptionSet -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 27 | Unassigned_Variable | Get-AzDiskEncryptionSet -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 28 | Unassigned_Variable | Set-AzKeyVaultAccessPolicy -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 35 | Unassigned_Variable | New-AzDisk -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. | |
| Set-AzDiskSecurityProfile | 2 | 36 | Unassigned_Variable | Get-AzDisk -ResourceGroupName $ResourceGroupName is a null-valued parameter value. | -ResourceGroupName | Assign value for $ResourceGroupName. |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Ssh
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
Sandido
added this to the Az 11.0.0 (November 2023, 2023-11-14)❗ Breaking change release ❗ milestone
|
@VeryEarly , heads up, this will be out for review out of default for tonight. |
…owershell into adsandor/tldefault
|
all checks and tests currently pass. More commits incoming. |
| vVirtualMachineProfile.SecurityProfile.UefiSettings.VTpmEnabled = vVirtualMachineProfile.SecurityProfile.UefiSettings.VTpmEnabled == null ? true : this.EnableVtpm; | ||
| vVirtualMachineProfile.SecurityProfile.UefiSettings.SecureBootEnabled = vVirtualMachineProfile.SecurityProfile.UefiSettings.SecureBootEnabled == null ? true : this.EnableSecureBoot; | ||
| } | ||
| } | ||
|
|
||
| if (this.IsParameterBound(c => c.SecurityType) && this.SecurityType?.ToLower() == ConstantValues.StandardSecurityType) |
There was a problem hiding this comment.
what is this.IsParameterBound(c => c.SecurityType) but not this.SecurityType?.ToLower() == ConstantValues.StandardSecurityType ?
There was a problem hiding this comment.
I think you're right that this can be removed and just use the above code but again, remove the 2nd conditional from the above if.
| @@ -72,6 +72,19 @@ private void Run() | |||
| } | |||
| this.VirtualMachineScaleSet.VirtualMachineProfile.SecurityProfile.SecurityType = this.SecurityType; | |||
| } | |||
| else if (this.IsParameterBound(c => c.SecurityType) && this.SecurityType?.ToLower() == ConstantValues.StandardSecurityType) | |||
There was a problem hiding this comment.
can we just take out the second conditional in line 62 instead?
| vm.SecurityProfile.UefiSettings.VTpmEnabled = vm.SecurityProfile.UefiSettings.VTpmEnabled == null ? true : this.EnableVtpm; | ||
| vm.SecurityProfile.UefiSettings.SecureBootEnabled = vm.SecurityProfile.UefiSettings.SecureBootEnabled == null ? true : this.EnableSecureBoot; | ||
| } | ||
| } | ||
|
|
||
| if (this.SecurityType != null && this.SecurityType?.ToLower() == ConstantValues.StandardSecurityType) |
There was a problem hiding this comment.
what if this.SecurityType != null but not this.SecurityType?.ToLower() == ConstantValues.StandardSecurityType
There was a problem hiding this comment.
Then the above code block would be executed. I think this could just be an Else If of the above.
| if (!this.IsParameterBound(c => c.SecurityType) | ||
| && !this.IsParameterBound(c => c.ImageName) | ||
| && !this.IsParameterBound(c => c.ImageReferenceId) | ||
| && !this.IsParameterBound(c => c.SharedGalleryImageId)) |
There was a problem hiding this comment.
Haider is making changes to this parameter: [Compute] SharedGalleryImageId bug fix for New-Azvmss, New-Azvm by haagha · Pull Request #23145 · Azure/azure-powershell (github.com)
Note to check w him
There was a problem hiding this comment.
my changes are in VirtualMachineScaleSetStrategy.cs
grizzlytheodore
previously approved these changes
Nov 6, 2023
Sandido
commented
Nov 6, 2023
| @@ -44,6 +44,12 @@ | |||
| } | |||
| }, | |||
| "Windows": { | |||
| "Win2022AzureEdition": { | |||
There was a problem hiding this comment.
unsure if I need this anymore
VeryEarly
approved these changes
Nov 7, 2023
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I still have a lot of cleaning up to do, and the new default value requires me to re-record many PS tests, but the functionality is all there.
When no SecurityType is provided, TrustedLaunch and its requirements will be defaulted in.
If no Image is provided, the 2022AzureEdition image, compatible with TL, will be defaulted in.
Resources made from a SharedGalleryImage are not considered for this feature.
Resources made from an Image that is Gen1 (HyperVGeneration V1) are not considered for this feature.
PM for this feature is [email protected].
I have had issues testing the managed disk scenario (3) as the request always times out (VMAgentStatus and os health is never good), but it seems to probably be working.
This feature consists of 4 different feature requests:
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1240
For Vm and Vmss creation, with minimal inputs, the default will be SecurityType = TrustedLaunch, with UEFI settings also set to true for TL if the user had not manually set the securitytype.
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1248
For a new vm disk created from an Image, I query for that image and determine if it is HyperVGeneration of V2. If yes, then default to trusted launch turned on if the user had not manually set the securitytype.
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1243
For VMs created from a managed disk for its os disk, it checks to see if the disk supports trusted launch, and if yes it will default the VM to trusted launch if the related values were not manually set by the user.
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1241
This impacts the Config parameter sets for VM and Vmss creation because it requires the user to set the ImageReference values, specifically not the Id as marketplace images like 2022-datacenter-azure-edition do not have an Id. This defaulting only occurs if the user did not manually set the TL related values.
As this feature changes the default behavior for VM and Vmss creation when SecurityType is null (which is typical) then I had to update many tests to set SecurityType to "Standard". This is seen in the client logic and prevents TrustedLaunch defaulting logic, but since the API does not support Standard it is nulled out before the .Net SDK call is made to create the VM or VMSS.
I ended up re-recording many tests without this Standard value to ensure previous behavior with this new defaulting is not broken, hence the many new json files.
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.