Breaking Change for Rate Limiting Feature for Application Gateway Firewall Policy Settings #23052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump up version for KeyVault (Azure#22511) * Merge remote-tracking branch 'upstream/main' into lnx/azurecore (Azure#22349) Co-authored-by: Yeming Liu <[email protected]> * Exclude the api-version in typename when checking the breaking change of cmdlet output (Azure#22495) * Exclude the api-version in typename when checking the breaking change of cmdlet output * Rename the function * fix Get-AzVmRunCommand bug (Azure#22460) * fix bug * changelog --------- Co-authored-by: Theodore Chang <[email protected]> * Add permission for pr-label github actions (Azure#22481) * Add permission for pr-label github actions * Add permission for pr-label github actions * Add permission for pr-label github actions * Add permission for pr-label github actions * Update Remove-AzApiManagementApiFromGateway.md (Azure#22505) Added the example of removing an API from a managed gateway. Users are not able to achieve it by following the first example and raising questions using support tickets. * Migrate StackHCI from generation to main (Azure#22541) * Move StackHCI to main * udpate changelog --------- Co-authored-by: YanaXu <[email protected]> * [KeyVault] Support MHSM Settings (Azure#22525) * wip * add update-azkeyvaultsetting and help docs * add example for settings * add change log * add live test * fix * fix * Migrate ContainerInstance from generation to main (Azure#22537) * Move ContainerInstance to main * Create containerGroups-containers.json * Create containerGroups.json --------- Co-authored-by: Beisi Zhou <[email protected]> * Updated ChangeLog.md for Az.ContainerInstance (Azure#22550) * Updated ChangeLog.md for Az.ContainerInstance * Update src/ContainerInstance/ChangeLog.md --------- Co-authored-by: Beisi Zhou <[email protected]> * [Synapse] Update artifact to 1.0.0-preview.18 (Azure#22452) * update artifact to 18 * fix change log error * workaround the assembly loading issue (Azure#22551) * [Compute] update sdk package reference for Compute (Azure#22459) * update SDK reference * resolve breaking change * update package reference * breaking change mitigation * breaking change suppression * re-record ssh test with latest compute API call --------- Co-authored-by: Theodore Chang <[email protected]> * Bump up version for StackHCI (Azure#22543) * Compute migration to track 1 deprecation (Azure#21949) * add compute.sdk project reference * add sdk folder * address comments * update commit version to inputs * rename Compute.Sdk folder to Compute.Management.Sdk * resolve xmls, change compute.sdk reference to compute.management.sdk * remove SDK reference. generate track 1 with latest DiskRP version * Update src/Compute/Compute.Management.Sdk/README.md Co-authored-by: Vincent Dai <[email protected]> * fix autorest cmd * update autorest gen * Update Compute.Management.Sdk.csproj * generated with latest swagger versions. 2023-04-02 diskRP 2023-07-01 CRP * update assembly version of sdk --------- Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Vincent Dai <[email protected]> * [KeyVault] Added security domain properties into PSManagedHsm (Azure#22540) * Refresh track 1 SDK * Added security domain properties into the output of New/Update/Get-AzKeyVaultManagedHsm (PSManagedHsm) * Refresh example * hibernate parameter for Stop-AzVmss (Azure#22560) Co-authored-by: Theodore Chang <[email protected]> * Update PrLabeled.ps1 (Azure#22553) * Adding XenonMV3 Support (Azure#22530) * adding PremiumMV3 to Xenon list * updating changelog --------- Co-authored-by: Nalin Gaddis <[email protected]> * Upgraded vulnerable DLLs after upgrading PowerShell SDK (Azure#22566) * Update New-AzVirtualNetworkSubnetConfig.md (Azure#22561) `New-AzVirtualSubnetConfig` does not exists but `New-AzVirtualNetworkSubnetConfig` does. * Generate aks sdk with autorest.powershell (Azure#22501) * Generate aks sdk with autorest.powershell * Suppress breaking changes caused by character case change * [KeyVault] Add live tests for MHSM Settings (Azure#22570) * Add live tests for MHSM Settings * enable all test cases * [Config] add config to disable write error to file system (Azure#22529) * disable error records persistence * add keys * upgrade common version * polish help message for 'DisableErrorRecordsPersistence' * Update src/Accounts/Authentication/Properties/Resources.resx Co-authored-by: Yeming Liu <[email protected]> * remove debug parameters for get/clear/update config * update environment variable name to AzPSDisableErrorRecordsPersistence --------- Co-authored-by: Yeming Liu <[email protected]> * Updated email notification to support multi-recipients (Azure#22577) * Use autorest.powershell to generate AlertsManagement SDK to replace the track 1 SDK (Azure#22579) * [Storage] Support encryption context property when creating a datalakegen2 item (Azure#22563) * encryption context * Add changelog * update test dependency and help file * Add an example for encryption context * Migrate StackHCI from generation to main (Azure#22588) * Move StackHCI to main * update changelog --------- Co-authored-by: YanaXu <[email protected]> * Support deployment stack object as input parameter for Save-Az*DeploymentStack and Remove-Az*DeploymentStack cmdlets (Azure#22519) * implemented stack object parameter sets for save and remove cmdlets * adjust tests and session records * adjusted changelog to reflect changes * adjust testing formatting * updating help docs * update cmdlets and help docs for renamed parameter * update sessions record tests * Migrate DataMigration from generation to main (Azure#22574) * Move DataMigration to main * update ChangeLog --------- Co-authored-by: YanaXu <[email protected]> * change breaking change info (Azure#22571) * Fixed type conversion issue when sending email in live test (Azure#22596) * Skip Accounts when run static analysis check in generation ci (Azure#22597) * [HDInsight] Add warning message for break changes which plan to release in Nov. (Azure#22578) * Update Azure.Core from 1.31.0 to 1.33.0 * replace models * Revert "replace models" This reverts commit d1a1de3. * add Warning message 1 * Update Azure.Core version to 1.34 * revert added package. * Update change log * Update changelog * move changelog to Upcoming release --------- Co-authored-by: v-yuchenli <[email protected]> * Update code-oob.yml for Azure Pipelines (Azure#22591) * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * [KeyVault] Formatted the table view of outputs (Azure#22580) * Formatted the table view of *-AzKeyVault, *-AzKeyVaultKey and *-AzKeyVaultSecret * format cert * reorg folder constructure * Update src/KeyVault/KeyVault.Test/UnitTests/SetKeyVaultSecretTests.cs * Update src/KeyVault/KeyVault.Test/UnitTests/RemoveKeyVaultSecretTests.cs * Update src/KeyVault/KeyVault/KeyVault.csproj * Update Maintenance ChangeLog.md (Azure#22602) * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Skip Accounts when run static analysis check in generation ci (Azure#22603) * Skip Accounts when run static analysis check in generation ci * Skip Accounts when run static analysis check in generation ci * Skip Accounts when run static analysis check in generation ci * Add SecurityType of Standard to VM and VMSS cmdlets for Trusted Launch, includes breaking changes (Azure#22534) * initial dev * successful test 1 * vmss test and rest of dev * vmss with config test * vm with config test * tests fixed maybe 1 fails * static analysis * remove vmss validation * null check * changelog and help doc * constant values * clean * valids and clean * Update BreakingChangeIssues.csv * remove breaking * Update BreakingChangeIssues.csv * Sign old modules (Azure#22609) * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Migrate SqlVirtualMachine from generation to main (Azure#22608) * Move SqlVirtualMachine to main * update Changelog --------- Co-authored-by: YanaXu <[email protected]> * Migrate EventHub from generation to main (Azure#22610) * Move EventHub to main * update ChangeLog --------- Co-authored-by: YanaXu <[email protected]> * Refill Credentials from AzKeyStore When Save AzContext (Azure#22440) * Refill Credentials from AzKeyStore When Save AzContext fix Azure#22355 * Address review comments * Address review comments * CosmosDB - New Restore Parameter (Azure#22585) * restore new param public network access * minor fixes * test change * stable changes 1 * md param def changed * reverting test changes for build * restore ts * test and test recording * Migrate KeyVault from generation to main (Azure#22621) * Move KeyVault to main * Update ChangeLog.md --------- Co-authored-by: Beisi Zhou <[email protected]> * FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (Azure#22343) * Add prIssueManagement.yml to onboard repo to GitOps.ResourceManagement as FabricBot replacement Owners of the FabricBot configuration should have received email notification. The same information contained in the email is published internally at: https://aka.ms/gim/fabricbot. Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html Please review and merge this PR to complete the process of onboarding to the new service. * Deleting fabricbot.json * Update resourceManagement.yml --------- Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Vincent Dai <[email protected]> * [KeyVault] Update TestSetting.ps1 to run on one platform and latest powershell (Azure#22618) * Update TestSetting.ps1 * Update KeyVault.sln * first set of changes * created initial powershell for ergwscale * edited changelog * update warning message (Azure#22619) * Fix to only include non-empty ExtendedLocation (Azure#22630) * Fix to only include non-empty ExtendedLocation * Updated ChangeLog.md * Remove PS 7.0 from smoke test (Azure#22569) * Alias Set-AzConfig (Azure#22629) * updated files due to failing test * formatting changes * formatting changes * Revert "formatting changes" This reverts commit d8900c5. * Revert " fixed merge issues" This reverts commit bc4af78, reversing changes made to d8900c5. * finished changes * formatting * formatting * formatting * edited ChangeLog * added empty line * added empty line between 6.1.1 and 6.1.0 --------- Co-authored-by: Azure PowerShell <[email protected]> Co-authored-by: NanxiangLiu <[email protected]> Co-authored-by: Yeming Liu <[email protected]> Co-authored-by: Yunchi Wang <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Saurav Raghuvanshi <[email protected]> Co-authored-by: YanaXu <[email protected]> Co-authored-by: Beisi Zhou <[email protected]> Co-authored-by: Andrey Goran <[email protected]> Co-authored-by: kevinzz6 <[email protected]> Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: Nalin Gaddis <[email protected]> Co-authored-by: Nalin Gaddis <[email protected]> Co-authored-by: Preston Alvarado <[email protected]> Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Yabo Hu <[email protected]> Co-authored-by: yifanz7 <[email protected]> Co-authored-by: Dante <[email protected]> Co-authored-by: yuc-Li <[email protected]> Co-authored-by: v-yuchenli <[email protected]> Co-authored-by: Adam Sandor <[email protected]> Co-authored-by: Jin Lei <[email protected]> Co-authored-by: mayankkatwal <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: myun12580 <[email protected]>
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.Batch
️✔️Az.CognitiveServices
️✔️Az.Compute
️✔️Az.ContainerRegistry
️✔️Az.CosmosDB
️✔️Az.DataLakeStore
️✔️Az.Dns
️✔️Az.EventHub
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
|
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 42.31 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 42.31% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 42.31% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 42.31% | Test coverage for the module cannot be lower than 50%. |
️✔️Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Breaking Change Check
❌PowerShell Core - Windows
Type Cmdlet Description Remediation ❌ New-AzApplicationGatewayFirewallCustomRuleGroupByVariable The validation set for parameter 'VariableName' for cmdlet 'New-AzApplicationGatewayFirewallCustomRuleGroupByVariable' no longer contains the value 'Geo'. Add 'Geo' back to the validation set for 'VariableName'. ❌Windows PowerShell - Windows
Type Cmdlet Description Remediation ❌ New-AzApplicationGatewayFirewallCustomRuleGroupByVariable The validation set for parameter 'VariableName' for cmdlet 'New-AzApplicationGatewayFirewallCustomRuleGroupByVariable' no longer contains the value 'Geo'. Add 'Geo' back to the validation set for 'VariableName'. ️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzVirtualNetworkGateway 2 5 Unassigned_Variable New-AzVirtualNetwork -Subnet $subnet is a null-valued parameter value. -Subnet Assign value for $subnet. ⚠️ New-AzVirtualNetworkGateway 3 8 Unassigned_Variable New-AzVpnClientRootCertificate -Name $clientRootCertName is a null-valued parameter value. -Name Assign value for $clientRootCertName. ⚠️ New-AzVirtualNetworkGateway 3 8 Unassigned_Variable New-AzVpnClientRootCertificate -PublicCertData $samplePublicCertData is a null-valued parameter value. -PublicCertData Assign value for $samplePublicCertData. ⚠️ New-AzVirtualNetworkGateway 4 5 Unassigned_Variable New-AzVirtualNetwork -Subnet $subnet is a null-valued parameter value. -Subnet Assign value for $subnet. ⚠️ Set-AzVirtualNetworkGateway 7 5 Mismatched_Parameter_Value_Type Set-AzVirtualNetworkGateway -NatRule $vngNatRules.NatRules is not an expected parameter value type. -NatRule Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetworkGatewayNatRule. Now the type is .(Command).
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzVirtualNetworkGateway 2 5 Unassigned_Variable New-AzVirtualNetwork -Subnet $subnet is a null-valued parameter value. -Subnet Assign value for $subnet. ⚠️ New-AzVirtualNetworkGateway 3 8 Unassigned_Variable New-AzVpnClientRootCertificate -Name $clientRootCertName is a null-valued parameter value. -Name Assign value for $clientRootCertName. ⚠️ New-AzVirtualNetworkGateway 3 8 Unassigned_Variable New-AzVpnClientRootCertificate -PublicCertData $samplePublicCertData is a null-valued parameter value. -PublicCertData Assign value for $samplePublicCertData. ⚠️ New-AzVirtualNetworkGateway 4 5 Unassigned_Variable New-AzVirtualNetwork -Subnet $subnet is a null-valued parameter value. -Subnet Assign value for $subnet. ⚠️ Set-AzVirtualNetworkGateway 7 5 Mismatched_Parameter_Value_Type Set-AzVirtualNetworkGateway -NatRule $vngNatRules.NatRules is not an expected parameter value type. -NatRule Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetworkGatewayNatRule. Now the type is .(Command). ️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.SignalR
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.