Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Geo for Rate Limiting Feature for Application Gateway Firewall Policy Settings #23104

Merged
merged 11 commits into from
Nov 6, 2023
Merged

Remove Geo for Rate Limiting Feature for Application Gateway Firewall Policy Settings #23104

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c7c3e91
new
Shawnli222 Oct 30, 2023
b1055a2
new
Shawnli222 Oct 30, 2023
6dd8b5a
Update ChangeLog.md
VeryEarly Nov 1, 2023
68add27
Update BreakingChangeIssues.csv
VeryEarly Nov 1, 2023
813212c
Merge branch 'main' into removegeomain2
VeryEarly Nov 2, 2023
3b3bda2
mistake
Shawnli222 Nov 2, 2023
a8dce0c
Merge branch 'removegeomain2' of https://github.com/Shawnli222/azure-…
Shawnli222 Nov 2, 2023
3652cc9
Update BreakingChangeIssues.csv
VeryEarly Nov 5, 2023
45fa7fb
Update ChangeLog.md
VeryEarly Nov 5, 2023
1a57196
Update ChangeLog.md
VeryEarly Nov 5, 2023
0f177f1
Update BreakingChangeIssues.csv
VeryEarly Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Network/Network/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
--->

## Upcoming Release
* [Breaking Change] Removed `Geo` as a valid input for parameter `VariableName` in `NewAzureApplicationGatewayFirewallCustomRuleGroupByVariable`.

## Version 6.2.0
* Added support for new Application Gateway SKU type, Basic SKU
Expand Down
4 changes: 1 addition & 3 deletions ...ion/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
// ----------------------------------------------------------------------------------

using Microsoft.Azure.Commands.Network.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using System.Linq;
using System.Management.Automation;

Expand All @@ -22,12 +21,11 @@ namespace Microsoft.Azure.Commands.Network
[Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ApplicationGatewayFirewallCustomRuleGroupByVariable"), OutputType(typeof(PSApplicationGatewayFirewallCustomRuleGroupByVariable))]
public class NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand : NetworkBaseCmdlet
{
[CmdletParameterBreakingChangeWithVersionAttribute("VariableName", "11.0.0", "7.0.0", ChangeDescription = "Geo would be invalid for parameter VariableName")]
[Parameter(
Mandatory = true,
HelpMessage = "User Session clause variable.")]
[ValidateNotNullOrEmpty]
[ValidateSet("ClientAddr", "Geo", "GeoLocation", "None", IgnoreCase = true)]
[ValidateSet("ClientAddr", "Geo", "None", IgnoreCase = true)]
public string VariableName { get; set; }

public override void ExecuteCmdlet()
Expand Down
2 changes: 1 addition & 1 deletion ...twork/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ User Session clause variable.
Type: System.String
Parameter Sets: (All)
Aliases:
Accepted values: ClientAddr, Geo, GeoLocation, None
Accepted values: ClientAddr, Geo, None

Required: True
Position: Named
Expand Down
Loading