Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Fabric Announce breaking changes #26378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mwesigwaguma
Copy link
Member

@mwesigwaguma mwesigwaguma commented Oct 17, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Oct 17, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@mwesigwaguma mwesigwaguma changed the title [Service Fabric] Breaking Change Preannounce Service Fabric Announce breaking changes Oct 17, 2024
@mwesigwaguma mwesigwaguma added the Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change label Oct 17, 2024
@VeryEarly
Copy link
Contributor

please read comments from this old PR: #25070
and you have missed the window for breaking change announcement, please targeting breaking changes next year

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@mwesigwaguma
Copy link
Member Author

please read comments from this old PR: #25070 and you have missed the window for breaking change announcement, please targeting breaking changes next year

hey @VeryEarly, can I release out of band preview version for now ?

@Nickcandy
Copy link
Contributor

Apologies @mwesigwaguma, the OOB release process only applies to regular releases. Any breaking changes can only be introduced during a major release.

@VeryEarly
Copy link
Contributor

please read comments from this old PR: #25070 and you have missed the window for breaking change announcement, please targeting breaking changes next year

hey @VeryEarly, can I release out of band preview version for now ?

preview version is acceptable, we can do preview release for it and you can make a proper breaking change announcement after ignite and target next build event.

@mwesigwaguma
Copy link
Member Author

please read comments from this old PR: #25070 and you have missed the window for breaking change announcement, please targeting breaking changes next year

hey @VeryEarly, can I release out of band preview version for now ?

preview version is acceptable, we can do preview release for it and you can make a proper breaking change announcement after ignite and target next build event.

okay, I'll put up a PR against Az.ServiceFabric-preview branch

@mwesigwaguma
Copy link
Member Author

please read comments from this old PR: #25070 and you have missed the window for breaking change announcement, please targeting breaking changes next year

hey @VeryEarly, can I release out of band preview version for now ?

preview version is acceptable, we can do preview release for it and you can make a proper breaking change announcement after ignite and target next build event.

okay, I'll put up a PR against Az.ServiceFabric-preview branch

Put up this PR for preview version #26445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change Do Not Merge 🚫
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants