Add into DNS Resolver new functionality for DNS Security Policy as part of 2023-07-01-preview release #26452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesvoongms
requested review from
isra-fel,
bilaakpan-ms,
Sandido,
haagha and
grizzlytheodore
as code owners
️✔️Az.Accounts
❌Az.DnsResolver
|
jamesvoongms
force-pushed
the
dev/jamesvoong/dns-security-policy-2023-07-01-preview-for-dns-resolver
branch
2 times, most recently
from
e1bdf2c
to
c04a973
Compare
jamesvoongms
force-pushed
the
dev/jamesvoong/dns-security-policy-2023-07-01-preview-for-dns-resolver
branch
2 times, most recently
from
fe8ede4
to
c1fa330
Compare
jamesvoongms
force-pushed
the
dev/jamesvoong/dns-security-policy-2023-07-01-preview-for-dns-resolver
branch
from
c1fa330
to
e953ab8
Compare
jamesvoongms
changed the title
|
Hi team, for the breaking change of systemData, that was removed from our class objects because it is now a part of the common inherited object now. |
|
May I have some help with the build issue as well? The CI/CD seems to be trying to pull from https://github.com/Azure/azure-rest-api-specs/blob/master/specification/dnsresolver/resource-manager/Microsoft.Network/preview/2023-07-01-preview/dnsresolver.json rather than the /blob/{commit_hash}/ |
Nickcandy
reviewed
Oct 25, 2024
| require: | ||
| - $(this-folder)/../../readme.azure.noprofile.md | ||
| - $(this-folder)/../../../tools/SwaggerCI/readme.azure.noprofile.md |
There was a problem hiding this comment.
This line should be the same with original
There was a problem hiding this comment.
Hi @Nickcandy , i am not seeing that the CI gives the error below due to the change here:
Would you know what the reason for this is?
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Nickcandy
reviewed
Oct 29, 2024
|
Note: for the breaking changes, we have since removed the properties (eg. SystemDataCreatedByType) from our models because they are now being inherited from the base azure classes. |
@jamesvoongms Do you mean it won't cause breaking actually? Additionally, I see test failure in CI. Can you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds new functionality for DNS Security Policy including the four new resources:
Swagger Spec PR: Azure/azure-rest-api-specs#30707
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.