Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AlertRules to microsoft.security insights 2021 10 01 #15657

Merged
merged 8 commits into from
Sep 22, 2021
Merged

Add AlertRules to microsoft.security insights 2021 10 01 #15657

merged 8 commits into from
Sep 22, 2021

Conversation

anat-gilenson
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[X] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @anat-gilenson Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-workflow-bot
    Copy link

    Hi, @anat-gilenson your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 16, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌LintDiff: 11 Errors, 27 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:

    Only 22 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.SecurityInsights/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/operations.json#L37
    ❌ R4029 - UniqueClientParameterName Do not have duplicate name of client parameter name, make sure every client parameter name unique. Client parameter #/parameters/SubscriptionIdParameter conflicted with #/parameters/SubscriptionId.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L49
    ❌ R4029 - UniqueClientParameterName Do not have duplicate name of client parameter name, make sure every client parameter name unique. Client parameter #/parameters/SubscriptionIdParameter conflicted with #/parameters/SubscriptionId.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L100
    ❌ R4029 - UniqueClientParameterName Do not have duplicate name of client parameter name, make sure every client parameter name unique. Client parameter #/parameters/SubscriptionIdParameter conflicted with #/parameters/SubscriptionId.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L149
    ❌ R4029 - UniqueClientParameterName Do not have duplicate name of client parameter name, make sure every client parameter name unique. Client parameter #/parameters/SubscriptionIdParameter conflicted with #/parameters/SubscriptionId.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L201
    ❌ R4029 - UniqueClientParameterName Do not have duplicate name of client parameter name, make sure every client parameter name unique. Client parameter #/parameters/SubscriptionIdParameter conflicted with #/parameters/SubscriptionId.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L246
    ❌ R4029 - UniqueClientParameterName Do not have duplicate name of client parameter name, make sure every client parameter name unique. Client parameter #/parameters/SubscriptionIdParameter conflicted with #/parameters/SubscriptionId.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L294
    ❌ R4029 - UniqueClientParameterName Do not have duplicate name of client parameter name, make sure every client parameter name unique. Client parameter #/parameters/SubscriptionIdParameter conflicted with #/parameters/SubscriptionId.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L340
    ❌ R4029 - UniqueClientParameterName Do not have duplicate name of client parameter name, make sure every client parameter name unique. Client parameter #/parameters/SubscriptionIdParameter conflicted with #/parameters/SubscriptionId.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L395
    ❌ R4029 - UniqueClientParameterName Do not have duplicate name of client parameter name, make sure every client parameter name unique. Client parameter #/parameters/SubscriptionIdParameter conflicted with #/parameters/SubscriptionId.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L443
    ❌ R4029 - UniqueClientParameterName Do not have duplicate name of client parameter name, make sure every client parameter name unique. Client parameter #/parameters/SubscriptionIdParameter conflicted with #/parameters/SubscriptionId.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L488
    ⚠️ R1003 - ListInOperationName Since operation 'ThreatIntelligenceIndicator_QueryIndicators' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/ThreatIntelligence.json#L311
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.SecurityInsights/stable/2021-10-01/ThreatIntelligence.json#L1028
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ThreatIntelligenceIndicatorMetrics_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/ThreatIntelligence.json#L352
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'comments' with immediate parent 'Incident', must have a list by immediate parent operation.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/Incidents.json#L1731
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'relations' with immediate parent 'Incident', must have a list by immediate parent operation.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/Incidents.json#L3137
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'watchlistItems' with immediate parent 'Watchlist', must have a list by immediate parent operation.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/Watchlists.json#L621
    ⚠️ R3017 - GuidUsage Guid used in model definition 'AccountEntityProperties' for property 'objectGuid'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/Incidents.json#L851
    ⚠️ R3017 - GuidUsage Guid used in model definition 'ClientInfo' for property 'objectId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/Incidents.json#L983
    ⚠️ R3017 - GuidUsage Guid used in model definition 'IncidentOwnerInfo' for property 'objectId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/Incidents.json#L1961
    ⚠️ R3017 - GuidUsage Guid used in model definition 'IoTDeviceEntityProperties' for property 'iotSecurityAgentId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/Incidents.json#L2219
    ⚠️ R3017 - GuidUsage Guid used in model definition 'MailboxEntityProperties' for property 'externalDirectoryObjectId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SecurityInsights/stable/2021-10-01/Incidents.json#L2388


    The following errors/warnings exist before current PR submission:

    Rule Message
    ❌ AutoRest exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"Duplicated model name with non-identical definitions"
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 15 Errors, 54 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 22 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'UebaSettings' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L522:3
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L522:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ToggleSettings' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L522:3
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L522:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupName' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L1396:3
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L1385:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SubscriptionId' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L1396:3
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L1385:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ApiVersion' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L1396:3
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L1385:3
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L49:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L49:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L100:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L100:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L149:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L149:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L201:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L201:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L246:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L246:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L294:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L294:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L340:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L340:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L395:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L395:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L443:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L443:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L488:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L488:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L49:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L49:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L100:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L100:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L149:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L149:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L201:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L201:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L246:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L246:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L294:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L294:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L340:9
    Old: Microsoft.SecurityInsights/stable/2020-01-01/AlertRules.json#L340:9


    The following breaking changes are detected by comparison with latest preview version:

    Only 22 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{operationalInsightsResourceProvider}/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/alertRules' removed or restructured?
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L37:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{operationalInsightsResourceProvider}/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/alertRules/{ruleId}' removed or restructured?
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L85:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{operationalInsightsResourceProvider}/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/alertRules/{ruleId}/actions' removed or restructured?
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L246:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{operationalInsightsResourceProvider}/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/alertRules/{ruleId}/actions/{actionId}' removed or restructured?
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L297:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{operationalInsightsResourceProvider}/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/alertRuleTemplates' removed or restructured?
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L455:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{operationalInsightsResourceProvider}/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/alertRuleTemplates/{alertRuleTemplateId}' removed or restructured?
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L503:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AlertRuleKindEnum' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L522:3
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L598:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MLBehaviorAnalyticsAlertRule' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L522:3
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L598:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MLBehaviorAnalyticsAlertRuleTemplate' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L522:3
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L598:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ThreatIntelligenceAlertRule' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L522:3
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L598:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ThreatIntelligenceAlertRuleTemplate' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L522:3
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L598:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'OperationalInsightsResourceProvider' removed or renamed?
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L1396:3
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L552:3
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'MLBehaviorAnalytics, ThreatIntelligence' from the old version.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L649:9
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L607:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'MLBehaviorAnalytics, ThreatIntelligence' from the old version.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L692:9
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L660:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'PreAttack' from the old version.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L832:5
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L839:5
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'PreAttack' from the old version.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L905:11
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L1019:11
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'MLBehaviorAnalytics, ThreatIntelligence' from the old version.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L649:9
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L607:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'PreAttack' from the old version.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L982:11
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L1054:15
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'MLBehaviorAnalytics, ThreatIntelligence' from the old version.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L692:9
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L660:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'Office 365 Advanced Threat Protection, Microsoft Defender Advanced Threat Protection' from the old version.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L1024:9
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L1214:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'MLBehaviorAnalytics, ThreatIntelligence' from the old version.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L649:9
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L607:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'Office 365 Advanced Threat Protection, Microsoft Defender Advanced Threat Protection' from the old version.
    New: Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json#L1024:9
    Old: Microsoft.SecurityInsights/preview/2021-03-01-preview/AlertRules.json#L1214:9
    ️⚠️[Staging] SDK Track2 Validation: 2 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ Modeler/MissingType "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"The schema 'components·1qaufw0·schemas·threatintelligenceindicatorproperties·properties·extensions·additionalproperties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/stable/2021-10-01/ThreatIntelligence.json#/components/schemas/components·1qaufw0·schemas·threatintelligenceindicatorproperties·properties·extensions·additionalproperties"
    ⚠️ Modeler/MissingType "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2021-04-01-only",
    "details":"The schema 'components·1qaufw0·schemas·threatintelligenceindicatorproperties·properties·extensions·additionalproperties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/stable/2021-04-01/ThreatIntelligence.json#/components/schemas/components·1qaufw0·schemas·threatintelligenceindicatorproperties·properties·extensions·additionalproperties"
    💬 AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"


    The following errors/warnings exist before current PR submission:

    Rule Message
    ❌ AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview",
    "details":"Error: Semantic validation failed. There was some errors"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2020-01",
    "details":"Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes"
    💬 AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2021-04-01-only",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2021-04-01-only",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2020-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2020-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2021-03-preview-only",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2021-03-preview-only",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️⚠️[Staging] SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ⚠️azure-sdk-for-go - securityinsight/mgmt/v1.0/securityinsight - v56.2.0
    +	Package was removed
    ️✔️azure-sdk-for-go - securityinsight/mgmt/2020-01-01/securityinsight - v56.2.0
    ⚠️azure-sdk-for-go - preview/securityinsight/mgmt/2019-01-01-preview/securityinsight - v56.2.0
    +	Const `KindAggregations` has been removed
+	Const `KindBasicEntityKindAccount` has been removed
+	Const `KindBasicEntityKindAzureResource` has been removed
+	Const `KindBasicEntityKindBookmark` has been removed
+	Const `KindBasicEntityKindCloudApplication` has been removed
+	Const `KindBasicEntityKindDNSResolution` has been removed
+	Const `KindBasicEntityKindEntity` has been removed
+	Const `KindBasicEntityKindFileHash` has been removed
+	Const `KindBasicEntityKindFile` has been removed
+	Const `KindBasicEntityKindHost` has been removed
+	Const `KindBasicEntityKindIP` has been removed
+	Const `KindBasicEntityKindIoTDevice` has been removed
+	Const `KindBasicEntityKindMailCluster` has been removed
+	Const `KindBasicEntityKindMailMessage` has been removed
+	Const `KindBasicEntityKindMailbox` has been removed
+	Const `KindBasicEntityKindMalware` has been removed
+	Const `KindBasicEntityKindProcess` has been removed
+	Const `KindBasicEntityKindRegistryKey` has been removed
+	Const `KindBasicEntityKindRegistryValue` has been removed
+	Const `KindBasicEntityKindSecurityAlert` has been removed
+	Const `KindBasicEntityKindSecurityGroup` has been removed
+	Const `KindBasicEntityKindSubmissionMail` has been removed
+	Const `KindBasicEntityKindURL` has been removed
+	Const `KindCasesAggregation` has been removed
+	Function `PossibleKindBasicEntityValues` has been removed
+	Function `ThreatIntelligenceIndicatorsClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
+	Function `ThreatIntelligenceIndicatorsClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
+	Function `ThreatIntelligenceIndicatorsClient.List` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
+	Type of `AccountEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `Aggregations.Kind` has been changed from `Kind` to `KindBasicAggregations`
+	Type of `AzureResourceEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `CasesAggregation.Kind` has been changed from `Kind` to `KindBasicAggregations`
+	Type of `CloudApplicationEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `DNSEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `Entity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `FileEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `FileHashEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `HostEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `HuntingBookmark.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `IPEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `IoTDeviceEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MailClusterEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MailMessageEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MailboxEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MalwareEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `ProcessEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `RegistryKeyEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `RegistryValueEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `SecurityAlert.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `SecurityGroupEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `SubmissionMailEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `URLEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 44efb1b571601393827af4f963cbe3ef3dabb884. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.SecurityInsights [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 44efb1b571601393827af4f963cbe3ef3dabb884. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️securityinsight/mgmt/v1.0/securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] This package was removed
    • ️✔️securityinsight/mgmt/2020-01-01/securityinsight [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️preview/securityinsight/mgmt/2019-01-01-preview/securityinsight [View full logs]  Breaking Change Detected
      Only show 40 items here, please refer to log for details.
      info	[Changelog] - New function `Anomalies.AsSettings() (*Settings, bool)`
info	[Changelog] - New function `NewIPGeodataClient(string) IPGeodataClient`
info	[Changelog] - New function `Anomalies.AsEntityAnalytics() (*EntityAnalytics, bool)`
info	[Changelog] - New function `IPGeodataClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `Anomalies.AsIPSyncer() (*IPSyncer, bool)`
info	[Changelog] - New function `Settings.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `Anomalies.AsEyesOn() (*EyesOn, bool)`
info	[Changelog] - New function `Anomalies.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `*Anomalies.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `Anomalies.AsBasicSettings() (BasicSettings, bool)`
info	[Changelog] - New function `NewDomainWhoisClient(string) DomainWhoisClient`
info	[Changelog] - New function `NewDomainWhoisClientWithBaseURI(string, string) DomainWhoisClient`
info	[Changelog] - New function `EyesOn.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `DomainWhoisClient.Get(context.Context, string, string) (EnrichmentDomainWhois, error)`
info	[Changelog] - New function `NewIPGeodataClientWithBaseURI(string, string) IPGeodataClient`
info	[Changelog] - New function `Anomalies.AsUeba() (*Ueba, bool)`
info	[Changelog] - New function `IPSyncer.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `Ueba.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `DomainWhoisClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `AnomaliesProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `DomainWhoisClient.GetResponder(*http.Response) (EnrichmentDomainWhois, error)`
info	[Changelog] - New function `IPGeodataClient.GetResponder(*http.Response) (EnrichmentIPGeodata, error)`
info	[Changelog] - New function `DomainWhoisClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `EntityAnalytics.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `IPGeodataClient.Get(context.Context, string, string) (EnrichmentIPGeodata, error)`
info	[Changelog] - New function `Anomalies.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleKindBasicAggregationsValues() []KindBasicAggregations`
info	[Changelog] - New struct `Anomalies`
info	[Changelog] - New struct `AnomaliesProperties`
info	[Changelog] - New struct `DomainWhoisClient`
info	[Changelog] - New struct `EnrichmentDomainWhois`
info	[Changelog] - New struct `EnrichmentDomainWhoisContact`
info	[Changelog] - New struct `EnrichmentDomainWhoisContacts`
info	[Changelog] - New struct `EnrichmentDomainWhoisDetails`
info	[Changelog] - New struct `EnrichmentDomainWhoisRegistrarDetails`
info	[Changelog] - New struct `EnrichmentIPGeodata`
info	[Changelog] - New struct `IPGeodataClient`
info	[Changelog]
info	[Changelog] Total 52 breaking change(s), 75 additive change(s).
info	[Changelog]
    ️❌ azure-sdk-for-python-track2 failed [Detail]
    • ❌Failed [Logs] Generate from 44efb1b571601393827af4f963cbe3ef3dabb884. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmdout	[automation_generate.sh] [Autorest]../azure-sdk-for-python_tmp/generateOutput.json does not exist!!!Error happened during package
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 44efb1b571601393827af4f963cbe3ef3dabb884. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
    • ️✔️@azure/arm-securityinsight [View full logs]  [Preview SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/securityInsights.js → ./dist/arm-securityinsight.js...
cmderr	[npmPack] created ./dist/arm-securityinsight.js in 650ms
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 44efb1b571601393827af4f963cbe3ef3dabb884. Azure CLI Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (Modeler/MissingType): The schema 'components·1qaufw0·schemas·threatintelligenceindicatorproperties·properties·extensions·additionalproperties' has no type or format information whatsoever. Location:
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Actions/put/Creates or updates an action of alert rule.
cmderr	[Autorest]     - name: /Actions/get/Get all actions of alert rule.
cmderr	[Autorest]     - name: /Actions/get/Get an action of alert rule.
cmderr	[Autorest]     - name: /Actions/delete/Delete an action of alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get all alert rules.
cmderr	[Autorest]     - name: /AlertRules/delete/Delete an alert rule.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
cmderr	[Autorest]     - name: /IncidentComments/put/Creates or updates an incident comment.
cmderr	[Autorest]     - name: /IncidentComments/get/Get all incident comments.
cmderr	[Autorest]     - name: /IncidentComments/get/Get an incident comment.
cmderr	[Autorest]     - name: /IncidentComments/delete/Delete the incident comment.
cmderr	[Autorest]     - name: /IncidentRelations/put/Creates or updates an incident relation.
cmderr	[Autorest]     - name: /IncidentRelations/get/Get all incident relations.
cmderr	[Autorest]     - name: /IncidentRelations/get/Get an incident relation.
cmderr	[Autorest]     - name: /IncidentRelations/delete/Delete the incident relation.
cmderr	[Autorest]     - name: /Incidents/put/Creates or updates an incident.
cmderr	[Autorest]     - name: /Incidents/get/Get all incidents.
cmderr	[Autorest]     - name: /Incidents/get/Get an incident.
cmderr	[Autorest]     - name: /Incidents/post/Get all incident alerts.
cmderr	[Autorest]     - name: /Incidents/post/Get all incident bookmarks.
cmderr	[Autorest]     - name: /Incidents/post/Gets all incident related entities
cmderr	[Autorest]     - name: /Incidents/delete/Delete an incident.
cmderr	[Autorest]     - name: /ThreatIntelligenceIndicator/put/Update a threat Intelligence indicator
cmderr	[Autorest]     - name: /ThreatIntelligenceIndicator/get/View a threat intelligence indicator by name
cmderr	[Autorest]     - name: /ThreatIntelligenceIndicator/post/Append tags to a threat intelligence indicator
cmderr	[Autorest]     - name: /ThreatIntelligenceIndicator/post/Create a new Threat Intelligence
cmderr	[Autorest]     - name: /ThreatIntelligenceIndicator/post/Query threat intelligence indicators as per filtering criteria
cmderr	[Autorest]     - name: /ThreatIntelligenceIndicator/post/Replace tags to a Threat Intelligence
cmderr	[Autorest]     - name: /ThreatIntelligenceIndicator/delete/Delete a threat intelligence indicator
cmderr	[Autorest]     - name: /ThreatIntelligenceIndicatorMetrics/get/Get threat intelligence indicators metrics.
cmderr	[Autorest]     - name: /ThreatIntelligenceIndicators/get/Get all threat intelligence indicators
cmderr	[Autorest]     - name: /WatchlistItems/put/Create or update a watchlist item.
cmderr	[Autorest]     - name: /WatchlistItems/get/Get a watchlist item.
cmderr	[Autorest]     - name: /WatchlistItems/get/Get all watchlist Items.
cmderr	[Autorest]     - name: /WatchlistItems/delete/Delete a watchlist item.
cmderr	[Autorest]     - name: /Watchlists/put/Create or update a watchlist and bulk creates watchlist items.
cmderr	[Autorest]     - name: /Watchlists/put/Create or update a watchlist.
cmderr	[Autorest]     - name: /Watchlists/get/Get a watchlist.
cmderr	[Autorest]     - name: /Watchlists/get/Get all watchlists.
cmderr	[Autorest]     - name: /Watchlists/delete/Delete a watchlist.
cmderr	[Autorest] --------------------------------------------------------
    • ️✔️securityinsight [View full logs]  [Preview Azure CLI Changes]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 44efb1b571601393827af4f963cbe3ef3dabb884. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh]  The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh]  so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh]
cmderr	[initScript.sh]  This is a one-time fix-up, please be patient...
cmderr	[initScript.sh]
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:2368) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:2368) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:2368) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    • ️✔️securityinsights [View full logs]  [Preview Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @anat-gilenson, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    This was referenced Aug 16, 2021
    Draft
    Draft
    @pilor pilor self-requested a review August 16, 2021 22:11
    @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 16, 2021
    This was referenced Aug 17, 2021
    Draft
    Draft
    laithhisham
    laithhisham reviewed Aug 24, 2021
    View reviewed changes
    ...curityinsights/resource-manager/Microsoft.SecurityInsights/stable/2021-10-01/AlertRules.json
    @@ -0,0 +1,1442 @@
    {
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Did you take the version from 2021-03-01-preview?
    because it seems that the enrichment models are missing

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    No, this version is based on the previous Stable.
    You'll have to add any changes to the previous Stable after this PR is merged.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 24, 2021
    @weidongxu-microsoft
    Copy link
    Member

    @anat-gilenson
    It is your own branch so I can merge whenever you need. However LintDiff might block you from merging to main.

    @weidongxu-microsoft weidongxu-microsoft merged commit 5961c8d into Azure:dev-securityinsights-Microsoft.SecurityInsights-2021-10-01 Sep 22, 2021
    dw511214992 pushed a commit that referenced this pull request Feb 28, 2022
    @anat-gilenson @laithhisham
    @royrein @akning-ms
    Dev securityinsights microsoft.security insights 2021 10 01 (#17924)
    3284dc9 
    * Adds base for updating Microsoft.SecurityInsights from version stable/2021-04-01 to version 2021-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AlertRules to microsoft.security insights 2021 10 01 (#15657)

* Adds base for updating Microsoft.SecurityInsight's AlertRules from version stable/2020-01-01 to version 2021-10-01

* Updates API version in AlertRules specs and examples

* Use common types in AlertRules.json and remove redundant SecurityInsights

* Add AlertRules to readme

* Copy action examples for alert rules

* Add type:object where missing

* Align CloudError with rest of the resources in this version

* Update readme

Co-authored-by: Anat Gilenson <[email protected]>

* Use newest common types to align with rest of Azure (#16130)

* Use newest common types to align with rest of Azure

* Use ErrorResponse instead of CloudError in operations

Co-authored-by: Anat Gilenson <[email protected]>

* Add AlertRules Stable version to 2021-10-01 (#16268)

* Add AlertRules Stable version to 2021-10-01

* Fix missing alignment in common types

* prettier fixes

* move tactics and severity to common

* fix common types file extension

* more prettier fixes

* Add template version field

* prettier

* added version to required fields

* dummy change to trigger checks again

* Add onboarding states to new stable version (#16290)

* Add onboarding states to new stable version

* Update readme.md

* cr fix - remove unused params

* Add missing resources 2021 10 01 (#16666)

* Add missing resources and examples from 2020-01-01

* Update version in added resources and examples

* Use existing common types

* Remove unnesessary SecurityInsights.json

* Update readme

* Use sentinel common types in Incidents and Watchlist

* Extract and common IncidentInfo and IncidentSeverity

* Extract EntityTypes

* Correct double allOf in EntityTypes

* update readme

* Remove eventGroupingSettings and entityMappings from GetAlertRuleTemplateById example.

* rename operations.json

Co-authored-by: Anat Gilenson <[email protected]>

* Fix analytics templates model (#16689)

* add missing properties to scheduled template

* prettier fixes

* restore templates example after merge

* fix templates example after merge and run prettier

* Use CloudError instead of ErrorResponse to align with preview versions and our back-end. (#17472)

* Automation - Stable Version (#17491)

* First

* readMe

* cloudError

* CloudError

* schema

* prettier

* Fix

* test

* fix identifier

* fix description

* fix lable

* fix lable

* ownerInfo

* Fix

* types

* conditionMaxLength

Co-authored-by: Roy Reinhorn <[email protected]>

* Done (#17728)

Co-authored-by: Roy Reinhorn <[email protected]>

* Correct 2021 10 01 (#17830)

* Remove OperationalInsightsResourceProvider parameter in ThreatIntelligence

* Remove OperationalInsightProviderParameter from Watchlist

* Align stable operation names with preview

* Add missing disciminator property in ThreatIntelligence

* Done (#17844)

Co-authored-by: Roy Reinhorn <[email protected]>

* Align enum names with preview (#17831)

* Fix 2021 10 01 validation errors (#17937)

* Add x-ms-identifiers to all arrays

* Add operations_list example

* Add x-ms-identifier in all arrays

* Run prettier

* Fix spelling error

* Add isDataAction to operation schema (#18018)

Co-authored-by: Anat Gilenson <[email protected]>
Co-authored-by: laithhisham <[email protected]>
Co-authored-by: royrein <[email protected]>
Co-authored-by: Roy Reinhorn <[email protected]>
Co-authored-by: Arthur Ning <[email protected]>
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022
    @anat-gilenson @laithhisham
    @royrein @akning-ms @FredericHeem
    Dev securityinsights microsoft.security insights 2021 10 01 (Azure#17924
    09047d8 
    )

* Adds base for updating Microsoft.SecurityInsights from version stable/2021-04-01 to version 2021-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AlertRules to microsoft.security insights 2021 10 01 (Azure#15657)

* Adds base for updating Microsoft.SecurityInsight's AlertRules from version stable/2020-01-01 to version 2021-10-01

* Updates API version in AlertRules specs and examples

* Use common types in AlertRules.json and remove redundant SecurityInsights

* Add AlertRules to readme

* Copy action examples for alert rules

* Add type:object where missing

* Align CloudError with rest of the resources in this version

* Update readme

Co-authored-by: Anat Gilenson <[email protected]>

* Use newest common types to align with rest of Azure (Azure#16130)

* Use newest common types to align with rest of Azure

* Use ErrorResponse instead of CloudError in operations

Co-authored-by: Anat Gilenson <[email protected]>

* Add AlertRules Stable version to 2021-10-01 (Azure#16268)

* Add AlertRules Stable version to 2021-10-01

* Fix missing alignment in common types

* prettier fixes

* move tactics and severity to common

* fix common types file extension

* more prettier fixes

* Add template version field

* prettier

* added version to required fields

* dummy change to trigger checks again

* Add onboarding states to new stable version (Azure#16290)

* Add onboarding states to new stable version

* Update readme.md

* cr fix - remove unused params

* Add missing resources 2021 10 01 (Azure#16666)

* Add missing resources and examples from 2020-01-01

* Update version in added resources and examples

* Use existing common types

* Remove unnesessary SecurityInsights.json

* Update readme

* Use sentinel common types in Incidents and Watchlist

* Extract and common IncidentInfo and IncidentSeverity

* Extract EntityTypes

* Correct double allOf in EntityTypes

* update readme

* Remove eventGroupingSettings and entityMappings from GetAlertRuleTemplateById example.

* rename operations.json

Co-authored-by: Anat Gilenson <[email protected]>

* Fix analytics templates model (Azure#16689)

* add missing properties to scheduled template

* prettier fixes

* restore templates example after merge

* fix templates example after merge and run prettier

* Use CloudError instead of ErrorResponse to align with preview versions and our back-end. (Azure#17472)

* Automation - Stable Version (Azure#17491)

* First

* readMe

* cloudError

* CloudError

* schema

* prettier

* Fix

* test

* fix identifier

* fix description

* fix lable

* fix lable

* ownerInfo

* Fix

* types

* conditionMaxLength

Co-authored-by: Roy Reinhorn <[email protected]>

* Done (Azure#17728)

Co-authored-by: Roy Reinhorn <[email protected]>

* Correct 2021 10 01 (Azure#17830)

* Remove OperationalInsightsResourceProvider parameter in ThreatIntelligence

* Remove OperationalInsightProviderParameter from Watchlist

* Align stable operation names with preview

* Add missing disciminator property in ThreatIntelligence

* Done (Azure#17844)

Co-authored-by: Roy Reinhorn <[email protected]>

* Align enum names with preview (Azure#17831)

* Fix 2021 10 01 validation errors (Azure#17937)

* Add x-ms-identifiers to all arrays

* Add operations_list example

* Add x-ms-identifier in all arrays

* Run prettier

* Fix spelling error

* Add isDataAction to operation schema (Azure#18018)

Co-authored-by: Anat Gilenson <[email protected]>
Co-authored-by: laithhisham <[email protected]>
Co-authored-by: royrein <[email protected]>
Co-authored-by: Roy Reinhorn <[email protected]>
Co-authored-by: Arthur Ning <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @laithhisham laithhisham laithhisham left review comments

    @weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

    @pilor pilor Awaiting requested review from pilor

    Assignees

    @weidongxu-microsoft weidongxu-microsoft

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-FixRequiredOnFailure
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @anat-gilenson @weidongxu-microsoft @laithhisham @pilor @JeffreyRichter