Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Nic entity type and IoT Device properties to EntityTypes.json #18536

Closed
wants to merge 5 commits into from
Closed

Added Nic entity type and IoT Device properties to EntityTypes.json #18536

wants to merge 5 commits into from

Conversation

nmizrahi6
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

###Description

  • Added a new entity type (Nic) in EntityTypes.json
  • Added properties to IoT Device entity type

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?

    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify

  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

    May 2022

  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

    May 2022

  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @nmizrahi6 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 4, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 3 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isAuthorized
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L1080
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isProgramming
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L1085
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isScanner
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L1090


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R3017 - GuidUsage Guid used in model definition 'AccountEntityProperties' for property 'objectGuid'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L69
    ⚠️ R3017 - GuidUsage Guid used in model definition 'IoTDeviceEntityProperties' for property 'iotSecurityAgentId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L935
    ⚠️ R3017 - GuidUsage Guid used in model definition 'MailboxEntityProperties' for property 'externalDirectoryObjectId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L1229
    ⚠️ R3017 - GuidUsage Guid used in model definition 'MailMessageEntityProperties' for property 'networkMessageId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L1455
    ⚠️ R3017 - GuidUsage Guid used in model definition 'SecurityGroupEntityProperties' for property 'objectGuid'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L2365
    ⚠️ R3017 - GuidUsage Guid used in model definition 'SubmissionMailEntityProperties' for property 'networkMessageId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L2404
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDomainJoined
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L59
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDomainJoined
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L744
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isVolumeAnomaly
    Location: preview/2022-05-01-preview/common/EntityTypes.json#L1315
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 4, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ⚠️azure-sdk-for-go-track2 - armsecurityinsights - 0.2.0
    +	Const `IncidentLabelTypeSystem` has been removed
+	Const `SourceLocalFile` has been removed
+	Const `SourceRemoteStorage` has been removed
+	Field `IsEnabled` of struct `EntityAnalyticsProperties` has been removed
+	Field `WatchlistItemsCount` of struct `WatchlistProperties` has been removed
+	Function `*AutomationRulesClient.ManualTriggerPlaybook` has been removed
+	Function `*QueryBasedAlertRuleProperties.UnmarshalJSON` has been removed
+	Function `*ThreatIntelligenceIndicatorClient.CreateIndicator` parameter(s) have been changed from `(context.Context, string, string, ThreatIntelligenceIndicatorModelForRequestBody, *ThreatIntelligenceIndicatorClientCreateIndicatorOptions)` to `(context.Context, string, string, ThreatIntelligenceIndicatorModel, *ThreatIntelligenceIndicatorClientCreateIndicatorOptions)`
+	Function `*ThreatIntelligenceIndicatorClient.Create` parameter(s) have been changed from `(context.Context, string, string, string, ThreatIntelligenceIndicatorModelForRequestBody, *ThreatIntelligenceIndicatorClientCreateOptions)` to `(context.Context, string, string, string, ThreatIntelligenceIndicatorModel, *ThreatIntelligenceIndicatorClientCreateOptions)`
+	Function `*ThreatIntelligenceIndicatorClient.ReplaceTags` parameter(s) have been changed from `(context.Context, string, string, string, ThreatIntelligenceIndicatorModelForRequestBody, *ThreatIntelligenceIndicatorClientReplaceTagsOptions)` to `(context.Context, string, string, string, ThreatIntelligenceIndicatorModel, *ThreatIntelligenceIndicatorClientReplaceTagsOptions)`
+	Function `*ThreatIntelligenceIndicatorModel.GetThreatIntelligenceResourceKind` has been removed
+	Function `*ThreatIntelligenceIndicatorModelForRequestBody.GetThreatIntelligenceResourceKind` has been removed
+	Function `*ThreatIntelligenceIndicatorModelForRequestBody.UnmarshalJSON` has been removed
+	Function `*ThreatIntelligenceInformation.GetThreatIntelligenceResourceKind` has been removed
+	Function `*ThreatIntelligenceInformation.UnmarshalJSON` has been removed
+	Function `*ThreatIntelligenceResourceKind.GetThreatIntelligenceResourceKind` has been removed
+	Function `PossibleSourceValues` has been removed
+	Function `QueryBasedAlertRuleProperties.MarshalJSON` has been removed
+	Function `Source.ToPtr` has been removed
+	Function `ThreatIntelligenceIndicatorModelForRequestBody.MarshalJSON` has been removed
+	Function `ThreatIntelligenceInformation.MarshalJSON` has been removed
+	Struct `AutomationRulesClientManualTriggerPlaybookOptions` has been removed
+	Struct `AutomationRulesClientManualTriggerPlaybookResponse` has been removed
+	Struct `AutomationRulesClientManualTriggerPlaybookResult` has been removed
+	Struct `QueryBasedAlertRuleProperties` has been removed
+	Struct `ThreatIntelligenceIndicatorModelForRequestBody` has been removed
+	Struct `ThreatIntelligenceResourceKind` has been removed
+	Type of `WatchlistItemProperties.EntityMapping` has been changed from `interface{}` to `map[string]interface{}`
+	Type of `WatchlistItemProperties.ItemsKeyValue` has been changed from `interface{}` to `map[string]interface{}`
+	Type of `WatchlistProperties.Source` has been changed from `*Source` to `*string`
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-securityinsight - 1.0.0b2
    ⚠️azure-sdk-for-go - securityinsight/mgmt/2020-01-01/securityinsight - v63.0.0
    +	Const `CaseSeverityCritical` has been removed
+	Const `CaseSeverityHigh` has been removed
+	Const `CaseSeverityInformational` has been removed
+	Const `CaseSeverityLow` has been removed
+	Const `CaseSeverityMedium` has been removed
+	Const `KindBasicSettingsKindSettings` has been removed
+	Const `KindBasicSettingsKindToggleSettings` has been removed
+	Const `KindBasicSettingsKindUebaSettings` has been removed
+	Const `LicenseStatusDisabled` has been removed
+	Const `LicenseStatusEnabled` has been removed
+	Const `SettingKindToggleSettings` has been removed
+	Const `SettingKindUebaSettings` has been removed
+	Const `StatusInMcasDisabled` has been removed
+	Const `StatusInMcasEnabled` has been removed
+	Function `*ToggleSettings.UnmarshalJSON` has been removed
+	Function `*UebaSettings.UnmarshalJSON` has been removed
+	Function `PossibleCaseSeverityValues` has been removed
+	Function `PossibleKindBasicSettingsValues` has been removed
+	Function `PossibleLicenseStatusValues` has been removed
+	Function `PossibleSettingKindValues` has been removed
+	Function `PossibleStatusInMcasValues` has been removed
+	Function `Settings.AsBasicSettings` has been removed
+	Function `Settings.AsSettings` has been removed
+	Function `Settings.AsToggleSettings` has been removed
+	Function `Settings.AsUebaSettings` has been removed
+	Function `Settings.MarshalJSON` has been removed
+	Function `ToggleSettings.AsBasicSettings` has been removed
+	Function `ToggleSettings.AsSettings` has been removed
+	Function `ToggleSettings.AsToggleSettings` has been removed
+	Function `ToggleSettings.AsUebaSettings` has been removed
+	Function `ToggleSettings.MarshalJSON` has been removed
+	Function `UebaSettings.AsBasicSettings` has been removed
+	Function `UebaSettings.AsSettings` has been removed
+	Function `UebaSettings.AsToggleSettings` has been removed
+	Function `UebaSettings.AsUebaSettings` has been removed
+	Function `UebaSettings.MarshalJSON` has been removed
+	Function `UebaSettingsProperties.MarshalJSON` has been removed
+	Struct `Settings` has been removed
+	Struct `ToggleSettingsProperties` has been removed
+	Struct `ToggleSettings` has been removed
+	Struct `UebaSettingsProperties` has been removed
+	Struct `UebaSettings` has been removed
+	Type of `IncidentInfo.Severity` has been changed from `CaseSeverity` to `IncidentSeverity`
    ⚠️azure-sdk-for-go - preview/securityinsight/mgmt/2022-01-01-preview/securityinsight - v63.0.0
    +	Type of `WatchlistItemProperties.EntityMapping` has been changed from `interface{}` to `map[string]interface{}`
+	Type of `WatchlistItemProperties.ItemsKeyValue` has been changed from `interface{}` to `map[string]interface{}`
    ⚠️azure-sdk-for-go - preview/securityinsight/mgmt/2021-09-01-preview/securityinsight - v63.0.0
    +	Function `ErrorAdditionalInfo.MarshalJSON` has been removed
+	Function `ErrorDetail.MarshalJSON` has been removed
+	Struct `ErrorAdditionalInfo` has been removed
+	Struct `ErrorDetail` has been removed
+	Struct `ErrorResponse` has been removed
    ⚠️azure-sdk-for-go - preview/securityinsight/mgmt/2019-01-01-preview/securityinsight - v63.0.0
    +	Const `KindAggregations` has been removed
+	Const `KindBasicEntityKindAccount` has been removed
+	Const `KindBasicEntityKindAzureResource` has been removed
+	Const `KindBasicEntityKindBookmark` has been removed
+	Const `KindBasicEntityKindCloudApplication` has been removed
+	Const `KindBasicEntityKindDNSResolution` has been removed
+	Const `KindBasicEntityKindEntity` has been removed
+	Const `KindBasicEntityKindFileHash` has been removed
+	Const `KindBasicEntityKindFile` has been removed
+	Const `KindBasicEntityKindHost` has been removed
+	Const `KindBasicEntityKindIP` has been removed
+	Const `KindBasicEntityKindIoTDevice` has been removed
+	Const `KindBasicEntityKindMailCluster` has been removed
+	Const `KindBasicEntityKindMailMessage` has been removed
+	Const `KindBasicEntityKindMailbox` has been removed
+	Const `KindBasicEntityKindMalware` has been removed
+	Const `KindBasicEntityKindProcess` has been removed
+	Const `KindBasicEntityKindRegistryKey` has been removed
+	Const `KindBasicEntityKindRegistryValue` has been removed
+	Const `KindBasicEntityKindSecurityAlert` has been removed
+	Const `KindBasicEntityKindSecurityGroup` has been removed
+	Const `KindBasicEntityKindSubmissionMail` has been removed
+	Const `KindBasicEntityKindURL` has been removed
+	Const `KindCasesAggregation` has been removed
+	Function `PossibleKindBasicEntityValues` has been removed
+	Function `ThreatIntelligenceIndicatorsClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
+	Function `ThreatIntelligenceIndicatorsClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
+	Function `ThreatIntelligenceIndicatorsClient.List` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
+	Type of `AccountEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `Aggregations.Kind` has been changed from `Kind` to `KindBasicAggregations`
+	Type of `AzureResourceEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `CasesAggregation.Kind` has been changed from `Kind` to `KindBasicAggregations`
+	Type of `CloudApplicationEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `DNSEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `Entity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `FileEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `FileHashEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `HostEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `HuntingBookmark.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `IPEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `IncidentInfo.Severity` has been changed from `CaseSeverity` to `IncidentSeverity`
+	Type of `IoTDeviceEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MailClusterEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MailMessageEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MailboxEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `MalwareEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `ProcessEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `RegistryKeyEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `RegistryValueEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `SecurityAlert.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `SecurityGroupEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `SubmissionMailEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
+	Type of `URLEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    ️✔️azure-sdk-for-js - @azure/arm-securityinsight - 1.0.0-beta.3
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs] Generate from 9499fb9d2e4b074b1ef440fa471aaa7676666584. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.SecurityInsights        [View full logs]         [Preview SDK Changes]      
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs] Generate from 9499fb9d2e4b074b1ef440fa471aaa7676666584. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️securityinsight/mgmt/2020-01-01/securityinsight        [View full logs]         [Preview SDK Changes]      
            Only show 30 items here, please refer to log for details.
      info	[Changelog] - Function `ToggleSettings.AsBasicSettings` has been removed
info	[Changelog] - Function `UebaSettings.MarshalJSON` has been removed
info	[Changelog] - Function `PossibleSettingKindValues` has been removed
info	[Changelog] - Function `UebaSettings.AsBasicSettings` has been removed
info	[Changelog] - Function `PossibleKindBasicSettingsValues` has been removed
info	[Changelog] - Function `UebaSettings.AsToggleSettings` has been removed
info	[Changelog] - Function `UebaSettingsProperties.MarshalJSON` has been removed
info	[Changelog] - Function `PossibleLicenseStatusValues` has been removed
info	[Changelog] - Function `ToggleSettings.MarshalJSON` has been removed
info	[Changelog] - Function `UebaSettings.AsUebaSettings` has been removed
info	[Changelog] - Function `Settings.AsToggleSettings` has been removed
info	[Changelog] - Function `*UebaSettings.UnmarshalJSON` has been removed
info	[Changelog] - Function `Settings.AsSettings` has been removed
info	[Changelog] - Function `PossibleStatusInMcasValues` has been removed
info	[Changelog] - Function `ToggleSettings.AsSettings` has been removed
info	[Changelog] - Function `Settings.AsUebaSettings` has been removed
info	[Changelog] - Function `*ToggleSettings.UnmarshalJSON` has been removed
info	[Changelog] - Function `Settings.MarshalJSON` has been removed
info	[Changelog] - Function `UebaSettings.AsSettings` has been removed
info	[Changelog] - Function `Settings.AsBasicSettings` has been removed
info	[Changelog] - Function `ToggleSettings.AsUebaSettings` has been removed
info	[Changelog] - Function `ToggleSettings.AsToggleSettings` has been removed
info	[Changelog] - Function `PossibleCaseSeverityValues` has been removed
info	[Changelog] - Struct `Settings` has been removed
info	[Changelog] - Struct `ToggleSettings` has been removed
info	[Changelog] - Struct `ToggleSettingsProperties` has been removed
info	[Changelog] - Struct `UebaSettings` has been removed
info	[Changelog] - Struct `UebaSettingsProperties` has been removed
info	[Changelog]
info	[Changelog] Total 49 breaking change(s), 0 additive change(s).
    • ️✔️preview/securityinsight/mgmt/2022-01-01-preview/securityinsight        [View full logs]       
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `WatchlistItemProperties.ItemsKeyValue` has been changed from `interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `WatchlistItemProperties.EntityMapping` has been changed from `interface{}` to `map[string]interface{}`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `ProvisioningStateInProgress`
info	[Changelog] - New const `ProvisioningStateCanceled`
info	[Changelog] - New const `ProvisioningStateSucceeded`
info	[Changelog] - New const `ProvisioningStateFailed`
info	[Changelog] - New function `WatchlistItemProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `WatchlistProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleProvisioningStateValues() []ProvisioningState`
info	[Changelog] - New field `ProvisioningState` in struct `WatchlistProperties`
info	[Changelog] - New field `SasURI` in struct `WatchlistProperties`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 8 additive change(s).
    • ️✔️preview/securityinsight/mgmt/2021-09-01-preview/securityinsight        [View full logs]       
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ErrorDetail.MarshalJSON` has been removed
info	[Changelog] - Function `ErrorAdditionalInfo.MarshalJSON` has been removed
info	[Changelog] - Struct `ErrorAdditionalInfo` has been removed
info	[Changelog] - Struct `ErrorDetail` has been removed
info	[Changelog] - Struct `ErrorResponse` has been removed
info	[Changelog]
info	[Changelog] Total 8 breaking change(s), 0 additive change(s).
    • ️✔️preview/securityinsight/mgmt/2019-01-01-preview/securityinsight        [View full logs]       
            Only show 30 items here, please refer to log for details.
      info	[Changelog] - New function `EyesOn.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `NewIPGeodataClient(string) IPGeodataClient`
info	[Changelog] - New function `DomainWhoisClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `Anomalies.AsEntityAnalytics() (*EntityAnalytics, bool)`
info	[Changelog] - New function `Settings.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `Anomalies.AsSettings() (*Settings, bool)`
info	[Changelog] - New function `EntityAnalytics.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `Ueba.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `DomainWhoisClient.GetResponder(*http.Response) (EnrichmentDomainWhois, error)`
info	[Changelog] - New function `IPGeodataClient.GetResponder(*http.Response) (EnrichmentIPGeodata, error)`
info	[Changelog] - New function `IPGeodataClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `IPSyncer.AsAnomalies() (*Anomalies, bool)`
info	[Changelog] - New function `Anomalies.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `Anomalies.AsIPSyncer() (*IPSyncer, bool)`
info	[Changelog] - New function `NewDomainWhoisClient(string) DomainWhoisClient`
info	[Changelog] - New function `Anomalies.AsUeba() (*Ueba, bool)`
info	[Changelog] - New function `PossibleKindBasicAggregationsValues() []KindBasicAggregations`
info	[Changelog] - New function `AnomaliesProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `Anomalies`
info	[Changelog] - New struct `AnomaliesProperties`
info	[Changelog] - New struct `DomainWhoisClient`
info	[Changelog] - New struct `EnrichmentDomainWhois`
info	[Changelog] - New struct `EnrichmentDomainWhoisContact`
info	[Changelog] - New struct `EnrichmentDomainWhoisContacts`
info	[Changelog] - New struct `EnrichmentDomainWhoisDetails`
info	[Changelog] - New struct `EnrichmentDomainWhoisRegistrarDetails`
info	[Changelog] - New struct `EnrichmentIPGeodata`
info	[Changelog] - New struct `IPGeodataClient`
info	[Changelog]
info	[Changelog] Total 53 breaking change(s), 75 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs] Generate from 9499fb9d2e4b074b1ef440fa471aaa7676666584. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armsecurityinsights        [View full logs]         [Preview SDK Changes]        Breaking Change Detected
            Only show 120 items here, please refer to log for details.
      info	[Changelog] - Struct `QueryBasedAlertRuleProperties` has been removed
info	[Changelog] - Struct `ThreatIntelligenceIndicatorModelForRequestBody` has been removed
info	[Changelog] - Struct `ThreatIntelligenceResourceKind` has been removed
info	[Changelog] - Field `WatchlistItemsCount` of struct `WatchlistProperties` has been removed
info	[Changelog] - Field `IsEnabled` of struct `EntityAnalyticsProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `DeviceImportanceUnknown`
info	[Changelog] - New const `DeploymentResultCanceled`
info	[Changelog] - New const `DeviceImportanceLow`
info	[Changelog] - New const `EntityProvidersActiveDirectory`
info	[Changelog] - New const `DeploymentStateInProgress`
info	[Changelog] - New const `DeploymentFetchStatusSuccess`
info	[Changelog] - New const `DeviceImportanceHigh`
info	[Changelog] - New const `DeploymentStateCompleted`
info	[Changelog] - New const `KindAutomationRule`
info	[Changelog] - New const `EntityProvidersAzureActiveDirectory`
info	[Changelog] - New const `DataConnectorKindIOT`
info	[Changelog] - New const `DeploymentFetchStatusNotFound`
info	[Changelog] - New const `DeploymentResultSuccess`
info	[Changelog] - New const `VersionV2`
info	[Changelog] - New const `VersionV1`
info	[Changelog] - New const `KindLogicAppsCustomConnector`
info	[Changelog] - New const `SourceTypeLocalFile`
info	[Changelog] - New const `DeploymentResultFailed`
info	[Changelog] - New const `DeviceImportanceNormal`
info	[Changelog] - New const `EntityKindNic`
info	[Changelog] - New const `IncidentLabelTypeAutoAssigned`
info	[Changelog] - New const `DeploymentFetchStatusUnauthorized`
info	[Changelog] - New const `DeploymentStateCanceling`
info	[Changelog] - New const `SourceTypeRemoteStorage`
info	[Changelog] - New const `DeploymentStateQueued`
info	[Changelog] - New const `KindAzureFunction`
info	[Changelog] - New const `EntityTypeNic`
info	[Changelog] - New function `*NicEntity.GetEntity() *Entity`
info	[Changelog] - New function `*NicEntity.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `DeviceImportance.ToPtr() *DeviceImportance`
info	[Changelog] - New function `*IncidentsClient.RunPlaybook(context.Context, string, string, string, *IncidentsClientRunPlaybookOptions) (IncidentsClientRunPlaybookResponse, error)`
info	[Changelog] - New function `IoTDataConnector.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*Deployment.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `DeploymentResult.ToPtr() *DeploymentResult`
info	[Changelog] - New function `PossibleDeploymentStateValues() []DeploymentState`
info	[Changelog] - New function `DeploymentFetchStatus.ToPtr() *DeploymentFetchStatus`
info	[Changelog] - New function `PossibleDeploymentFetchStatusValues() []DeploymentFetchStatus`
info	[Changelog] - New function `IoTCheckRequirements.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleVersionValues() []Version`
info	[Changelog] - New function `*IoTDataConnector.GetDataConnector() *DataConnector`
info	[Changelog] - New function `*IoTCheckRequirements.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PossibleDeviceImportanceValues() []DeviceImportance`
info	[Changelog] - New function `*IoTCheckRequirements.GetDataConnectorsCheckRequirements() *DataConnectorsCheckRequirements`
info	[Changelog] - New function `Version.ToPtr() *Version`
info	[Changelog] - New function `DeploymentState.ToPtr() *DeploymentState`
info	[Changelog] - New function `NicEntity.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `NicEntityProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleDeploymentResultValues() []DeploymentResult`
info	[Changelog] - New function `EntityProviders.ToPtr() *EntityProviders`
info	[Changelog] - New function `Deployment.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ScheduledAlertRuleCommonProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `EntityAnalyticsProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `SourceType.ToPtr() *SourceType`
info	[Changelog] - New function `*IoTDataConnector.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PossibleSourceTypeValues() []SourceType`
info	[Changelog] - New function `PossibleEntityProvidersValues() []EntityProviders`
info	[Changelog] - New struct `AzureDevOpsResourceInfo`
info	[Changelog] - New struct `Deployment`
info	[Changelog] - New struct `DeploymentInfo`
info	[Changelog] - New struct `GitHubResourceInfo`
info	[Changelog] - New struct `IncidentsClientRunPlaybookOptions`
info	[Changelog] - New struct `IncidentsClientRunPlaybookResponse`
info	[Changelog] - New struct `IncidentsClientRunPlaybookResult`
info	[Changelog] - New struct `IoTCheckRequirements`
info	[Changelog] - New struct `IoTCheckRequirementsProperties`
info	[Changelog] - New struct `IoTDataConnector`
info	[Changelog] - New struct `IoTDataConnectorProperties`
info	[Changelog] - New struct `NicEntity`
info	[Changelog] - New struct `NicEntityProperties`
info	[Changelog] - New struct `RepositoryResourceInfo`
info	[Changelog] - New struct `WatchlistsClientDeleteResult`
info	[Changelog] - New struct `Webhook`
info	[Changelog] - New field `AlertDetailsOverride` in struct `ScheduledAlertRuleCommonProperties`
info	[Changelog] - New field `Query` in struct `ScheduledAlertRuleCommonProperties`
info	[Changelog] - New field `Severity` in struct `ScheduledAlertRuleCommonProperties`
info	[Changelog] - New field `CustomDetails` in struct `ScheduledAlertRuleCommonProperties`
info	[Changelog] - New field `EntityMappings` in struct `ScheduledAlertRuleCommonProperties`
info	[Changelog] - New field `SourceType` in struct `WatchlistProperties`
info	[Changelog] - New field `Version` in struct `SourceControlProperties`
info	[Changelog] - New field `LastDeploymentInfo` in struct `SourceControlProperties`
info	[Changelog] - New field `RepositoryResourceInfo` in struct `SourceControlProperties`
info	[Changelog] - New field `EntityProviders` in struct `EntityAnalyticsProperties`
info	[Changelog] - New field `ContentSchemaVersion` in struct `MetadataPropertiesPatch`
info	[Changelog] - New field `CustomVersion` in struct `MetadataPropertiesPatch`
info	[Changelog] - New field `Icon` in struct `MetadataPropertiesPatch`
info	[Changelog] - New field `PreviewImagesDark` in struct `MetadataPropertiesPatch`
info	[Changelog] - New field `PreviewImages` in struct `MetadataPropertiesPatch`
info	[Changelog] - New field `ThreatAnalysisTactics` in struct `MetadataPropertiesPatch`
info	[Changelog] - New field `ThreatAnalysisTechniques` in struct `MetadataPropertiesPatch`
info	[Changelog] - New field `AzureAsyncOperation` in struct `WatchlistsClientCreateOrUpdateResult`
info	[Changelog] - New field `SkipToken` in struct `WatchlistItemsClientListOptions`
info	[Changelog] - New field `Icon` in struct `MetadataProperties`
info	[Changelog] - New field `ThreatAnalysisTechniques` in struct `MetadataProperties`
info	[Changelog] - New field `PreviewImages` in struct `MetadataProperties`
info	[Changelog] - New field `ThreatAnalysisTactics` in struct `MetadataProperties`
info	[Changelog] - New field `ContentSchemaVersion` in struct `MetadataProperties`
info	[Changelog] - New field `CustomVersion` in struct `MetadataProperties`
info	[Changelog] - New field `PreviewImagesDark` in struct `MetadataProperties`
info	[Changelog] - New field `IsProgramming` in struct `IoTDeviceEntityProperties`
info	[Changelog] - New field `DeviceSubType` in struct `IoTDeviceEntityProperties`
info	[Changelog] - New field `IsAuthorized` in struct `IoTDeviceEntityProperties`
info	[Changelog] - New field `Site` in struct `IoTDeviceEntityProperties`
info	[Changelog] - New field `PurdueLayer` in struct `IoTDeviceEntityProperties`
info	[Changelog] - New field `NicEntityIDs` in struct `IoTDeviceEntityProperties`
info	[Changelog] - New field `IsScanner` in struct `IoTDeviceEntityProperties`
info	[Changelog] - New field `Importance` in struct `IoTDeviceEntityProperties`
info	[Changelog] - New field `Zone` in struct `IoTDeviceEntityProperties`
info	[Changelog] - New field `Sensor` in struct `IoTDeviceEntityProperties`
info	[Changelog] - New field `SkipToken` in struct `WatchlistsClientListOptions`
info	[Changelog] - New anonymous field `WatchlistsClientDeleteResult` in struct `WatchlistsClientDeleteResponse`
info	[Changelog]
info	[Changelog] Total 36 breaking change(s), 99 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from 9499fb9d2e4b074b1ef440fa471aaa7676666584. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.0 -> 8.6.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.6.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-securityinsight        [View full logs]         [Preview SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model EntityAnalytics has a new parameter entity_providers
info	[Changelog]   - Model IoTDeviceEntity has a new parameter device_sub_type
info	[Changelog]   - Model IoTDeviceEntity has a new parameter importance
info	[Changelog]   - Model IoTDeviceEntity has a new parameter is_authorized
info	[Changelog]   - Model IoTDeviceEntity has a new parameter is_programming
info	[Changelog]   - Model IoTDeviceEntity has a new parameter is_scanner
info	[Changelog]   - Model IoTDeviceEntity has a new parameter nic_entity_ids
info	[Changelog]   - Model IoTDeviceEntity has a new parameter purdue_layer
info	[Changelog]   - Model IoTDeviceEntity has a new parameter sensor
info	[Changelog]   - Model IoTDeviceEntity has a new parameter site
info	[Changelog]   - Model IoTDeviceEntity has a new parameter zone
info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter device_sub_type
info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter importance
info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter is_authorized
info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter is_programming
info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter is_scanner
info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter nic_entity_ids
info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter purdue_layer
info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter sensor
info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter site
info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter zone
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model EntityAnalytics no longer has parameter is_enabled
    ️⚠️ azure-sdk-for-js warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from 9499fb9d2e4b074b1ef440fa471aaa7676666584. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-securityinsight        [View full logs]         [Preview SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Type Alias DeviceImportance
info	[Changelog]   - Added Type Alias EntityProviders
info	[Changelog]   - Added Type Alias NicEntity
info	[Changelog]   - Added Type Alias NicEntityProperties
info	[Changelog]   - Type Alias EntityAnalytics has a new parameter entityProviders
info	[Changelog]   - Type Alias IoTDeviceEntity has a new parameter nicEntityIds
info	[Changelog]   - Type Alias IoTDeviceEntity has a new parameter site
info	[Changelog]   - Type Alias IoTDeviceEntity has a new parameter zone
info	[Changelog]   - Type Alias IoTDeviceEntity has a new parameter sensor
info	[Changelog]   - Type Alias IoTDeviceEntity has a new parameter deviceSubType
info	[Changelog]   - Type Alias IoTDeviceEntity has a new parameter importance
info	[Changelog]   - Type Alias IoTDeviceEntity has a new parameter purdueLayer
info	[Changelog]   - Type Alias IoTDeviceEntity has a new parameter isAuthorized
info	[Changelog]   - Type Alias IoTDeviceEntity has a new parameter isProgramming
info	[Changelog]   - Type Alias IoTDeviceEntity has a new parameter isScanner
info	[Changelog]   - Type Alias IoTDeviceEntityProperties has a new parameter nicEntityIds
info	[Changelog]   - Type Alias IoTDeviceEntityProperties has a new parameter site
info	[Changelog]   - Type Alias IoTDeviceEntityProperties has a new parameter zone
info	[Changelog]   - Type Alias IoTDeviceEntityProperties has a new parameter sensor
info	[Changelog]   - Type Alias IoTDeviceEntityProperties has a new parameter deviceSubType
info	[Changelog]   - Type Alias IoTDeviceEntityProperties has a new parameter importance
info	[Changelog]   - Type Alias IoTDeviceEntityProperties has a new parameter purdueLayer
info	[Changelog]   - Type Alias IoTDeviceEntityProperties has a new parameter isAuthorized
info	[Changelog]   - Type Alias IoTDeviceEntityProperties has a new parameter isProgramming
info	[Changelog]   - Type Alias IoTDeviceEntityProperties has a new parameter isScanner
info	[Changelog]   - Added Enum KnownDeviceImportance
info	[Changelog]   - Added Enum KnownEntityProviders
info	[Changelog]   - Enum KnownEntityKind has a new value Nic
info	[Changelog]   - Enum KnownEntityType has a new value Nic
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type Alias EntityAnalytics no longer has parameter isEnabled
info	[Changelog]   - Type Alias WatchlistItem no longer has parameter itemsKeyValue
info	[Changelog]   - Type Alias WatchlistItem no longer has parameter entityMapping
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]  
  
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from 9499fb9d2e4b074b1ef440fa471aaa7676666584. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️securityinsights        [View full logs]         [Preview Schema Changes]      
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            
    
    
    
      
    
    
    
    

      

          @openapi-workflow-bot
openapi-workflow-bot
bot



          added
  the 

  WaitForARMFeedback

  <valid label in PR review process> add this label when ARM review is required
 label


      Apr 4, 2022

    
    
  
    





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi, @nmizrahi6 your PR are labelled with  WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            


  
    
  
    
    
  
    

  
    
      
    
    @nmizrahi6
nmizrahi6



    mentioned this pull request
    
      Apr 4, 2022
    

    


    
  


  
    
      
   Closed

  
    

    


  
  
    
      
        
      
      

  
    
    
  


    25 tasks
  
    
    



  
    

    

  
    
  
    
    
  
    

  
    
      
    
  This was referenced Apr 4, 2022

    


    
  


  
    
      
   Draft

  
    

    



      
    

    


    
  


  
    
      
   Draft

  
    

    



  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
  This was referenced Apr 4, 2022

    


    
  


  
    
      
   Draft

  
    

    



      
    

    


    
  


  
    
      
   Draft

  
    

    



  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
    @openapi-sdkautomation
openapi-sdkautomation
bot


    mentioned this pull request
    
      Apr 4, 2022
    

    


    
  


  
    
      
   Draft

  
    

    




  
    

    




    

      
    
  
        



    

      
    
  
            
    
    
    
      
    
    
    
    

      

          @jorgecotillo
jorgecotillo




            added
      

  ARMSignedOff

  <valid label in PR review process>add this label when ARM approve updates after review

    and removed
      

  WaitForARMFeedback

  <valid label in PR review process> add this label when ARM review is required

  labels


      Apr 5, 2022

    
    
  
    





    

      
    
  
        
    
  
    
      
    
  jorgecotillo
  
    
  
              
    
            
                  jorgecotillo
  

            

            reviewed


            
                
                  Apr 5, 2022
                
            
            
          
    

          
    


              
    View reviewed changes
  


          
    

    

    

      
    
  
  
  
                
    
    
          
    
        
              ...source-manager/Microsoft.SecurityInsights/preview/2022-05-01-preview/common/EntityTypes.json

        
      
    
    
    
            
  
    
    
      
    
    
    
          
    
            
            
            @@ -1000,6 +1010,87 @@
          
    
          
    

              

              

            
                        "readOnly": true,

            
          
    
          
    

              

              

            
                        "type": "array",

            
          
    
          
    

              

              

            
                        "x-ms-identifiers": []

            
          
    
          
    

              

              

            
                      },

            
          
    
          
    

              

              

            
                      "nicEntityIds": {

            
          
    
    
    


    



    
  
    
    
    
        
    
        
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
    Contributor


      

  
    

  
    
    

  
    

    

        
    
      
    
  
    
  
 
    
  
    

    
    Choose a reason for hiding this comment
    

    
    
      The reason will be displayed to describe this comment to others. Learn more.
    
    

    
    
      
      

    

  

    

  
    
    
      
    Without context, I don't know what format these Ids have, are these Azure resource ids? If yes, how are you handling RBAC?
    
    
    
      
  


    
    
    

        
    
      
  
    
    
  
    
    

  
    
  
    


    
        
    
      
    
    


    




    
    

  
    


    


    

    





    

      
    

    



    

      
    
  
      

    

  
    
  @ghost


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    
    
      

      
            ghost
  

      

      

      commented


        Apr 24, 2022


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi, @nmizrahi6. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR.  If you want to refresh the PR, please remove no-recent-activity label.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            





    

      
    
  
      

    

  
    
  @nmizrahi6


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
    Contributor


      

  Author


  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Postponing change to 2022-07-01-preview version
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            
    
    
    
      
    
    
    
    

      

          @nmizrahi6
nmizrahi6




            closed this


      Apr 26, 2022

    
    
  
    

    
    




    





  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
        

    


      
    
  
    
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
      @jorgecotillo
  
    jorgecotillo



          
            
              
            
          
          jorgecotillo left review comments

        
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

    No one assigned




    


      

    
  


  
    
    Labels
  
    


    
    
      

    ARMSignedOff

  <valid label in PR review process>add this label when ARM approve updates after review
  

    CI-BreakingChange-Go-V2

  

    CI-BreakingChange-JavaScript



    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

        
          

    

  
      
    
  
    
    
    
      2 participants
    
    
    
    
        
          @nmizrahi6 
        
          @jorgecotillo