Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Correcting sourceType field for 2022-01-01-preview API version for Watchlist #18585

Closed
wants to merge 1 commit into from

Conversation

ushasan
Copy link
Contributor

@ushasan ushasan commented Apr 6, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ushasan Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 6, 2022

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    Watchlists.json 2022-01-01-preview(0d5acea) 2022-01-01-preview(main)
    Rule Message
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Local file, Remote storage' from the old version.
    New: Microsoft.SecurityInsights/preview/2022-01-01-preview/Watchlists.json#L501:9
    Old: Microsoft.SecurityInsights/preview/2022-01-01-preview/Watchlists.json#L501:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-preview-2022-01 package-preview-2022-01(0d5acea) package-preview-2022-01(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'watchlistItems' with immediate parent 'Watchlist', must have a list by immediate parent operation.
    Location: Microsoft.SecurityInsights/preview/2022-01-01-preview/Watchlists.json#L625
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDeleted
    Location: Microsoft.SecurityInsights/preview/2022-01-01-preview/Watchlists.json#L545
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDeleted
    Location: Microsoft.SecurityInsights/preview/2022-01-01-preview/Watchlists.json#L656
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 3 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/0d5acea18090f2e394e31684249ce70b8d448768/specification/securityinsights/resource-manager/readme.md#tag-package-preview-2022-01">securityinsights/resource-manager/readme.md#package-preview-2022-01
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ Modeler/MissingType "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-preview-2022-01",
    "details":"The schema 'components·1qaufw0·schemas·threatintelligenceindicatorproperties·properties·extensions·additionalproperties' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-01-01-preview/ThreatIntelligence.json#/components/schemas/components·1qaufw0·schemas·threatintelligenceindicatorproperties·properties·extensions·additionalproperties"
    ⚠️ Modeler/MissingType "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-preview-2022-01",
    "details":"The schema 'components·2sbdb2·schemas·watchlistitemproperties·properties·itemskeyvalue·additionalproperties' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-01-01-preview/Watchlists.json#/components/schemas/components·2sbdb2·schemas·watchlistitemproperties·properties·itemskeyvalue·additionalproperties"
    ⚠️ Modeler/MissingType "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-preview-2022-01",
    "details":"The schema 'components·84fvid·schemas·watchlistitemproperties·properties·entitymapping·additionalproperties' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-01-01-preview/Watchlists.json#/components/schemas/components·84fvid·schemas·watchlistitemproperties·properties·entitymapping·additionalproperties"


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-preview-2022-01",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 6, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armsecurityinsights - 0.2.0
    +	Const `IncidentLabelTypeSystem` has been removed
    +	Const `SourceLocalFile` has been removed
    +	Const `SourceRemoteStorage` has been removed
    +	Field `IsEnabled` of struct `EntityAnalyticsProperties` has been removed
    +	Field `WatchlistItemsCount` of struct `WatchlistProperties` has been removed
    +	Function `*AutomationRulesClient.ManualTriggerPlaybook` has been removed
    +	Function `*QueryBasedAlertRuleProperties.UnmarshalJSON` has been removed
    +	Function `*ThreatIntelligenceIndicatorClient.CreateIndicator` parameter(s) have been changed from `(context.Context, string, string, ThreatIntelligenceIndicatorModelForRequestBody, *ThreatIntelligenceIndicatorClientCreateIndicatorOptions)` to `(context.Context, string, string, ThreatIntelligenceIndicatorModel, *ThreatIntelligenceIndicatorClientCreateIndicatorOptions)`
    +	Function `*ThreatIntelligenceIndicatorClient.Create` parameter(s) have been changed from `(context.Context, string, string, string, ThreatIntelligenceIndicatorModelForRequestBody, *ThreatIntelligenceIndicatorClientCreateOptions)` to `(context.Context, string, string, string, ThreatIntelligenceIndicatorModel, *ThreatIntelligenceIndicatorClientCreateOptions)`
    +	Function `*ThreatIntelligenceIndicatorClient.ReplaceTags` parameter(s) have been changed from `(context.Context, string, string, string, ThreatIntelligenceIndicatorModelForRequestBody, *ThreatIntelligenceIndicatorClientReplaceTagsOptions)` to `(context.Context, string, string, string, ThreatIntelligenceIndicatorModel, *ThreatIntelligenceIndicatorClientReplaceTagsOptions)`
    +	Function `*ThreatIntelligenceIndicatorModel.GetThreatIntelligenceResourceKind` has been removed
    +	Function `*ThreatIntelligenceIndicatorModelForRequestBody.GetThreatIntelligenceResourceKind` has been removed
    +	Function `*ThreatIntelligenceIndicatorModelForRequestBody.UnmarshalJSON` has been removed
    +	Function `*ThreatIntelligenceInformation.GetThreatIntelligenceResourceKind` has been removed
    +	Function `*ThreatIntelligenceInformation.UnmarshalJSON` has been removed
    +	Function `*ThreatIntelligenceResourceKind.GetThreatIntelligenceResourceKind` has been removed
    +	Function `PossibleSourceValues` has been removed
    +	Function `QueryBasedAlertRuleProperties.MarshalJSON` has been removed
    +	Function `Source.ToPtr` has been removed
    +	Function `ThreatIntelligenceIndicatorModelForRequestBody.MarshalJSON` has been removed
    +	Function `ThreatIntelligenceInformation.MarshalJSON` has been removed
    +	Struct `AutomationRulesClientManualTriggerPlaybookOptions` has been removed
    +	Struct `AutomationRulesClientManualTriggerPlaybookResponse` has been removed
    +	Struct `AutomationRulesClientManualTriggerPlaybookResult` has been removed
    +	Struct `QueryBasedAlertRuleProperties` has been removed
    +	Struct `ThreatIntelligenceIndicatorModelForRequestBody` has been removed
    +	Struct `ThreatIntelligenceResourceKind` has been removed
    +	Type of `WatchlistItemProperties.EntityMapping` has been changed from `interface{}` to `map[string]interface{}`
    +	Type of `WatchlistItemProperties.ItemsKeyValue` has been changed from `interface{}` to `map[string]interface{}`
    +	Type of `WatchlistProperties.Source` has been changed from `*Source` to `*string`
    azure-sdk-for-python-track2 - track2_azure-mgmt-securityinsight - 1.0.0
    +	Parameter alerts of model AlertsDataTypeOfDataConnector is now required
    +	Parameter alerts of model MCASDataConnectorDataTypes is now required
    +	Parameter exchange of model OfficeDataConnectorDataTypes is now required
    +	Parameter indicators of model TIDataConnectorDataTypes is now required
    +	Parameter logs of model AwsCloudTrailDataConnectorDataTypes is now required
    +	Parameter share_point of model OfficeDataConnectorDataTypes is now required
    +	Parameter state of model AwsCloudTrailDataConnectorDataTypesLogs is now required
    +	Parameter state of model DataConnectorDataTypeCommon is now required
    +	Parameter state of model OfficeDataConnectorDataTypesExchange is now required
    +	Parameter state of model OfficeDataConnectorDataTypesSharePoint is now required
    +	Parameter state of model OfficeDataConnectorDataTypesTeams is now required
    +	Parameter state of model TIDataConnectorDataTypesIndicators is now required
    +	Parameter teams of model OfficeDataConnectorDataTypes is now required
    +	Parameter tenant_id of model DataConnectorTenantId is now required
    azure-sdk-for-js - @azure/arm-securityinsight - 1.0.0-beta.5
    +	Parameter logicAppsResourceId of interface ManualTriggerRequestBody is now required
    azure-sdk-for-go - securityinsight/mgmt/2020-01-01/securityinsight - v63.1.0
    +	Const `CaseSeverityCritical` has been removed
    +	Const `CaseSeverityHigh` has been removed
    +	Const `CaseSeverityInformational` has been removed
    +	Const `CaseSeverityLow` has been removed
    +	Const `CaseSeverityMedium` has been removed
    +	Const `KindBasicSettingsKindSettings` has been removed
    +	Const `KindBasicSettingsKindToggleSettings` has been removed
    +	Const `KindBasicSettingsKindUebaSettings` has been removed
    +	Const `LicenseStatusDisabled` has been removed
    +	Const `LicenseStatusEnabled` has been removed
    +	Const `SettingKindToggleSettings` has been removed
    +	Const `SettingKindUebaSettings` has been removed
    +	Const `StatusInMcasDisabled` has been removed
    +	Const `StatusInMcasEnabled` has been removed
    +	Function `*ToggleSettings.UnmarshalJSON` has been removed
    +	Function `*UebaSettings.UnmarshalJSON` has been removed
    +	Function `PossibleCaseSeverityValues` has been removed
    +	Function `PossibleKindBasicSettingsValues` has been removed
    +	Function `PossibleLicenseStatusValues` has been removed
    +	Function `PossibleSettingKindValues` has been removed
    +	Function `PossibleStatusInMcasValues` has been removed
    +	Function `Settings.AsBasicSettings` has been removed
    +	Function `Settings.AsSettings` has been removed
    +	Function `Settings.AsToggleSettings` has been removed
    +	Function `Settings.AsUebaSettings` has been removed
    +	Function `Settings.MarshalJSON` has been removed
    +	Function `ToggleSettings.AsBasicSettings` has been removed
    +	Function `ToggleSettings.AsSettings` has been removed
    +	Function `ToggleSettings.AsToggleSettings` has been removed
    +	Function `ToggleSettings.AsUebaSettings` has been removed
    +	Function `ToggleSettings.MarshalJSON` has been removed
    +	Function `UebaSettings.AsBasicSettings` has been removed
    +	Function `UebaSettings.AsSettings` has been removed
    +	Function `UebaSettings.AsToggleSettings` has been removed
    +	Function `UebaSettings.AsUebaSettings` has been removed
    +	Function `UebaSettings.MarshalJSON` has been removed
    +	Function `UebaSettingsProperties.MarshalJSON` has been removed
    +	Struct `Settings` has been removed
    +	Struct `ToggleSettingsProperties` has been removed
    +	Struct `ToggleSettings` has been removed
    +	Struct `UebaSettingsProperties` has been removed
    +	Struct `UebaSettings` has been removed
    +	Type of `IncidentInfo.Severity` has been changed from `CaseSeverity` to `IncidentSeverity`
    azure-sdk-for-go - preview/securityinsight/mgmt/2022-01-01-preview/securityinsight - v63.1.0
    +	Const `SourceTypeLocalfile` has been removed
    +	Const `SourceTypeRemotestorage` has been removed
    +	Type of `WatchlistItemProperties.EntityMapping` has been changed from `interface{}` to `map[string]interface{}`
    +	Type of `WatchlistItemProperties.ItemsKeyValue` has been changed from `interface{}` to `map[string]interface{}`
    azure-sdk-for-go - preview/securityinsight/mgmt/2021-09-01-preview/securityinsight - v63.1.0
    +	Function `ErrorAdditionalInfo.MarshalJSON` has been removed
    +	Function `ErrorDetail.MarshalJSON` has been removed
    +	Struct `ErrorAdditionalInfo` has been removed
    +	Struct `ErrorDetail` has been removed
    +	Struct `ErrorResponse` has been removed
    azure-sdk-for-go - preview/securityinsight/mgmt/2019-01-01-preview/securityinsight - v63.1.0
    +	Const `KindAggregations` has been removed
    +	Const `KindBasicEntityKindAccount` has been removed
    +	Const `KindBasicEntityKindAzureResource` has been removed
    +	Const `KindBasicEntityKindBookmark` has been removed
    +	Const `KindBasicEntityKindCloudApplication` has been removed
    +	Const `KindBasicEntityKindDNSResolution` has been removed
    +	Const `KindBasicEntityKindEntity` has been removed
    +	Const `KindBasicEntityKindFileHash` has been removed
    +	Const `KindBasicEntityKindFile` has been removed
    +	Const `KindBasicEntityKindHost` has been removed
    +	Const `KindBasicEntityKindIP` has been removed
    +	Const `KindBasicEntityKindIoTDevice` has been removed
    +	Const `KindBasicEntityKindMailCluster` has been removed
    +	Const `KindBasicEntityKindMailMessage` has been removed
    +	Const `KindBasicEntityKindMailbox` has been removed
    +	Const `KindBasicEntityKindMalware` has been removed
    +	Const `KindBasicEntityKindProcess` has been removed
    +	Const `KindBasicEntityKindRegistryKey` has been removed
    +	Const `KindBasicEntityKindRegistryValue` has been removed
    +	Const `KindBasicEntityKindSecurityAlert` has been removed
    +	Const `KindBasicEntityKindSecurityGroup` has been removed
    +	Const `KindBasicEntityKindSubmissionMail` has been removed
    +	Const `KindBasicEntityKindURL` has been removed
    +	Const `KindCasesAggregation` has been removed
    +	Function `PossibleKindBasicEntityValues` has been removed
    +	Function `ThreatIntelligenceIndicatorsClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
    +	Function `ThreatIntelligenceIndicatorsClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
    +	Function `ThreatIntelligenceIndicatorsClient.List` parameter(s) have been changed from `(context.Context, string, string, string, string, *int32, string, string)` to `(context.Context, string, string, string, string, string, *int32, string)`
    +	Type of `AccountEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `Aggregations.Kind` has been changed from `Kind` to `KindBasicAggregations`
    +	Type of `AzureResourceEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `CasesAggregation.Kind` has been changed from `Kind` to `KindBasicAggregations`
    +	Type of `CloudApplicationEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `DNSEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `Entity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `FileEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `FileHashEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `HostEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `HuntingBookmark.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `IPEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `IncidentInfo.Severity` has been changed from `CaseSeverity` to `IncidentSeverity`
    +	Type of `IoTDeviceEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `MailClusterEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `MailMessageEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `MailboxEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `MalwareEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `ProcessEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `RegistryKeyEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `RegistryValueEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `SecurityAlert.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `SecurityGroupEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `SubmissionMailEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    +	Type of `URLEntity.Kind` has been changed from `KindBasicEntity` to `Kind`
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs] Generate from 8af2539e9b9cceb1f0e0831af63a365d5fcfe9ed. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 8af2539e9b9cceb1f0e0831af63a365d5fcfe9ed. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation DataConnectorsOperations.connect
      info	[Changelog]   - Added operation DataConnectorsOperations.disconnect
      info	[Changelog]   - Added operation IncidentsOperations.create_team
      info	[Changelog]   - Added operation IncidentsOperations.run_playbook
      info	[Changelog]   - Added operation group BookmarkOperations
      info	[Changelog]   - Added operation group BookmarkRelationsOperations
      info	[Changelog]   - Added operation group DataConnectorsCheckRequirementsOperations
      info	[Changelog]   - Added operation group DomainWhoisOperations
      info	[Changelog]   - Added operation group EntitiesGetTimelineOperations
      info	[Changelog]   - Added operation group EntitiesOperations
      info	[Changelog]   - Added operation group EntitiesRelationsOperations
      info	[Changelog]   - Added operation group EntityQueriesOperations
      info	[Changelog]   - Added operation group EntityQueryTemplatesOperations
      info	[Changelog]   - Added operation group EntityRelationsOperations
      info	[Changelog]   - Added operation group IPGeodataOperations
      info	[Changelog]   - Added operation group MetadataOperations
      info	[Changelog]   - Added operation group OfficeConsentsOperations
      info	[Changelog]   - Added operation group ProductSettingsOperations
      info	[Changelog]   - Added operation group SecurityMLAnalyticsSettingsOperations
      info	[Changelog]   - Added operation group SourceControlOperations
      info	[Changelog]   - Added operation group SourceControlsOperations
      info	[Changelog]   - Model Bookmark has a new parameter entity_mappings
      info	[Changelog]   - Model Bookmark has a new parameter tactics
      info	[Changelog]   - Model Bookmark has a new parameter techniques
      info	[Changelog]   - Model FusionAlertRule has a new parameter scenario_exclusion_patterns
      info	[Changelog]   - Model FusionAlertRule has a new parameter source_settings
      info	[Changelog]   - Model FusionAlertRule has a new parameter techniques
      info	[Changelog]   - Model FusionAlertRuleTemplate has a new parameter source_settings
      info	[Changelog]   - Model FusionAlertRuleTemplate has a new parameter techniques
      info	[Changelog]   - Model Incident has a new parameter provider_incident_id
      info	[Changelog]   - Model Incident has a new parameter provider_name
      info	[Changelog]   - Model Incident has a new parameter team_information
      info	[Changelog]   - Model IncidentAdditionalData has a new parameter provider_incident_url
      info	[Changelog]   - Model IncidentAdditionalData has a new parameter techniques
      info	[Changelog]   - Model IncidentOwnerInfo has a new parameter owner_type
      info	[Changelog]   - Model IoTDeviceEntity has a new parameter device_sub_type
      info	[Changelog]   - Model IoTDeviceEntity has a new parameter importance
      info	[Changelog]   - Model IoTDeviceEntity has a new parameter is_authorized
      info	[Changelog]   - Model IoTDeviceEntity has a new parameter is_programming
      info	[Changelog]   - Model IoTDeviceEntity has a new parameter is_scanner
      info	[Changelog]   - Model IoTDeviceEntity has a new parameter nic_entity_ids
      info	[Changelog]   - Model IoTDeviceEntity has a new parameter owners
      info	[Changelog]   - Model IoTDeviceEntity has a new parameter purdue_layer
      info	[Changelog]   - Model IoTDeviceEntity has a new parameter sensor
      info	[Changelog]   - Model IoTDeviceEntity has a new parameter site
      info	[Changelog]   - Model IoTDeviceEntity has a new parameter zone
      info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter device_sub_type
      info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter importance
      info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter is_authorized
      info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter is_programming
      info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter is_scanner
      info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter nic_entity_ids
      info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter owners
      info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter purdue_layer
      info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter sensor
      info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter site
      info	[Changelog]   - Model IoTDeviceEntityProperties has a new parameter zone
      info	[Changelog]   - Model ScheduledAlertRule has a new parameter techniques
      info	[Changelog]   - Model ScheduledAlertRuleProperties has a new parameter techniques
      info	[Changelog]   - Model ScheduledAlertRuleTemplate has a new parameter techniques
      info	[Changelog]   - Model Watchlist has a new parameter source_type
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter alerts of model AlertsDataTypeOfDataConnector is now required
      info	[Changelog]   - Parameter alerts of model MCASDataConnectorDataTypes is now required
      info	[Changelog]   - Parameter exchange of model OfficeDataConnectorDataTypes is now required
      info	[Changelog]   - Parameter indicators of model TIDataConnectorDataTypes is now required
      info	[Changelog]   - Parameter logs of model AwsCloudTrailDataConnectorDataTypes is now required
      info	[Changelog]   - Parameter share_point of model OfficeDataConnectorDataTypes is now required
      info	[Changelog]   - Parameter state of model AwsCloudTrailDataConnectorDataTypesLogs is now required
      info	[Changelog]   - Parameter state of model DataConnectorDataTypeCommon is now required
      info	[Changelog]   - Parameter state of model OfficeDataConnectorDataTypesExchange is now required
      info	[Changelog]   - Parameter state of model OfficeDataConnectorDataTypesSharePoint is now required
      info	[Changelog]   - Parameter state of model OfficeDataConnectorDataTypesTeams is now required
      info	[Changelog]   - Parameter state of model TIDataConnectorDataTypesIndicators is now required
      info	[Changelog]   - Parameter teams of model OfficeDataConnectorDataTypes is now required
      info	[Changelog]   - Parameter tenant_id of model DataConnectorTenantId is now required
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 8af2539e9b9cceb1f0e0831af63a365d5fcfe9ed. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias IpEntity
      info	[Changelog]   - Added Type Alias IpEntityProperties
      info	[Changelog]   - Added Type Alias MailboxEntity
      info	[Changelog]   - Added Type Alias MailboxEntityProperties
      info	[Changelog]   - Added Type Alias MailClusterEntity
      info	[Changelog]   - Added Type Alias MailClusterEntityProperties
      info	[Changelog]   - Added Type Alias MailMessageEntity
      info	[Changelog]   - Added Type Alias MailMessageEntityProperties
      info	[Changelog]   - Added Type Alias MalwareEntity
      info	[Changelog]   - Added Type Alias MalwareEntityProperties
      info	[Changelog]   - Added Type Alias McasCheckRequirements
      info	[Changelog]   - Added Type Alias McasCheckRequirementsProperties
      info	[Changelog]   - Added Type Alias McasDataConnector
      info	[Changelog]   - Added Type Alias McasDataConnectorDataTypes
      info	[Changelog]   - Added Type Alias McasDataConnectorProperties
      info	[Changelog]   - Added Type Alias MdatpCheckRequirements
      info	[Changelog]   - Added Type Alias MdatpCheckRequirementsProperties
      info	[Changelog]   - Added Type Alias MdatpDataConnector
      info	[Changelog]   - Added Type Alias MdatpDataConnectorProperties
      info	[Changelog]   - Added Type Alias MetadataModel
      info	[Changelog]   - Added Type Alias MetadataPatch
      info	[Changelog]   - Added Type Alias MicrosoftSecurityIncidentCreationAlertRule
      info	[Changelog]   - Added Type Alias MicrosoftSecurityIncidentCreationAlertRuleProperties
      info	[Changelog]   - Added Type Alias MicrosoftSecurityIncidentCreationAlertRuleTemplate
      info	[Changelog]   - Added Type Alias MicrosoftSecurityIncidentCreationAlertRuleTemplateProperties
      info	[Changelog]   - Added Type Alias MLBehaviorAnalyticsAlertRule
      info	[Changelog]   - Added Type Alias MLBehaviorAnalyticsAlertRuleTemplate
      info	[Changelog]   - Added Type Alias MLBehaviorAnalyticsAlertRuleTemplateProperties
      info	[Changelog]   - Added Type Alias MstiCheckRequirements
      info	[Changelog]   - Added Type Alias MstiCheckRequirementsProperties
      info	[Changelog]   - Added Type Alias MstiDataConnector
      info	[Changelog]   - Added Type Alias MstiDataConnectorDataTypesBingSafetyPhishingURL
      info	[Changelog]   - Added Type Alias MstiDataConnectorDataTypesMicrosoftEmergingThreatFeed
      info	[Changelog]   - Added Type Alias MstiDataConnectorProperties
      info	[Changelog]   - Added Type Alias MtpCheckRequirements
      info	[Changelog]   - Added Type Alias MTPCheckRequirementsProperties
      info	[Changelog]   - Added Type Alias MTPDataConnector
      info	[Changelog]   - Added Type Alias MTPDataConnectorDataTypesIncidents
      info	[Changelog]   - Added Type Alias MTPDataConnectorProperties
      info	[Changelog]   - Added Type Alias NicEntity
      info	[Changelog]   - Added Type Alias NicEntityProperties
      info	[Changelog]   - Added Type Alias NrtAlertRule
      info	[Changelog]   - Added Type Alias NrtAlertRuleTemplate
      info	[Changelog]   - Added Type Alias NrtAlertRuleTemplateProperties
      info	[Changelog]   - Added Type Alias Office365ProjectCheckRequirements
      info	[Changelog]   - Added Type Alias Office365ProjectCheckRequirementsProperties
      info	[Changelog]   - Added Type Alias Office365ProjectConnectorDataTypesLogs
      info	[Changelog]   - Added Type Alias Office365ProjectDataConnector
      info	[Changelog]   - Added Type Alias Office365ProjectDataConnectorProperties
      info	[Changelog]   - Added Type Alias OfficeATPCheckRequirements
      info	[Changelog]   - Added Type Alias OfficeATPCheckRequirementsProperties
      info	[Changelog]   - Added Type Alias OfficeATPDataConnector
      info	[Changelog]   - Added Type Alias OfficeATPDataConnectorProperties
      info	[Changelog]   - Added Type Alias OfficeConsent
      info	[Changelog]   - Added Type Alias OfficeDataConnector
      info	[Changelog]   - Added Type Alias OfficeDataConnectorDataTypesExchange
      info	[Changelog]   - Added Type Alias OfficeDataConnectorDataTypesSharePoint
      info	[Changelog]   - Added Type Alias OfficeDataConnectorDataTypesTeams
      info	[Changelog]   - Added Type Alias OfficeDataConnectorProperties
      info	[Changelog]   - Added Type Alias OfficeIRMCheckRequirements
      info	[Changelog]   - Added Type Alias OfficeIRMCheckRequirementsProperties
      info	[Changelog]   - Added Type Alias OfficeIRMDataConnector
      info	[Changelog]   - Added Type Alias OfficeIRMDataConnectorProperties
      info	[Changelog]   - Added Type Alias OfficePowerBICheckRequirements
      info	[Changelog]   - Added Type Alias OfficePowerBICheckRequirementsProperties
      info	[Changelog]   - Added Type Alias OfficePowerBIConnectorDataTypesLogs
      info	[Changelog]   - Added Type Alias OfficePowerBIDataConnector
      info	[Changelog]   - Added Type Alias OfficePowerBIDataConnectorProperties
      info	[Changelog]   - Added Type Alias PermissionsCustomsItem
      info	[Changelog]   - Added Type Alias PermissionsResourceProviderItem
      info	[Changelog]   - Added Type Alias ProcessEntity
      info	[Changelog]   - Added Type Alias ProcessEntityProperties
      info	[Changelog]   - Added Type Alias PropertyArrayChangedConditionProperties
      info	[Changelog]   - Added Type Alias PropertyChangedConditionProperties
      info	[Changelog]   - Added Type Alias PropertyConditionProperties
      info	[Changelog]   - Added Type Alias RegistryKeyEntity
      info	[Changelog]   - Added Type Alias RegistryKeyEntityProperties
      info	[Changelog]   - Added Type Alias RegistryValueEntity
      info	[Changelog]   - Added Type Alias RegistryValueEntityProperties
      info	[Changelog]   - Added Type Alias Relation
      info	[Changelog]   - Added Type Alias ResourceWithEtag
      info	[Changelog]   - Added Type Alias ScheduledAlertRule
      info	[Changelog]   - Added Type Alias ScheduledAlertRuleProperties
      info	[Changelog]   - Added Type Alias ScheduledAlertRuleTemplate
      info	[Changelog]   - Added Type Alias SecurityAlert
      info	[Changelog]   - Added Type Alias SecurityAlertProperties
      info	[Changelog]   - Added Type Alias SecurityAlertTimelineItem
      info	[Changelog]   - Added Type Alias SecurityGroupEntity
      info	[Changelog]   - Added Type Alias SecurityGroupEntityProperties
      info	[Changelog]   - Added Type Alias SecurityMLAnalyticsSetting
      info	[Changelog]   - Added Type Alias SentinelOnboardingState
      info	[Changelog]   - Added Type Alias Settings
      info	[Changelog]   - Added Type Alias SourceControl
      info	[Changelog]   - Added Type Alias SubmissionMailEntity
      info	[Changelog]   - Added Type Alias SubmissionMailEntityProperties
      info	[Changelog]   - Added Type Alias ThreatIntelligenceAlertRule
      info	[Changelog]   - Added Type Alias ThreatIntelligenceAlertRuleTemplate
      info	[Changelog]   - Added Type Alias ThreatIntelligenceAlertRuleTemplateProperties
      info	[Changelog]   - Added Type Alias ThreatIntelligenceIndicatorModel
      info	[Changelog]   - Added Type Alias ThreatIntelligenceIndicatorProperties
      info	[Changelog]   - Added Type Alias ThreatIntelligenceInformation
      info	[Changelog]   - Added Type Alias TICheckRequirements
      info	[Changelog]   - Added Type Alias TICheckRequirementsProperties
      info	[Changelog]   - Added Type Alias TIDataConnector
      info	[Changelog]   - Added Type Alias TIDataConnectorDataTypesIndicators
      info	[Changelog]   - Added Type Alias TIDataConnectorProperties
      info	[Changelog]   - Added Type Alias TiTaxiiCheckRequirements
      info	[Changelog]   - Added Type Alias TiTaxiiCheckRequirementsProperties
      info	[Changelog]   - Added Type Alias TiTaxiiDataConnector
      info	[Changelog]   - Added Type Alias TiTaxiiDataConnectorDataTypesTaxiiClient
      info	[Changelog]   - Added Type Alias TiTaxiiDataConnectorProperties
      info	[Changelog]   - Added Type Alias Ueba
      info	[Changelog]   - Added Type Alias UrlEntity
      info	[Changelog]   - Added Type Alias UrlEntityProperties
      info	[Changelog]   - Added Type Alias Watchlist
      info	[Changelog]   - Added Type Alias WatchlistItem
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Parameter logicAppsResourceId of interface ManualTriggerRequestBody is now required
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 8af2539e9b9cceb1f0e0831af63a365d5fcfe9ed. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️securityinsights [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from 8af2539e9b9cceb1f0e0831af63a365d5fcfe9ed. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.securityinsights [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @ushasan, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @ghost
    Copy link

    ghost commented Apr 24, 2022

    Hi, @ushasan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost
    Copy link

    ghost commented May 15, 2022

    Hi, @ushasan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @dw511214992
    Copy link
    Member

    Hi @ushasan This PR has not passed breaking change review for long time. If you want to merge this PR, please following the action in the bottom of PR description to ask breaking change review. thanks

    @dw511214992
    Copy link
    Member

    /azp run

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 28, 2022

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ghost
    Copy link

    ghost commented Aug 14, 2022

    Hi, @ushasan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost
    Copy link

    ghost commented Sep 4, 2022

    Hi, @ushasan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost
    Copy link

    ghost commented Sep 25, 2022

    Hi, @ushasan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost
    Copy link

    ghost commented Oct 16, 2022

    Hi, @ushasan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Oct 16, 2022
    @ghost ghost closed this Oct 31, 2022
    @ghost
    Copy link

    ghost commented Oct 31, 2022

    Hi, @ushasan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    This pull request was closed.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants