Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2022-09-01 #23054

Merged
merged 5 commits into from
Mar 22, 2023
Merged

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2022-09-01 #23054

merged 5 commits into from
Mar 22, 2023

Conversation

AntonioHernandez16
Copy link
Contributor

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @AntonioHernandez16 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 13, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 48 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    consumption.json 2022-09-01(403c1ec) 2021-10-01(main)
    consumption.json 2022-09-01(403c1ec) 2019-05-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.Consumption/usageDetails/download' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L154:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/providers/Microsoft.Consumption/balances' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L620:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Consumption/reservationRecommendations' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L876:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Consumption/forecasts' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1058:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedcost' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1194:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Filters' removed or renamed?
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1855:3
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1237:3
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Charges_ListByScope' to 'Charges_List'. This will impact generated code.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L486:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L533:7
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L155:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L252:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L473:11
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L577:13
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L568:13
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'Usage' from the old version.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L4191:9
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2238:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L131:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L119:11
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L221:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L275:11
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1325:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L958:11
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1391:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1023:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L577:13
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L568:13
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1942:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1313:11
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1908:5
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1290:5
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L3430:5
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2071:5
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L3414:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2097:11
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L4708:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2724:11
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L4714:5
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2730:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L577:13
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L568:13
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L4708:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2724:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L4714:5
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2730:5
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1917:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1298:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'filters' renamed or removed?
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L4190:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2237:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L4703:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2738:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'id' renamed or removed?
    New: Microsoft.Consumption/stable/2022-09-01/consumption.json#L4703:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L2738:7
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️❌LintDiff: 1 Errors, 0 Warnings failed [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-09 package-2022-09(403c1ec) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2923


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L155
    ❌ GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L252
    ❌ ResourceNameRestriction The resource name parameter 'budgetName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L309
    ❌ DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L430
    ❌ GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L473
    ❌ ResourceNameRestriction The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L629
    ❌ GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1113
    ❌ TrackedResourcePatchOperation Tracked resource 'ReservationRecommendationDetailsModel' must have patch operation that at least supports the update of tags.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1128
    ❌ TrackedResourcesMustHavePut The tracked resource ReservationRecommendationDetailsModel does not have a corresponding put operation.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1128
    ❌ GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1182
    ❌ ResourceNameRestriction The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1358
    ❌ OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1447
    ❌ ResourceNameRestriction The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1512
    ❌ GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1842
    ❌ MissingTypeObject The schema 'MeterDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1856
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1887
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1893
    ❌ MissingTypeObject The schema 'UsageDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1935
    ❌ MissingTypeObject The schema 'LegacyUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L1973
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2058
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2064
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2070
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2076
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2197
    ❌ MissingTypeObject The schema 'ModernUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2246
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2257
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2356
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2372
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2378
    ❌ ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2022-09-01/consumption.json#L2484
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'Operations' could not be found in the namespace 'Microsoft.Consumption' for api version '2022-09-01'. The supported api-versions are '2017-06-30-preview,
    2017-11-30,
    2018-01-31,
    2018-03-31,
    2018-05-31,
    2018-06-30,
    2018-08-01-preview,
    2018-08-31,
    2018-10-01,
    2019-01-01,
    2018-11-01-preview,
    2019-05-01,
    2019-10-01,
    2021-10-01,
    2022-06-01'."
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 13, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/consumption/armconsumption - 2.0.0
    +	Field `Etag` of struct `CreditSummary` has been removed
+	Field `MarketplaceCharges` of struct `LegacyChargeSummaryProperties` has been removed
+	Field `Tags` of struct `CreditSummary` has been removed
+	Type of `ModernReservationRecommendation.Properties` has been changed from `*ModernReservationRecommendationProperties` to `ModernReservationRecommendationPropertiesClassification`
    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-consumption - 11.0.0b1
    +	Model CreditSummary no longer has parameter etag
+	Model CreditSummary no longer has parameter tags
+	Model LegacyChargeSummary no longer has parameter marketplace_charges
+	Parameter scope of model ModernReservationRecommendation is now required
    ❌azure-sdk-for-js - @azure/arm-consumption - 10.0.0
    +	Interface BudgetFilter no longer has parameter not
+	Interface LegacyChargeSummary no longer has parameter marketplaceCharges
+	Operation ReservationRecommendationDetails.get has a new signature
+	Parameter scope of interface ModernReservationRecommendation is now required
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cd2b76c. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/consumption/armconsumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ModernReservationRecommendation.Properties` has been changed from `*ModernReservationRecommendationProperties` to `ModernReservationRecommendationPropertiesClassification`
info	[Changelog] - Field `Etag` of struct `CreditSummary` has been removed
info	[Changelog] - Field `Tags` of struct `CreditSummary` has been removed
info	[Changelog] - Field `MarketplaceCharges` of struct `LegacyChargeSummaryProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `EventTypeCreditExpired` added to enum type `EventType`
info	[Changelog] - New function `NewClientFactory(string, azcore.TokenCredential, *arm.ClientOptions) (*ClientFactory, error)`
info	[Changelog] - New function `*ClientFactory.NewAggregatedCostClient() *AggregatedCostClient`
info	[Changelog] - New function `*ClientFactory.NewBalancesClient() *BalancesClient`
info	[Changelog] - New function `*ClientFactory.NewBudgetsClient() *BudgetsClient`
info	[Changelog] - New function `*ClientFactory.NewChargesClient() *ChargesClient`
info	[Changelog] - New function `*ClientFactory.NewCreditsClient() *CreditsClient`
info	[Changelog] - New function `*ClientFactory.NewEventsClient() *EventsClient`
info	[Changelog] - New function `*ClientFactory.NewLotsClient() *LotsClient`
info	[Changelog] - New function `*ClientFactory.NewMarketplacesClient() *MarketplacesClient`
info	[Changelog] - New function `*ClientFactory.NewOperationsClient() *OperationsClient`
info	[Changelog] - New function `*ClientFactory.NewPriceSheetClient() *PriceSheetClient`
info	[Changelog] - New function `*ClientFactory.NewReservationRecommendationDetailsClient() *ReservationRecommendationDetailsClient`
info	[Changelog] - New function `*ClientFactory.NewReservationRecommendationsClient() *ReservationRecommendationsClient`
info	[Changelog] - New function `*ClientFactory.NewReservationTransactionsClient() *ReservationTransactionsClient`
info	[Changelog] - New function `*ClientFactory.NewReservationsDetailsClient() *ReservationsDetailsClient`
info	[Changelog] - New function `*ClientFactory.NewReservationsSummariesClient() *ReservationsSummariesClient`
info	[Changelog] - New function `*ClientFactory.NewTagsClient() *TagsClient`
info	[Changelog] - New function `*ClientFactory.NewUsageDetailsClient() *UsageDetailsClient`
info	[Changelog] - New function `*ModernReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
info	[Changelog] - New function `*ModernSharedScopeReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
info	[Changelog] - New function `*ModernSingleScopeReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
info	[Changelog] - New struct `ClientFactory`
info	[Changelog] - New struct `ModernSharedScopeReservationRecommendationProperties`
info	[Changelog] - New struct `ModernSingleScopeReservationRecommendationProperties`
info	[Changelog] - New field `OverageRefund` in struct `BalanceProperties`
info	[Changelog] - New field `ETag` in struct `CreditSummary`
info	[Changelog] - New field `AzureMarketplaceCharges` in struct `LegacyChargeSummaryProperties`
info	[Changelog] - New field `SubscriptionID` in struct `ModernChargeSummaryProperties`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 33 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cd2b76c. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.6.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model Balance has a new parameter overage_refund
info	[Changelog]   - Model CreditSummary has a new parameter e_tag_properties_e_tag
info	[Changelog]   - Model LegacyChargeSummary has a new parameter azure_marketplace_charges
info	[Changelog]   - Model ModernChargeSummary has a new parameter subscription_id
info	[Changelog]   - Model ModernReservationRecommendation has a new parameter resource_type
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model CreditSummary no longer has parameter etag
info	[Changelog]   - Model CreditSummary no longer has parameter tags
info	[Changelog]   - Model LegacyChargeSummary no longer has parameter marketplace_charges
info	[Changelog]   - Parameter scope of model ModernReservationRecommendation is now required
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cd2b76c. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation LotsOperations.listByCustomer
info	[Changelog]   - Added Interface LotsListByCustomerNextOptionalParams
info	[Changelog]   - Added Interface LotsListByCustomerOptionalParams
info	[Changelog]   - Added Interface ModernReservationRecommendationProperties
info	[Changelog]   - Added Interface ModernSharedScopeReservationRecommendationProperties
info	[Changelog]   - Added Interface ModernSingleScopeReservationRecommendationProperties
info	[Changelog]   - Added Type Alias LotsListByCustomerNextResponse
info	[Changelog]   - Added Type Alias LotsListByCustomerResponse
info	[Changelog]   - Added Type Alias ModernReservationRecommendationPropertiesUnion
info	[Changelog]   - Interface Balance has a new optional parameter overageRefund
info	[Changelog]   - Interface CreditSummary has a new optional parameter eTagPropertiesETag
info	[Changelog]   - Interface LegacyChargeSummary has a new optional parameter azureMarketplaceCharges
info	[Changelog]   - Interface LegacyUsageDetail has a new optional parameter benefitId
info	[Changelog]   - Interface LegacyUsageDetail has a new optional parameter benefitName
info	[Changelog]   - Interface ModernChargeSummary has a new optional parameter subscriptionId
info	[Changelog]   - Interface ModernReservationRecommendation has a new optional parameter resourceType
info	[Changelog]   - Enum KnownEventType has a new value CreditExpired
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation ReservationRecommendationDetails.get has a new signature
info	[Changelog]   - Interface BudgetFilter no longer has parameter not
info	[Changelog]   - Interface LegacyChargeSummary no longer has parameter marketplaceCharges
info	[Changelog]   - Parameter scope of interface ModernReservationRecommendation is now required
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cd2b76c. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️consumption [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs]Release - Generate from cd2b76c. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
ENOENT: no such file or directory, stat 'azure-powershell/swaggerci/Consumption/bin/Az.Consumption.0.1.0.nupkg'
Error: ENOENT: no such file or directory, stat 'azure-powershell/swaggerci/Consumption/bin/Az.Consumption.0.1.0.nupkg'
    • ️✔️Az.Consumption [View full logs]  
      error	Fatal error: ENOENT: no such file or directory, stat 'azure-powershell/swaggerci/Consumption/bin/Az.Consumption.0.1.0.nupkg'
error	The following packages are still pending:
error		Az.Consumption
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 13, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/consumption/armconsumption Create ApiView failed. Please ask PR assignee for help
    .Net Azure.ResourceManager.Consumption https://apiview.dev/Assemblies/Review/8e6f3a6caa174248be8e62439b713342
    Java azure-resourcemanager-consumption https://apiview.dev/Assemblies/Review/cc810111844947f48a644cf18db94675
    JavaScript @azure/arm-consumption https://apiview.dev/Assemblies/Review/ccdebf5cedc143e981d6b8519c4d4bc8

    @AntonioHernandez16
    Copy link
    Contributor Author

    Adding correct new API version to swagger documentation. It is only adding one new field in balances response. Only one change made from 2021-10-01 swagger version.

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview CI-FixRequiredOnFailure new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 13, 2023
    @openapi-workflow-bot
    Copy link

    Hi @AntonioHernandez16, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @azure-sdk azure-sdk mentioned this pull request Mar 13, 2023
    Closed
    This was referenced Mar 13, 2023
    Closed
    Closed
    Closed
    This was referenced Mar 13, 2023
    Closed
    Closed
    Closed
    @AntonioHernandez16
    Copy link
    Contributor Author

    Hi @tadelesh , can you provide what's next steps for completing PR?

    @tadelesh
    Copy link
    Member

    @AntonioHernandez16 You should fix LintDiff error and PrettierCheck error first and then wait for ARM review.

    @AntonioHernandez16
    Copy link
    Contributor Author

    @tadelesh For LintDiff it is complaining about 'decimal' format and '204' responses but we are using these two in all our previous swagger versions, is there anyone I can reach for this concern?

    @tadelesh
    Copy link
    Member

    tadelesh commented Mar 16, 2023 •
    edited
    Loading

    @tadelesh For LintDiff it is complaining about 'decimal' format and '204' responses but we are using these two in all our previous swagger versions, is there anyone I can reach for this concern?

    @raych1 Could you help? Is it a new rule?

    @raych1
    Copy link
    Member

    raych1 commented Mar 16, 2023

    @tadelesh For LintDiff it is complaining about 'decimal' format and '204' responses but we are using these two in all our previous swagger versions, is there anyone I can reach for this concern?

    @raych1 Could you help? Is it a new rule?

    @AntonioHernandez16 , it's not a new rule. This error is reported as it's a new property and it would be better to fix it for new API or new property.

    As this is an SDK rule and do you think if it matters during code gen? @tadelesh

    @tadelesh
    Copy link
    Member

    Since there exist similar usage in previous version, I don't think it will influence SDK geneartion.

    @AntonioHernandez16
    Copy link
    Contributor Author

    @tadelesh Just fixed issues with Prettier check, only pending issue is with LintDiff ('decimal' format and '204')

    @tadelesh
    Copy link
    Member

    tadelesh commented Mar 17, 2023 •
    edited
    Loading

    @AntonioHernandez16 Approved for LintDiff error. When will service roll out this new version?

    @AntonioHernandez16
    Copy link
    Contributor Author

    @tadelesh It is coming out end of this month, once LintDiff is approved, what are next steps for completing PR? Thank you so much, Antonio

    @tadelesh
    Copy link
    Member

    Ignore all SDK breaking changes as they are not introduced by this PR.

    @tadelesh
    Copy link
    Member

    @tadelesh It is coming out end of this month, once LintDiff is approved, what are next steps for completing PR? Thank you so much, Antonio

    Next step is wait for ARM sign off.

    @AntonioHernandez16
    Copy link
    Contributor Author

    @tadelesh Do we have an assigned reviewer from ARM or is there someone I can reach out to get PR completed? Thank you so much for approving!

    @tadelesh
    Copy link
    Member

    • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

    You could refer this in the PR description:
    If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

    @raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 20, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 20, 2023
    @AntonioHernandez16
    Copy link
    Contributor Author

    @tadelesh ARM signed off, should I still reach out to ARM oncall for merging the PR?

    @tadelesh
    Copy link
    Member

    SDK breaking changes are not introduced in this PR. Sign off.

    @tadelesh tadelesh merged commit cd2b76c into main Mar 22, 2023
    @tadelesh tadelesh deleted the AntonioHernandez16-consumption-Microsoft.Consumption-2022-09-01 branch March 22, 2023 02:26
    This was referenced Mar 22, 2023
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    nrafalowski added a commit to nrafalowski/azure-rest-api-specs that referenced this pull request Mar 22, 2023
    @nrafalowski
    Squashed commit of the following:
    2e5a0d4 
    commit c94569d116a82ee11a94c5dfb190650dd675a1bf
Author: Marina Bashtovaya <[email protected]>
Date:   Wed Mar 22 02:35:49 2023 -0400

    NetworkCloud 2022-12-12-preview API corrections (#23086)

    * first public preview version for NetworkCloud APIs

    * added custom words

    * added required attribute to payloads to correct aaz-dev-tool CLI generation

    * corrected console patch API payload

    * removed invalid child resources list by subscription APIs

commit d0ad5741faee68f00504bf66e22691d90e63589d
Author: Scott Taladay <[email protected]>
Date:   Tue Mar 21 22:51:13 2023 -0700

    [Hub Generated] Review request for Microsoft.HealthcareApis to add version stable/2023-02-28 (#22837)

    * Adds base for updating Microsoft.HealthcareApis from version stable/2022-12-01 to version 2023-02-28

    * Updates readme

    * Updates API version in new specs and examples

    * Adding "crossTenantCmkApplicationId" property with a new API version and new examples for data sovereign regions.

    * Fixing some issues based on automatic validator feedback.

    * Removed extra space causing model validation failures.

    * Added Azure App ID validation regex for crossTenantCmkApplicationId string property.

commit d42de0c5e72cfaf5e0049c89940ba00f6ac9815c
Author: Jiayi <[email protected]>
Date:   Tue Mar 21 22:09:06 2023 -0700

    Microsoft.AppConfiguration: Add new 2023-03-01 version (#22788)

    * Adds base for updating Microsoft.AppConfiguration from version stable/2022-05-01 to version 2023-03-01

    * Updates readme

    * Updates API version in new specs and examples

    * Add new APIs in 2023-03-01

    * Delete annotations.json

    * Delete assets.json

    * Update readme.test.md

    * Update basic.yaml

    ---------

    Co-authored-by: Lei Ni <[email protected]>

commit 9c9786a53eb85f49b77f274fb5baf666ef9f6a30
Author: FumingZhang <[email protected]>
Date:   Wed Mar 22 10:58:20 2023 +0800

    Review request for Microsoft.ContainerService/aks to add version 2023-02-01 & 2023-02-02preview (#23189)

    * release 2023-02-01 & 2023-02-02-preview

    * patch changes to previous API versions

commit cd2b76ce38029e1425ee024cd9403a908c60d71e
Author: Antonio Hernandez <[email protected]>
Date:   Tue Mar 21 19:26:31 2023 -0700

    [Hub Generated] Review request for Microsoft.Consumption to add version stable/2022-09-01 (#23054)

    * Adds base for updating Microsoft.Consumption from version stable/2021-10-01 to version 2022-09-01

    * Updates readme

    * Updates API version in new specs and examples

    * adding new API version (September Copper) to Swagger

    * fixing prettier check

commit 4496ceb36cfeff7443f3570274c437acd72a5ded
Author: Aravind Bharatha <[email protected]>
Date:   Tue Mar 21 22:25:52 2023 -0400

    [Hub Generated] Review request for Microsoft.Help to add version preview/2023-01-01-preview (#23056)

    * Generate new Service for help

    * init commit microsoft.help-2023-01-01-preview

    * Updating swagger documentation #1

    * Updating swagger documentation #2

    * Adding suppressions for Help 2023-01-01-preview api

    * Adding suppressions for Help 2023-01-01-preview api #2

    * removed unnecessary files

    * update examples

commit f76d810c973a3dd4ee6938eba0beae3d4799c48c
Author: MichaelMSWork <[email protected]>
Date:   Wed Mar 22 04:17:24 2023 +0200

    [Hub Generated] Review request for Microsoft.SaaS to add version preview/2018-03-01-beta (#22911)

    approved with false breaking change

commit b1806afc5064a18eca79fa14137bccc94937f88f
Author: iscai-msft <[email protected]>
Date:   Tue Mar 21 18:46:41 2023 -0700

    make path and body positional (#23185)

commit aa3618d1bd4b18cdbd308b1572c68393beaca9a6
Author: Asaf Levi <[email protected]>
Date:   Wed Mar 22 03:09:22 2023 +0200

    [Cognitive Services - Health Insights] CADL revision for public preview (#22990)

    * health insights cadl + generated openapi spec

    * fix PR Comments

    * change country to countryOrRegion

    * split to multiple cadl projects

    * update cadl-project.yaml files

    * update example with generic contact details

    * update samples with generic contacts

    * convert cadl to typespec

    * update generated openapi spec

    * convert cadl to typespec (#4)

    * convert cadl to typespec

    * update generated openapi spec

    * move ClinicalNoteEvidence to common modules

    * remove redundant imports

    * fix typespec dependencies

    * remove dependencies from main.tsp

    * using rest

    * move imports from service.tsp to its caller

    * fix comment - directive error

    * remove imports from service.tsp

commit 806d1616c2ce4c0a93fda266bd020903733ac326
Author: allison-inman <[email protected]>
Date:   Tue Mar 21 17:58:06 2023 -0700

    [Hub Generated] Review request for Microsoft.Quota to add version stable/2023-02-01 (#22367)

    * Adds base for updating Microsoft.Quota from version preview/2021-03-15-preview to version 2023-02-01

    * Updates readme

    * Updates API version in new specs and examples

    * Fix version in readme

    * Remove stale version, update readme

    * Mark parameter as optional

commit 543f1920ac96303cc244d60e1c12f0b56fc646db
Author: Paul Hsu <[email protected]>
Date:   Wed Mar 22 00:40:48 2023 +0800

    Add 2023-02-28-preview. (#23093)

    * Add 2023-02-28-preview.

    * Update cSpell.json

commit 969fd0c2634fbcc1975d7abe3749330a5145a97c
Author: Shannon Hicks <[email protected]>
Date:   Mon Mar 20 20:30:14 2023 -0700

    Edit description of properties.provisioningState (#23146)

commit 94e1f43b5c2b1d43716624f0d1dcc77161f2c2a9
Author: FumingZhang <[email protected]>
Date:   Tue Mar 21 11:07:30 2023 +0800

    Update custom words (#23034)

commit 85fb4ac6f8bfefd179e6c2632976a154b5c9ff04
Author: Peng Jiahui <[email protected]>
Date:   Tue Mar 21 10:43:44 2023 +0800

    [Go] paloaltonnetworks readme.go.md config (#23187)

commit ddcde53422ff186f5b69fb32338ecac3d11c3bca
Author: Charmaine Chan <[email protected]>
Date:   Mon Mar 20 18:48:53 2023 -0700

    Make failover group status type object to fix resource sync (#23058)

    * Make status object to fix resource sync

    * Remove trailing comma

    * Move changes to 2023-03-15-preview

    ---------

    Co-authored-by: Charmaine Chan <[email protected]>

commit 6272a882add762c6b55338da5c45a0537b812d9b
Author: swathipil <[email protected]>
Date:   Mon Mar 20 13:38:46 2023 -0500

    add data-plane ServiceBus swagger to main (#23057)

    * add back sb swagger

    * update api version param defintion

    * update api version num

    * prettier

    * spellcheck/readme

    * readme/lint

    * suppress x-ms-examples not found err

commit 0080664dbdee831fb21fc817e2acd434fd0fd146
Author: Ismael Navarro-Fuentes <[email protected]>
Date:   Mon Mar 20 10:24:44 2023 -0700

    Fixes for Features APIs' descriptions (#23001)

    * Remove ontology from API descriptions and clarify that properties are defined in the collection definition API

    * Specify GET Collection Definition

    * Add missing descriptions

    * Add more missing descriptions

    * Change 'Response' to 'Result'

    * Fix casing of descriptions

commit 314d792ae3b61131b33f22e644d059b227af85e8
Author: Jorge Cotillo <[email protected]>
Date:   Mon Mar 20 05:14:47 2023 -0700

    OperationalInsights fix missing enum value (#23123)

commit 3fb19df9ee39171e411cbd28af0cf5ac743d143e
Author: prchalla1 <[email protected]>
Date:   Sun Mar 19 23:59:42 2023 -0700

    To add Update Cost Details Field Link in GenerateCostDetailsReport (#23137)

commit ce64ee97437c0af59515e38bc86b45ffedfb1334
Author: Rahul Singh <[email protected]>
Date:   Sun Mar 19 23:11:36 2023 -0700

    Updating example for Linter Errors. (#23174)

    Co-authored-by: Rahul Singh <[email protected]>

commit 933dbc070dda85e2d115dc42893f07b2ed5b74f6
Author: guptashweta9 <[email protected]>
Date:   Mon Mar 20 11:23:51 2023 +0530

    G3 G4 SKU removal (#23099)

commit 4c843d69ebb62a67fe430330ae0ff42bf8ae89a1
Author: chcmsft <[email protected]>
Date:   Mon Mar 20 13:35:51 2023 +0800

    update description of geocoding api (#23101)

commit 6999a987a54bd6e1895c3abc9da7637503cb56e7
Author: Xiaogang <[email protected]>
Date:   Mon Mar 20 10:21:30 2023 +0800

    Enable Azure PowerShell CI for liftrqumulo (#22862)

commit b3a9eb662c17cbfc2ae5b7614ea66512bb5022c5
Author: matthohn-msft <[email protected]>
Date:   Sun Mar 19 18:42:51 2023 -0700

    [Hub Generated] Review request for Microsoft.Communication to add version preview/2023-03-01-preview (#22996)

    * Adds base for updating Microsoft.Communication from version preview/2021-10-01-preview to version 2023-03-01-preview

    * Updates readme

    * Updates API version in new specs and examples

    * Adding version 2023-03-01-preview changes.

    * Adding missing readme.md update

    * Addressing PR comments.

    * Updating to v5 common types

    * Incorporating comments from the stable version PR

    * Updating description for the provisioning state enum

    * Fixing model validation errors

    * Removing redundant systemData property.

    * Adding 201 response to indicate resource was create successfully

commit 72664c83300dfaf6782e22822a5aae0b0df92735
Author: Deyaaeldeen Almahallawi <[email protected]>
Date:   Fri Mar 17 13:05:54 2023 -0700

    [Language Text] Delete Dynamic Classification from v2022-10-01-preview (#23080)

    * [Language Text] Delete Dynamic Classification from v2022-10-01-preview

    * remove from dev

commit a42a3d01a056f02e345685f311961a18d5862cd1
Author: minnieliu <[email protected]>
Date:   Fri Mar 17 11:40:18 2023 -0700

    Feature/room api2023 (#22540)

    * Modify file for the new patch participants API

    * Participant endpoint changes for Rooms Api

    Introduce JMP for particpant collection.

    * Fix directory structure

    * Copy examples from previous version

    * update examples

    * Update swagger json and examples

    * Updated ParticipantsCollection property to use value instead participant and modified its descriptions

    * Update rooms json examples according to new changes (#22495)

    * Update rooms json examples according to new changes

    * Address pipeline validation errors

    * Address pipeline validation errors

    * Address pipeline validation errors

    * revert readme

    ---------

    Co-authored-by: Minnie Liu <[email protected]>

    * Update participant collection (#22498)

    * Updated Participant Collection Property  to use value in place of participant. Updated API sample

    * Updated Rooms_GetParticipants sample

    * Ran Prettier

    * [Rooms] Removed roomJoinPolicy and renamed RoleType to Role (#22494)

    * Added Title Property to RoomModel, CreateRoomRequest, UpdateRoomRequest

    * Revert "Added Title Property to RoomModel, CreateRoomRequest, UpdateRoomRequest"

    This reverts commit 48e46b0eac97bc5c29f7b782ddeb9c869948499c.

    * Added title property to RoomModel, CreateRoomRequest, UpdateRoomRequest (#22513)

    * Revert all changes in the 2022-02-01 swagger (#22539)

    Co-authored-by: Minnie Liu <[email protected]>

    * Revert all changes in the 2022-02-01 swagger

    * Add required request body for patch room (#22589)

    * Add required request body for patch room

    * Update update room example

    * Fix validation checks

    ---------

    Co-authored-by: Minnie Liu <[email protected]>

    * Update authorization description and remove format in Endpoint (#22609)

    * Update authorization description

    * Remove format in endpoint to align with other ACS services

    ---------

    Co-authored-by: Minnie Liu <[email protected]>

    * Updated Rooms API Specification Per Internal Review (#22608)

    * Updated Room API Spec per internal review

    * Fixed Validation Check Failures

    * Fixed Validation Failures on role type

    * Updated default values descriptions

    * Updated Readme with new API version

    * Clean up and fix communication error in spec (#22621)

    * Clean up and fix communication error in spec

    * Fix example version

    ---------

    Co-authored-by: Minnie Liu <[email protected]>

    * Removed Room Title Per Internal Review (#22640)

    * Add a new participant model with role as optional (#22641)

    Co-authored-by: Minnie Liu <[email protected]>

    * createdAt name change (#22651)

    * Remove Rooms 2023-01-01 version to clean up (#22676)

    Co-authored-by: Minnie Liu <[email protected]>

    * Remove bad examples (#22682)

    Co-authored-by: Minnie Liu <[email protected]>

    * Update current feature branch with the changes from DevEx review (#22859)

    * Update current feature branch with the changes from DevEx review

    * Update samples

    * Merge patch samples

    * fix

    * Missed comment from devex review

    * Missed comment from devex review

    * fix grammar

    * fix grammar

    ---------

    Co-authored-by: Minnie Liu <[email protected]>

    * Sort models in alphabetical order (#22886)

    Co-authored-by: Minnie Liu <[email protected]>

    * Add new get rooms list API (#22936)

    * Update format of repeatability-first-sent (#22968)

    * Update format of repeatability-first-sent

    * Update in correct version

    ---------

    Co-authored-by: Minnie Liu <[email protected]>

    * Update readme file to include previous version (#23002)

    * Update readme file to include previous version

    * Fix room ids

    * nit changes to list rooms API

    ---------

    Co-authored-by: Minnie Liu <[email protected]>

    * Update API Specification per preparation for ARB

    * Fix nit

    * Renamed Particpants_Patch to Participants_Update

    * Fix validation errors

    * Create Room should take a map of participants (#23090)

    * Create Room should take a map of participants

    * Fix Room Id example

    ---------

    Co-authored-by: Minnie Liu <[email protected]>

    * Fix validFrom and validUntil exampls

    * Add period to descriptions

    * Update description

    * Update description for create room participants

    ---------

    Co-authored-by: HuangXin-MS <[email protected]>
    Co-authored-by: anujissarMS <[email protected]>
    Co-authored-by: Mike Hang <[email protected]>
    Co-authored-by: Minnie Liu <[email protected]>
    Co-authored-by: Mrayyan <[email protected]>

commit fce14bf881523f16b14d8ecf325e004465cdcf56
Author: Peng Jiahui <[email protected]>
Date:   Fri Mar 17 11:42:30 2023 +0800

    [Go] newrelic config readme.go.md (#23148)

commit 6dbf5dc1c2894ed15293b40495ac4776fdb2ebce
Author: Tom FitzMacken <[email protected]>
Date:   Thu Mar 16 18:23:57 2023 -0700

    clarify when reserved is required (#22860)

commit 231b725bd2c8fce13c5341e34f7a6329c460dc94
Author: Sena Gungor <[email protected]>
Date:   Fri Mar 17 04:06:36 2023 +0300

    Update operation ids (#23100)

commit a5c02f03ec242a2acef309bbdfd4734c100f1839
Author: croos-msft <[email protected]>
Date:   Thu Mar 16 11:06:07 2023 -0700

    Add Supporting Windows Docker Container Hosted API Services (#22587)

    * Add windowsdatacontainer and pipeline changes

    * Add pipeline changes

    * Fix hardcoded brnch

    * Copy git file to whichever Dockerfile path is being used

    * Remove changes to data-container pipeline

    * Setup windows pipeline

    * Update with correct ps1 location

    * Fix issues with dockerfile

    * Use Windows-styled folders

    * Add logic to replace base image

    * Add base_image_windows

    * Correctly refer to Dockerfile

    * Enclose in quotation marks

    * Only use servercore:ltsc2022

commit daeb320057bd56a88379c377d934150ef48d143f
Author: Ralf Beckers <[email protected]>
Date:   Thu Mar 16 17:31:56 2023 +0100

    Add support for ChatGPT to Azure OpenAI authoring APIs (#23076)

    * Add old api version as base for new

    * Added changes for new version

    * Fix reference in readme

commit 27983ba0a242e18b9f7cbb6f654f82e3ed471045
Author: Ralf Beckers <[email protected]>
Date:   Thu Mar 16 17:31:20 2023 +0100

    Add support for ChatGPT (chats/completion) for Azure OpenAI (#23074)

    * Added old spec under new location as base

    * Add chat completion API to inference specs

    * Add custom word

    * Fixed model name and product name

commit 7f5ff3f2011f2f8019ff5db4b6cc00a128c01eb5
Author: ofermoses <[email protected]>
Date:   Thu Mar 16 10:32:40 2023 +0200

    removing mcas from examples in MDC settings api docs as intergration is being deprecated. (#23072)

    no changes to actual API client, just docs

    Co-authored-by: [email protected] <[email protected]>

commit f4d602920b38b342c93141fcfe42fa27d0b216c2
Author: giakas <[email protected]>
Date:   Thu Mar 16 00:22:40 2023 -0700

    Adding a custom tag with older streaming for C#SDK (#23126)

commit 63ec6d9ea3bed80da29f70e5ab27c0b58d07a2ab
Author: anjaliOra <[email protected]>
Date:   Thu Mar 16 00:07:00 2023 -0700

    [Hub Generated] Publish private branch 'datafactory/anjshar/adfNewSwaggerUpdateForIR' (#23122)

    * [AutoSync] ecc97ae10f new process private swagger update

    * [AutoSync] 45ff9fdbbb moving additionalProps out of props

    * [AutoSync] 0287001cba adding identifier

    ---------

    Co-authored-by: swagger-automation <[email protected]>

commit 9565a97e3efbeb3691c9100d5473b0a884c1b786
Author: Tim Lovell-Smith <[email protected]>
Date:   Wed Mar 15 22:26:14 2023 -0700

    Refactor cache swagger to deduplicate SkuName enum definitions. (#23049)

commit 51b8f2084b05e705baf30f24ea0a40a346e2c5a5
Author: Crystal YU <[email protected]>
Date:   Thu Mar 16 11:37:32 2023 +0800

    upgrade openapi to typespec library 0.41.0 (#23038)

    * upgrade openapi to tyepspec library 0.41.0

    * add typespec as custom word

    * update package.json

commit 75376d385724a046204f53baccc6fa1bbfdbe73b
Author: Crystal YU <[email protected]>
Date:   Thu Mar 16 11:20:14 2023 +0800

    upgrade AnomalyDetector to use typespec library 0.41.0 (#23036)

    * upgrade AnomalyDetector to use typespec library 0.41

    * updated package.json

    * remove un-used python emitter dependency

commit 8e7fbe5d8c0e33f99ad365951485107a0ad8a181
Author: jha1bhavna <[email protected]>
Date:   Thu Mar 16 08:34:39 2023 +0530

    Adding None as allowed values for TLS (#22949)

commit ebd66fc9cadab5c3165b8610d47e3e863edec13a
Author: himasekhar-ms <[email protected]>
Date:   Thu Mar 16 08:21:47 2023 +0530

    Himasekhar ms mediaservices microsoft.media 2023 01 01 (#22557)

    * Adds base for updating Microsoft.Media/Metadata from version stable/2022-08-01 to version 2023-01-01

    * Updates readme

    * Updates API version in new specs and examples

    * Adding new version 2023-01-01 for metadata APIs which includes ecryption scope support in Assets create API

    * Updating AssetsAndAssetFilters manifest with new property encryptionScope and adding new test case for asset create with encryption scope

    * Fixed text alignment issues in the example file

    * Adding new example file in AssetsAndAssetFilters

    * Add missing swagger files and update tag name

    * Fixing the path for the Swagger file

    * Updating stemingService version to 2022-01-01

    * Updating stemingService version to 2022-08-01

    * Reverting the StremingServive API version changes

    * fix the test readMe file

    * fix the test readMe input file version

    ---------

    Co-authored-by: giakas <[email protected]>

commit ee157d6bbf6e4c4fdc8a47b380e00ddd56a0e852
Author: Oliver Towers <[email protected]>
Date:   Wed Mar 15 01:41:16 2023 -0700

    [Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2023-03-01-preview (#23081)

    * Adds base for updating Microsoft.DocumentDB from version preview/2022-11-15-preview to version 2023-03-01-preview

    * Updates readme

    * Updates API version in new specs and examples

    * Apply 2023-03-01-preview addditions

    * Apply mongocluster additions

    * Minor changes.

    * Fixes fo go and Lintdiff/descriptions.

    * Add back canceled provisioningState

commit 5342f4101b09fc87f595b980bb4bb59f8d143027
Author: Moshe Malka <[email protected]>
Date:   Wed Mar 15 09:27:05 2023 +0200

    [Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2023-03-01 (#22284)

    * Adds base for updating Microsoft.AlertsManagement from version preview/2021-07-22-preview to version 2023-03-01

    * Updates readme

    * Updates API version in new specs and examples

    * adding PrometheusRuleGroups stable api-version

    * rename example titles

    * improve descriptions

    * improve examples

    * fix lintdiff errors

    * add pattern to rule name

    * fix pattern

    * remove validations

    * add recomandations

    * change actions

    * change to last acions property version

    * run prettier

    * fix PR review comments

    ---------

    Co-authored-by: Moshe Malka <[email protected]>

commit c72a972a6d4fa9e64bb62653e996155379292ebf
Author: Matthew Christopher <[email protected]>
Date:   Tue Mar 14 23:29:05 2023 -0700

    Update Microsoft.Sql ARM API with "format: arm-id" where appropriate and x-ms-secret where appropriate (#22677)

    * SQL ARM IDs

    * Secrets

    * Examples fix

    * Fix examples

commit 4ede5fdef83563cfd08b1017ade793cb4e089057
Author: Naman Agarwal <[email protected]>
Date:   Wed Mar 15 11:33:19 2023 +0530

    [Stable Oct GA] Bring back Scheduled Shutdown MLC models (#23069)

    Co-authored-by: Naman Agarwal <[email protected]>

commit 7e5861ad01a796a72617080e89e42f428e66242e
Author: Chris Huang <[email protected]>
Date:   Tue Mar 14 21:37:19 2023 -0700

    [Hub Generated] Review request for Microsoft.Devices to add version preview/2022-11-15-preview (#22067)

    * Adds base for updating Microsoft.Devices from version preview/2022-04-30-preview to version 2022-11-15-preview

    * Updates readme

    * Updates API version in new specs and examples

    * Huangc 2022 11 15 preview (#22110)

    * update iothub example with ipversion and new api version of 2022-11-15-preview

    * fix validation

    * fix with adding location into lro header

    * update manual failover json with adding azure-AsyncOperation

    * remove location to see if pass the check

    * fix

    * fix

    * fix

    * fix with adding location

    * Adding Azure-AsyncOperation to manualfailover

    * test fix

    * quick style fix for 2019-03-22

    * update 2022-11-15-preview MF example

commit 9afbd00d619f4443ba50848f77c9b6237ba76d15
Author: Samuel Kuang <[email protected]>
Date:   Tue Mar 14 20:42:46 2023 -0700

    Merge release sentinel 2023 03 01 preview (#22983)

    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-03-01-preview

    * Updates readme

    * Updates API version in new specs and examples

    * Update description of AAD (#22508)

    * Update description of AAD

    AAD should be AADIP to prevent mistakes from customer

    * Add custom word AADIP

    AADIP = Azure Active Directory Identity Protection

    * Remove bing phishing feed msti connector (#22706)

    * remove bing phishing feed from msti connector

    * revert to release-Sentinel-2023-03-01-preview

    * fixes

    * fixed validation issues

    * renamed example file

    * added response status codes for examples

    * Automation rules - 2023-03-01-preview - add entity trigger API (#22523)

    * adjust version order

    * Fix cross-version breaking changes.

    Fix cross-version breaking changes.

    * Pull in metadata changes from stable version.

    * Update Metadata.json

    * Update Incidents.json

    add readonly flag for providerIncidentId.

    * Update readme.md

    GuidUsage AutoRest-Linter suppression.

    * Update readme.md

    suppress GuidUsage

    * Update readme.md

    Correct suppression.

    * Update readme.md

    Fix suppression.

    ---------

    Co-authored-by: shschwar <[email protected]>
    Co-authored-by: aviyerMSFT <[email protected]>
    Co-authored-by: loriatarms <[email protected]>

commit 5bf60a6746bc03fbff78cc68595eb11f2f212d19
Author: Dor Siso <[email protected]>
Date:   Wed Mar 15 04:28:59 2023 +0200

    Limit top incidents resource types (#22790)

    * Add blockchain to latest profile

    * Add additional types

    * Limit incidents list resource type maximum results

    * Fix format

    ---------

    Co-authored-by: Mark Cowlishaw <[email protected]>

commit ac29c822ecd5f6054cd17c46839e7c04a1114c6d
Author: apattath <[email protected]>
Date:   Tue Mar 14 17:45:00 2023 -0700

    Azure Communication Services Email API for GA (#22979)

    * Copy existing preview version of CommunicationServicesEmail API to stable folder in preparation for GA

    * update version to 2023-03-31

    * update comment about events for 202 result

    * update readme file

    * updated description of Operation-ID header

commit a05c36a524b42600bbdbbeddc8e3527f7d424351
Author: Alex Karcher <[email protected]>
Date:   Tue Mar 14 17:08:04 2023 -0700

    Updating Microsoft.Web api to remove duplicate workflowState definition (#23083)

    * Merging upstream/main

    * Updated flowState to be a reference

    * Removing conflict

    * Revert "Removing conflict"

    This reverts commit 7029fe8d55fa49997bfdeb99160a64a4f1c24e66.

    * Revert "Merging upstream/main"

    This reverts commit d60a048ccee93685c11e53b623ed17bd1da77325.

commit adbce0f14768da2404217860a8d35f9aeb16388e
Author: AmirGeorge <[email protected]>
Date:   Tue Mar 14 20:19:45 2023 +0200

    Adding changes for Language Authoring 2023-04-01 to dev folder (#22396)

    * Adding changes for Language Authoring 2023-04-01 to dev folder

    * removing examples of features not shipping in GA

    * fixes

    ---------

    Co-authored-by: Amir George <[email protected]>

commit 5a49823c43b422e5f3b0ec2ce8846d84cfe7c149
Author: Gaurav Kumar <[email protected]>
Date:   Tue Mar 14 18:27:33 2023 +0530

    [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2023-02-01 (#22492)

    * Adds base for updating Microsoft.RecoveryServices from version stable/2023-01-01 to version 2023-02-01

    * Updates readme

    * Updates API version in new specs and examples

    * Adding Restore Settings

commit f858b937d0f921a9d008a1d03ab74c3fc4378470
Author: gulopesd <[email protected]>
Date:   Tue Mar 14 00:03:53 2023 -0700

    Edit description of orderBy (#22807)

commit 100f2b143b144287dbfd11dd2615c36070fbd1fe
Author: grchris-microsoft <[email protected]>
Date:   Tue Mar 14 09:02:02 2023 +0200

    [Hub Generated] Review request for Microsoft.Insights to add version preview/2023-01-01-preview (#22575)

    * Adds base for updating Microsoft.Insights from version stable/2020-10-01 to version 2023-01-01-preview

    * Updates readme

    * Updates API version in new specs and examples

    * added tenant scope in the new ALA api version

    * updated tenant level service health rule example

    * fixed linter errors

    * added "actionProperties" to the api and examples

    * fix prettier. added object types. typo fix

    ---------

    Co-authored-by: Gregory Chris <[email protected]>

commit a54263176acce91199a19333d6c4717367a3317e
Author: saviesacov <[email protected]>
Date:   Tue Mar 14 08:06:59 2023 +0200

    Marketplace version 2023-01-01 (#22527)

    * init version 2023-01-01

    * GetPrivateStoreOffersWithSubscriptions

    * readme package-2023-01-01

    * add flatten

    * renaming

    * add x-ms-pageable

    * CollectionOffersByContext returns OfferProperties

    * minor fix

    * mapOffersToContexts

commit d4dfb3388ab40185cf302512268ad1406f666d64
Author: pednekarpraj <[email protected]>
Date:   Mon Mar 13 19:37:10 2023 -0700

    Update eTag property description (#23059)

commit 9f339d469c0fe83466edfe295a7960c82ebecf4f
Author: Carlos Oviedo <[email protected]>
Date:   Mon Mar 13 18:49:38 2023 -0500

    [Hub Generated] Publish private branch 'dev-graphservicesprod-Microsoft.GraphServices-2022-09-22-preview' (#23000)

    * add or modify files

    * Update graphservicesprod.json

    Bring changes from https://github.com/Azure/azure-rest-api-specs-pr/pull/9502/files.

    ---------

    Co-authored-by: Xiaofei Cao <[email protected]>

commit ae3714515dfa35d3a65fc27df6b8a6835d996db1
Author: Drew McDaniel <[email protected]>
Date:   Mon Mar 13 14:57:14 2023 -0700

    Updating notification for Compute (#23018)

commit 6b921fdde7c1806efca2b5aa41ca46ec65f3092e
Author: pansharm-ms <[email protected]>
Date:   Mon Mar 13 21:55:10 2023 +0530

    Add PDS GA APIs. (#23010)

    * Add PDS GA APIs.

    * Fix timespan.

    * Correct examples.

commit 9e17eb2d475e8908277d929b0e4a4c582e2ba752
Author: Yuchao Yan <[email protected]>
Date:   Mon Mar 13 19:33:21 2023 +0800

    update (#22981)

commit 0e13373c80d638f9e0370877aee0ffe5c3101f5d
Author: Roger Nhan <[email protected]>
Date:   Mon Mar 13 04:45:55 2023 -0400

    [Hub Generated] Publish private branch 'main' (#23015)

    * Onboard Microsoft.ContainerStorage with API version 2023-03-01-preview

    * Revert accidental change to elasticsan readme

commit 4b4bb1021353692578499f43f1aa912964a2b7e2
Author: zdelacerda-microsoft <[email protected]>
Date:   Mon Mar 13 01:06:14 2023 -0700

    [Hub Generated] Publish private branch 'imagebuilder/master' (#22901)

    * [AutoSync] a35dd0d71 Merged PR 6495219: Release swagger changes through shift left

    * [AutoSync] 2a3c8eafa Merged PR 7671495: Merge from develop to master to start ABI release

    * Update custom-words.txt

    adding "DistributeVersioner" to custom-words doc

    ---------

    Co-authored-by: swagger-automation <[email protected]>

commit ba9f30eed00b61ebb1ceedecd65a8ce82c81609b
Author: Yuchao Yan <[email protected]>
Date:   Mon Mar 13 12:57:40 2023 +0800

    Update readme.python.md (#23033)

commit 9665feff0ab62918a35e19f1c82187397ec81705
Author: navba-MSFT <[email protected]>
Date:   Mon Mar 13 10:20:29 2023 +0530

    {AzureServiceFabric} fixes Azure/azure-rest-api-specs#22806 The ClusterVersion API redirects to invalid link (#22868)

    "description": "The Service Fabric runtime version of the cluster. This property can only by set the user when upgradeMode is set to 'Manual'. To get list of available Service Fabric versions for new clusters use [ClusterVersion API](https://github.com/Azure/azure-rest-api-specs/issues/ClusterVersion.md)"

    The link goes to ./ClusterVersion.md which does not exist. This actually causes dead links in the official MS documentation, e.g. [here](https://learn.microsoft.com/en-us/rest/api/servicefabric/clusters/list?tabs=HTTP#cluster).

commit ee96574a6d4ed37a06883b8e3f8fd3adf4803b83
Author: Yuchao Yan <[email protected]>
Date:   Mon Mar 13 11:46:12 2023 +0800

    Update readme.python.md (#23031)

commit 17f5f0659c4b395863f1b7752d1bd6a0771a06dd
Author: Yuchao Yan <[email protected]>
Date:   Mon Mar 13 11:45:42 2023 +0800

    Update readme.python.md (#23032)

commit 0fbb9e53310d0e919a11777765f6d4631d192ae2
Author: kim-soohwan <[email protected]>
Date:   Sun Mar 12 20:05:53 2023 -0700

    [Hub Generated] Publish private branch 'kim-soohwan-keyvault-mhsm-Microsoft.KeyVault-2023-02-01' (#22625)

    * Adds base for updating Microsoft.KeyVault from version stable/2022-11-01 to version 2023-02-01

    * Updates readme

    * Updates API version in new specs and examples

    * Updated readme files

    * Updated location headers to current examples for MHSM async operations

    * Adding georeplication support for Managed HSM

    * Added new isPrimary property to MHSM Regions

    ---------

    Co-authored-by: Soohwan Kim <[email protected]>

commit 44cc617c7dd775f221f4e0fb4dda58ff739a40cb
Author: navba-MSFT <[email protected]>
Date:   Mon Mar 13 07:45:37 2023 +0530

    {AzureNetwork} fixes Azure/azure-rest-api-specs#22448 Making priority required (#22874)

    * {AzureNetwork} fixes Azure/azure-rest-api-specs#22448 Making priority required

    fixes #22448

    [This is the API](https://learn.microsoft.com/en-us/rest/api/virtualnetwork/network-security-groups/create-or-update?tabs=HTTP#code-try-0) I invoked.

    For the NSG security rules without priorities, seems like the priority parameter is required. Azure portal works as expected. I don't think that's allowed but according to the schema it is because the priority property is not marked as required. I tried to create a NSG security rule without the priorities and it failed with below. Intrestingly the Azure

    Request Body:
    ```
    {
      "properties": {
        "securityRules": [
          {
            "name": "rule1",
            "properties": {
              "protocol": "*",
              "sourceAddressPrefix": "*",
              "destinationAddressPrefix": "*",
              "access": "Allow",
              "destinationPortRange": "80",
              "sourcePortRange": "*",
              "direction": "Inbound"
            }
          }
        ]
      },
      "location": "eastus"
    }
    ```
    Response received:
    ```
    {
      "error": {
        "code": "SecurityRuleInvalidPriority",
        "message": "Security rule has invalid Priority. Value provided: 0 Allowed range 100-4096.",
        "details": []
      }
    }
    ```
    This PR will make the priority parameter as required.

    * Update NetworkSecurityGroupRuleDelete.json

    Long running operation should return `azure-AsyncOperation` in response header.

    * Update NetworkSecurityGroupDelete.json

    Long running operation should return location or azure-AsyncOperation in header.

    * Update NetworkSecurityGroupRuleDelete.json

    * Update NetworkSecurityGroupDelete.json

    * Update NetworkSecurityGroupRuleDelete.json

    * Update NetworkSecurityGroupDelete.json

commit cacbca520a479632528f3493a7950fa347da9f52
Author: navba-MSFT <[email protected]>
Date:   Mon Mar 13 07:45:04 2023 +0530

    {AzureNetwork} fixes Azure/azure-rest-api-specs#20256 Fix for applicationGatewayIpConfigurations, property (#22875)

    fixes #20256

    This swagger definition is defining property applicationGatewayIpConfigurations,

    ```
    "applicationGatewayIpConfigurations": {
              "type": "array",
              "items": {
                "$ref": "./applicationGateway.json#/definitions/ApplicationGatewayIPConfiguration"
              },
              "description": "Application gateway IP configurations of virtual network resource."
            }
    ```
    but actual rest api returned applicationGatewayIPConfigurations, the P is upper case while in swagger it is lower case.
    ```
    {
      "name": "subnet-agw",
      "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/virtualNetworks/<vnet-name>/subnets/subnet-agw",
      "properties": {
          "applicationGatewayIPConfigurations": [
              {
                  "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/applicationGateways/<agw-name>/gatewayIPConfigurations/appGatewayIpConfig"
              }
          ]
      },
      "type": "Microsoft.Network/virtualNetworks/subnets"
    }
    ```
    Please update correspondingly.

commit 95fb710c0025b325306898a3210333eaaf5d5e62
Author: shesamian <[email protected]>
Date:   Sun Mar 12 17:41:44 2023 -0700

    [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2023-02-01 (#22930)

    * Adds base for updating Microsoft.RecoveryServices from version stable/2023-01-01 to version 2023-02-01

    * Updates readme

    * Updates API version in new specs and examples

    * Added 2023-02-01 changes

commit 10c740b7224771c889cfb92f128168f5a0568c26
Author: xiaoxu qi <[email protected]>
Date:   Fri Mar 10 16:57:42 2023 +0800

    Reorganize 2021-12-01-preview into sub service folder (#22988)

    * split into sub service folder

    * fix model validation

    * fix validation

    * fix LRO in stable version

    * fix

commit 571e783ddaa6f898d0984829bee07feee713d14c
Author: Tianen <[email protected]>
Date:   Fri Mar 10 16:04:00 2023 +0800

    Delete GitHub Action (#23004)

    * Update specificationRepositoryConfiguration.json

    * delete github action code directlly

    * revert specificationRepositoryConfiguration.json

    ---------

    Co-authored-by: Wei Dong <[email protected]>
    Co-authored-by: Ruoxuan Wang <[email protected]>
    Co-authored-by: Tianxiang Chen <[email protected]>

commit a2e2617050e68ae1c445db565076c5a7f42ebad4
Author: Roni <[email protected]>
Date:   Fri Mar 10 09:31:28 2023 +0200

    [Hub Generated] Publish private branch 'roni93-security-Microsoft.Security-2023-02-01-preview' (#23005)

    * Adds base for updating Microsoft.Security from version preview/2022-11-20-preview to version 2023-02-01-preview

    * Updates readme

    * Updates API version in new specs and examples

    * Add health reports API

    * Fix words and urls

    * Fix spaces

    * revert change

    * fixes

    * Fixes

    * fixes

    * Remove operations

    * Add subscription Id

    * revert change

    * revert change

    * Fixes after CR

    * Change end point scope

    * Fix CR

    * Fix after CR

    * Update exmaples

    * Add to readme

    * Fixed after CR

    * Fixes after CR

    * Fix typo

    * change back to id

    ---------

    Co-authored-by: Roni Zhelenchuk <[email protected]>

commit c9a6e0a98a51ebc0c7a346f4fd425ba185f44b31
Author: Tianen <[email protected]>
Date:   Fri Mar 10 14:39:33 2023 +0800

    Stop GitHub Action Running (#23003)

    * Update specificationRepositoryConfiguration.json

    * delete schedule config

    * revert specificationRepositoryConfiguration.json

    ---------

    Co-authored-by: Wei Dong <[email protected]>
    Co-authored-by: Ruoxuan Wang <[email protected]>
    Co-authored-by: Tianxiang Chen <[email protected]>

commit 644e559292ea3314c1636285f138b8696536b006
Author: Alfredo Santamaria <[email protected]>
Date:   Thu Mar 9 19:01:03 2023 -0800

    Service Fabric Managed Clusters - api version 2023-02-01-preview  (#22752)

    * initital commit copy from 2022-10-01-preview

    * update definitions with new api version

    * update examples

    * add new api version to readme and fix shared gallery example

    * add missing x-ms-error-response

    * add enableNodePublicIP

    * remove unnecessary status codes 404 and 400

    ---------

    Co-authored-by: Alfredo Santamaria Gomez <[email protected]>

commit 65d3b5ecda664c318d2ad011c790ad2d6086ed93
Author: Ruoxuan Wang <[email protected]>
Date:   Fri Mar 10 10:48:46 2023 +0800

    Update comment.yml (#22661)

commit dfd2eb9b16d96559b97dbc53bb32597611133796
Author: dav5liao <[email protected]>
Date:   Thu Mar 9 18:43:47 2023 -0800

    Dav5liao azurearcdata microsoft.azure arc data 2023 03 15 preview (#22982)

    * Adds base for updating Microsoft.AzureArcData from version preview/2023-01-15-preview to version 2023-03-15-preview

    * Updates readme

    * Updates API version in new specs and examples

    * Copied from azure-rest-api-specs-pr branchRPSaaSMaster

    * required fix.

commit c6a658f01e1f73dbdaef43fe5055ceaca1b60a93
Author: ZhidaLiu <[email protected]>
Date:   Thu Mar 9 18:34:36 2023 -0800

    Update SoftDelete/FeatureStore changes to MachineLearningService 2023-02-01-preview (#22998)

    * Add soft delete and FeatureStore support for new api version

    * remove unused property

    * fix format

commit 8f45069999e606869d5817252b89a7513e868db9
Author: zhenbiao wei <[email protected]>
Date:   Fri Mar 10 10:16:40 2023 +0800

    Update readme.python.md (#22989)

    * Update readme.python.md

    * Update readme.python.md

    ---------

    Co-authored-by: Yuchao Yan <[email protected]>

commit a498cae6d1a93f4c33073f0747b93b22815c09b7
Author: Marina Bashtovaya <[email protected]>
Date:   Thu Mar 9 19:40:26 2023 -0500

    NetworkCloud 2022-12-12-preview add approved preview corrections (#22820)

    * first public preview version for NetworkCloud APIs

    * added custom words

    * added required attribute to payloads to correct aaz-dev-tool CLI generation

    * corrected console patch API payload

commit 3de956a007e6b8629617b8968409311253927947
Author: Sena Gungor <[email protected]>
Date:   Thu Mar 9 16:15:29 2023 +0300

    Update descriptions for Microsoft.DBforPostgreSQL for version stable/2022-11-08 (#22955)

    * Update descriptions

    * Update descriptions & fix cluster names in examples

    * Update domain names & fix config, pec, operation descriptions

    * Update create configuration operation ids

    * Add reference link for storage and vCores

    * Add missing dot in description

    * Change configuration operation id

    * Remove unnecessary property in examples, fix reference link for compute

    * Fix readme error

    * Revert breaking operationId changes

    * Remove suppress rule

    ---------

    Co-authored-by: Ozan Saka <[email protected]>

commit d82babc9bd0fa25260d04e52d841c2a6f59792c8
Author: meirloichter <[email protected]>
Date:   Thu Mar 9 09:50:36 2023 +0200

    [S360 fix] Add details field to ErrorResponse (#22910)

    merge with breaking change approved

commit add28efcd3a5fd422285d992fb1ec5ee5a7a40a6
Author: Karishma Daga <[email protected]>
Date:   Wed Mar 8 21:29:51 2023 -0800

    [Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2023-02-01-preview (#22436)

    * Adds base for updating Microsoft.MachineLearningServices from version preview/2022-12-01-preview to version 2023-02-01-preview

    * Updates readme

    * Updates API version in new specs and examples

    * Add managedResourceGroupTags to registries Feb 2023 Preview swagger (#22617)

    * removed feb2023 registries.json

    * Revert "removed feb2023 registries.json"

    This reverts commit d2d1f7055e00284ba040cf0b792404956fb89c24.

    * add managedResourceGroupTags property

    ---------

    Co-authored-by: Komal Yadav <[email protected]>

    * updating to feb 2023 preview (#22456)

    * updating to feb 2023 preview

    * adding example files

    * add to custom words, remove spelling errors

    * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

    Co-authored-by: Jianye Xi <[email protected]>

    * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

    Co-authored-by: Jianye Xi <[email protected]>

    * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

    Co-authored-by: Jianye Xi <[email protected]>

    * resolving model validation errors

    * try resolving operation async response validation errors

    * merge data container/ver, queue settings

    * add datacontainer and version example files, add LRO uri

    * update example jobs files, update LRO and registry name pattern

    * last LRO fixes

    * test that batchdeploymentproperties is resolved

    * adding maulik's swagger generation PR changes

    * update swagger with new deduped batch names

    * adding updated computeresource name

    * add boolean featuredatatype

    ---------

    Co-authored-by: Jianye Xi <[email protected]>

    * ManagedNetwork Support and paramter parttern update for WorkspaceRP (#22588)

    * add swagger support for managed network

    * update parameter pattern

    * Add rules

    * remove unused file

    * fix

    * fix format and add pattern

    * update format and example

    * revert manage network changes

    * small change

    * revert

    * Staging Branch Gate Fixes and Schema Bug Fix for ModelPackage (#22784)

    * updating to feb 2023 preview

    * adding example files

    * add to custom words, remove spelling errors

    * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

    Co-authored-by: Jianye Xi <[email protected]>

    * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

    Co-authored-by: Jianye Xi <[email protected]>

    * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

    Co-authored-by: Jianye Xi <[email protected]>

    * resolving model validation errors

    * try resolving operation async response validation errors

    * merge data container/ver, queue settings

    * add datacontainer and version example files, add LRO uri

    * update example jobs files, update LRO and registry name pattern

    * last LRO fixes

    * test that batchdeploymentproperties is resolved

    * adding maulik's swagger generation PR changes

    * update swagger with new deduped batch names

    * adding updated computeresource name

    * add boolean featuredatatype

    * fixing model validation pattern error

    * fix LRO gate

    * adding model package updates to swagger

    * un requiring property

    ---------

    Co-authored-by: Jianye Xi <[email protected]>

    ---------

    Co-authored-by: Komal Yadav <[email protected]>
    Co-authored-by: Komal Yadav <[email protected]>
    Co-authored-by: Jianye Xi <[email protected]>
    Co-authored-by: ZhidaLiu <[email protected]>

commit 1745efa6229fa8ed63ad0ec2dfb5141e37afecac
Author: navba-MSFT <[email protected]>
Date:   Thu Mar 9 10:10:53 2023 +0530

    {AzurePostgreSQL} fixes Azure/azure-rest-api-specs#22851 Data encryption type enum should be SystemManaged (#22943)

    merged with breaking change approved.

commit 2048c7db421a8e92839f0fccfaf683b60eed9a20
Author: pednekarpraj <[email protected]>
Date:   Wed Mar 8 19:44:28 2023 -0800

    Fix linter error R4001 (#22973)

commit 93fbd7d8554d2bb504f85daf4c5b6b87db4abb54
Author: Vibhuti-Sharma-Microsoft <[email protected]>
Date:   Thu Mar 9 08:04:13 2023 +0530

    Added pan specifications (#22878)

    Co-authored-by: Yuchao Yan <[email protected]>

    Discussed with @Vibhuti-Sharma-Microsoft The operation ID will be fixed in subsequent change, since this version of swagger has already been merged in `azure-rest-api-specs-pr`.

commit f6ca660f317033a6ae2057962305a40f616e27f6
Author: yuc-Li <[email protected]>
Date:   Wed Mar 8 19:51:04 2023 +0800

    {HDInsight} Fix S360 Swagger Linter items - Error R2010 (#22813)

    * Fix Swagger Linter - 1

    * Fix Swagger Linter - 2

    * Fix Swagger Linter - 3

    * Fix Swagger Linter - 4

    * Update Location Value - HDInsight

    * Add "resourceGroups/rg1/" to 17 Location value

    * Update Location value

    Not confirmed but upgraded

    * Update pathToOperationResult to operationid

    ---------

    Co-authored-by: v-yuchenli <[email protected]>

commit 7d313ecb6a58a51046a3916ee5ea6b6d29973522
Author: Yuchao Yan <[email protected]>
Date:   Wed Mar 8 16:33:32 2023 +0800

    update (#22965)

commit 4f4044394791773e6e7e82a9bd90d3935caaca1b
Author: Jorge Herrera <[email protected]>
Date:   Tue Mar 7 21:56:27 2023 -0800

    [Hub Generated] Review request for Microsoft.Insights to add version stable/2022-06-01 (#22619)

    * Base from version 2021-09-01-preview

    * adding 2022-06-01 for DCR, DCRA, and DCE

    * readme MD changes

    * fix examples

    * fix provisioning value list

    * deduplication for csharp track2

    * custom-words

    * dedupe

    * modelerfour

    * undo readme changes

    * add new package in readme.md

    * fix readme.md

    * revert readme.md

    * add new package

commit 120c2910613641e64e4a4bdf2dcf0cd5af9c7664
Author: kazrael2119 <[email protected]>
Date:   Wed Mar 8 11:24:30 2023 +0800

    update typescript.md for graphservices (#22964)

commit d7558574049caf673720e446ddeab49d0ed8d8c1
Author: Samir Solanki <[email protected]>
Date:   Tue Mar 7 17:40:49 2023 -0800

    odata fixes for ApiWikis and ProductWikis Api (#22854)

    * odata fixes

    * add skip query

    * apim doc for filter

    * documentation

commit 1e7b408f3323e7f5424745718fe62c7a043a2337
Author: Ray Chen <[email protected]>
Date:   Wed Mar 8 07:52:21 2023 +0800

    Updated pipeline related PR assignment (#22945)

commit 68aa92c941547dffe3e0d980a529cdc8688faff3
Author: Jimmy Campbell <[email protected]>
Date:   Tue Mar 7 10:15:52 2023 -0800

    Update snapshot status selector to take multiple statuses. (#22805)

    * Update snapshot status selector to take multiple statuses.

    * Update snapshot status search to be an array.

    * Name updates.

    * Use capital like 'After' parameter.

commit 92f0949e7d41e69d612c4a9f0d006b5facb84c05
Author: Julia Gong <[email protected]>
Date:   Tue Mar 7 09:15:32 2023 -0800

    fix tags, description, and api model (#22958)

commit df54c612a18e376b1bc2ddb7dc12cb31d2a1c149
Author: yifan-zhou922 <[email protected]>
Date:   Tue Mar 7 23:18:58 2023 +0800

    Upstream/release purview azure.analytics.purview.catalog 2022 08 01 preview (#21770)

    * update 2022-08-01-preview

    * Update purviewcatalog.json

    * remove get lineage by unique attribute

    * Update readme.md

    * Add search example

    * Revert "remove get lineage by unique attribute"

    This reverts commit d8ea3cddc6d874634aa8e4939799528bf2818c5a.

    * Update purviewcatalog.json

    * Update purviewcatalog.json

    * Fix bizMetadata sample issue

    * Update readme.md

    * fix error

    * remove change in 2022-03-01

    * Update purviewcatalog.json

    * Update purviewcatalog.json

    * update example

    * update examples

    * Update purviewcatalog.json

    * Update missing query parameter

    * update query parameter & response header

    * update lineage examples

    * update example

    * add collection id & add createdBy for glossaryBaseObject

    * update description

    * add examples

    * update examples

    * update additionalProperties to solve invalid type model validation error

    * fix model validation error

    * fix model validation error

    * update description

    * Update description

    * Update Entity_GetEntitiesByUniqueAttributes.json

    * Update query parameter for test

    * Update purviewcatalog.json

    * Revert "Update purviewcatalog.json"

    This reverts commit 6995728d6c3d957d269f1f3c71ff461687c37c81.

    * Update Entity_GetEntitiesByUniqueAttributes.json

    * Revert "Update query parameter for test"

    This reverts commit 21a6f72d4724ed9a15cf645f2a5990b5985ae70e.

    * Update purviewcatalog.json

    * remove additionalProperties for partial update

    * Update purviewcatalog.json

    * Update purviewcatalog.json

    * Update purviewcatalog.json

    * Update purviewcatalog.json

    * Update purviewcatalog.json

    * Update purviewcatalog.json

    * Update purviewcatalog.json

    * update from main branch

    * Update readme.md

    * update api contract according to suggestions

    * Update purviewcatalog.json

    * update examples

    * update description

    * Update purviewcatalog.json

    * Update purviewcatalog.json

    ---------

    Co-authored-by: Allen Liang <[email protected]>

commit 860d9538f338475d45db9921ea954e8562687bda
Author: shono <[email protected]>
Date:   Tue Mar 7 07:17:34 2023 -0800

    Unified Vision service 3/7 public preview release (#22950)

    * Copy PRs from azure-rest-api-specs-pr.

    * Merge VectorizeText and VectorizeImage APIs

    * Add 'vectorize' to custom-words.txt

    ---------

    Co-authored-by: shono <>

commit 4f97119261c5255091d75cf76a3da79c5954d7a4
Author: Lior Abadi <[email protected]>
Date:   Tue Mar 7 09:17:53 2023 +0200

    Storage Mover: Fix Projects Create Example (#22924)

    Co-authored-by: Lior Abadi <[email protected]>

commit fbfcfd2df9357735a95fc0aba82dd4577ffc1e63
Author: Peng Jiahui <[email protected]>
Date:   Tue Mar 7 14:59:38 2023 +0800

    [Go] config graphservicesprod readme.go.md (#22944)

commit 84261dbe443523e226f4f5ec55aee6175676715f
Author: Chenjie Shi <[email protected]>
Date:   Tue Mar 7 14:59:26 2023 +0800

    update metric version (#22939)

commit 902860572e43c439b2afa02c19dd0be3496ac32f
Author: YanjunGao <[email protected]>
Date:   Tue Mar 7 14:51:18 2023 +0800

    update synapse contact (#22842)

commit 90ee6ae3e12e7ed385f1de94a41fcd9e38361a57
Author: kazrael2119 <[email protected]>
Date:   Tue Mar 7 14:36:04 2023 +0800

    change loadtesting catalog (#22592)

commit dbdac79ee734ab29a7af19172be78126977d7c57
Author: Ray Chen <[email protected]>
Date:   Tue Mar 7 14:31:41 2023 +0800

    Update Semantic-and-Model-Violations-Reference.md (#22942)

    add example for LRO_RESPONSE_HEADER fix.

commit 01c8d56b7540cb3d87c83be5c1ca5f25674178ed
Author: Mohit Makhija <[email protected]>
Date:   Tue Mar 7 11:48:40 2023 +0530

    updated Resource ID in all example files for workload monitor (#22920)

    * updated Resoutce ID in all example files for workload monitor api versions

    * updated type for providers in examples Azure Monitor for SAP  for api-version 2021-12-01-preview

    * updated type for providers in examples Azure Monitor for SAP  for api-version 2022-11-01-preview

    * updated type for providers in examples Azure Monitor for SAP  for api-version 2023-14-01

    * updated type for monitor in examples Azure Monitor for SAP  for api-version 2021-12-01-preview

    * updated type for monitor in examples Azure Monitor for SAP  for api-version 2022-12-01-preview

    * updated type for monitor in examples Azure Monitor for SAP  for api-version 2023-04-01

commit d6e5649022cacc7f39dda6e152b34c7315e9bf8c
Author: profDisarray <[email protected]>
Date:   Tue Mar 7 11:09:12 2023 +0530

    Rp soft delete (#22260)

    * Adds base for updating Microsoft.RecoveryServices from version stable/2023-01-01 to version 2023-02-01

    * Updates readme

    * Updates API version in new specs and examples

    * Adds RP Soft delete related API changes

    * added ExtendedLocation to IaasVMRestoreRequest (#22468)

    * fixed lint error (#22483)

    * - adding changes for private endpoint support in get, list Rp and trigger restore.

    * -fixing data type

    * fixing validation errors

    * Added changed for Secured VM details and Security Type (#22848)

    ---------

    Co-authored-by: shesamian <[email protected]>
    Co-authored-by: Arpit Jain <[email protected]>
    Co-authored-by: Saksham Arora <[email protected]>

commit 2ac2c7d8cdd8ee5ceab9e05d91441e95eeb66910
Author: poshett <[email protected]>
Date:   Tue Mar 7 10:47:32 2023 +0530

    Adding version 2023-01-01-preview with User API Key changes for Elastic (#22638)

    * Base API Commit

    * Changing API version to 2023-02-01-preview

    * Adding new getOrganizationApiKey post API

    * Adding returnApiKey property in ElasticMonitorResource

    * Updating getOrganizationApiKey URI

    * Adding SubscriptionIdParameter in getOrganizationApiKey

    * Renaming ex to Organizations_GetApiKey

    * Updating description for UserApiKeyResponse

    * Updating examples

    * Updating readme.md

    * Updated Depolyment Info, added marketplace info

    * prettier check fixed

    * model validation fixed

    * validation fix

    * prettier fix

    * Increasing max length limit of companyName and business from 50 to 100

    * Increasing companyName and business max length limits to 100 in all versions

    * Revert "Increasing companyName and business max length limits to 100 in all versions"

    This reverts commit c8977b64daa962bce70d33a325053294a4875610.

    * Revert "Increasing max length limit of companyName and business from 50 to 100"

    This reverts commit 7bd354775b3a57abf310a351c75763bc1aa121f3.

    * Updating summary for getOrganizationApiKey

    * Renaming "returnApiKey" to "generateApiKey"

    * Adding "x-ms-secret": true for apiKey

    * Updating getOrganizationApiKey API to /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Elastic/monitors/{monitorName}/getOrganizationApiKey

    * Rearranging APIs

    * Adding "consumes" to getOrganizationApiKey

    * Changing case of emailId

    * Moving the API under paths

    * Updating User and Company related properties' max length limit to 64

    * Adding Location in response header of LROs

    * Updating getOrganizationApiKey path

    * Updating getOrganizationApiKey Summary

    ---------

    Co-authored-by: Rhea Hooda <[email protected]>

commit 3a8cbd5a6969b9ae809dd361504ef475bdeb68c5
Author: Ray Chen <[email protected]>
Date:   Tue Mar 7 12:20:48 2023 +0800

    Merge global package config (#22735)

    * Merge global package config

    * Added cadl-apiview package

commit 8af107b80ae16a7652d52ba879373b033b0e520d
Author: Wei Dong <[email protected]>
Date:   Tue Mar 7 12:18:08 2023 +0800

    update the doc of sdk automation pipeline (#22812)

    * update the doc of sdk automation pipeline

    * Update GenerateInputSchema.json

    * Update README.md

    * Update README.md

commit 149f607f45e76218f0fedff31388270ad1bb055a
Author: Ruoxuan Wang <[email protected]>
Date:   Tue Mar 7 12:06:57 2023 +0800

    Update pull_request_assignment.yml (#22817)

commit bbba66026d7a271c80c5cb4c9c0f92b8054133ba
Author: Yuchao Yan <[email protected]>
Date:   Tue Mar 7 11:51:09 2023 +0800

    Update readme.python.md (#22912)

commit f6d16956a7d5b75e125a88d81d7bc9b6fecfd41a
Author: gargankit-microsoft <[email protected]>
Date:   Tue Mar 7 06:48:42 2023 +0530

    removed locale (#22926)

commit c1bf995dbab472761ba4da53ed33c7b621ff8bd9
Author: JoshLove-msft <[email protected]>
Date:   Mon Mar 6 12:05:17 2023 -0800

    Add missing closing brace (#22935)

commit 8539fe23e90aff363869fd21321b775ce2ccca8b
Author: Dan Liu <[email protected]>
Date:   Tue Mar 7 01:28:27 2023 +0800

    Sync Gen2 sas auth swagger to synapse (#22713)

    * Sync Gen2 sas auth swagger to synapse

    * Updated akv reference

    ---------

    Co-authored-by: Dan Liu <[email protected]>

commit 9a59e9be953f01afd42cb7f0b2d18602f14c344a
Author: Osahumen Uyi Aghasomwan <[email protected]>
Date:   Mon Mar 6 09:09:16 2023 -0800

    Add email events to event grid (#22272)

    * adding Email event

    * adding Email event

    * adding Email event

    * fixing avocado failure

    * fixing avocado failure

    * fixing avocado failure

    * making update to the sample json

    * making update to the sample json

    * making update to the sample json

    * making update to the sample json

    * remove unnessary definitations

    * remove unnessary definitations

    * adding x-ms-client-name se we dont change property casing

commit af5e3ff90dac7d0b8ae8d319bb2c16ffcdcc2bd6
Author: eladschwartz <[email protected]>
Date:   Mon Mar 6 18:25:56 2023 +0200

    [CPX-Marketplace-Catalog] 2023-01-01-preview (#21476)

    * creating new public api version

    * fixing validator issues

    * fixing validator errors

    * fixing string format errors

    * fixing 404 in listing response

    * modifying nextPageLink

    * removing decimal from type description

    * Adding descriptions to product entities

    * removing a typo

    * fixing camel case description

    * description fixes

    * removing cspState typo

    * Updating name of returned catalog API entity

    * Removing count from listing example

    * removing unused query parameter

    * Adding required fields and descriptions

    * Making requested PR changes

    * Wrapping error responses in default return value

    * Removing explicit 400s from example responses

    * removing x-nullable and testing odata naming

    * adding more required fields

    * Updating the products file to contain correct definitions

    * Fixing listing example

    * Fixing example for singlePublic flow

    * Fixing validation issues

    * Adding more validation fixes

    * Fixing json reference in readme file

    * Changing additionalProperties to additionalProductProperties

    * Making some comment and description fixes

    * fixing spelling errors

    * fixing a small typo

    * Adding technical descriptions

    * Fixing typos

    * Adding whitespace to descriptions

    * Adding filterable fields examples

    * Adding more descriptions

    * Fixing some basic spelling errors

    * Adding backticks to orderby

    * Removing duplicates and fixing descriptions

    * Adding custom word

    * Fix filter description

    * changing in to is

    * Fixing second reviewer comments

    * make tests run again

    * reverting test word

    * Revert "Fixing second reviewer comments"

    This reverts commit 772d199a90094f46506ae6e0828a123856f9487e.

    * Adding csv collection type

    * Changing relevant OData types to array

    * Removing $ from descriptions

    * Fixing final PR comments

commit b0a96087a75bc286a7e2735f71872d63692c7baa
Author: singhabh27 <[email protected]>
Date:   Mon Mar 6 14:58:36 2023 +0530

    Review request for Microsoft.RecoveryServices to add version stable/2023-01-01 (#22076)

    * Adds base for updating Microsoft.RecoveryServices from version stable/2022-10-01 to version 2023-01-01

    * Updates readme

    * Updates API version in new specs and examples

    * CVM and OS Upgrade changes

    * Update ReplicationProtectionContainers_SwitchProtection.json

    Fixing swagger linting issue.

    * Update service.json

    Swagger correctness fix.

    * Updated supportedOSVersions description.

    * Taken up ARM feedback

    * model validation fix

    * Revert "model validation fix"

    This reverts commit 98310580f5e72f932e7144f11c486261da1d3ed1.

    * Fixing model validations

    * Fixing ReplicationFabrics_Purge.json

    * Fixing model validations

    * RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE fix

    * Adding Azure-AsyncOperation  in header

    * Fixing examples

    ---------

    Co-authored-by: Pradheep Myaka <[email protected]>

commit 241e964afe675a7be98aa6a2e171a3c5f830816c
Author: GalGoldi72 <[email protected]>
Date:   Mon Mar 6 09:52:09 2023 +0200

    [Hub Generated] Review request for Microsoft.Security to add version preview/2023-02-01-preview (#22797)

    * Adds base for updating Microsoft.Security from version preview/2020-07-01-preview to version 2023-02-01-preview

    * Updates readme

    * Updates API version in new specs and examples

    * Update new API version…
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    @AntonioHernandez16 @JoshLove-msft
    [Hub Generated] Review request for Microsoft.Consumption to add versi…
    dc3671d 
    …on stable/2022-09-01 (Azure#23054)

* Adds base for updating Microsoft.Consumption from version stable/2021-10-01 to version 2022-09-01

* Updates readme

* Updates API version in new specs and examples

* adding new API version (September Copper) to Swagger

* fixing prettier check
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @tadelesh tadelesh tadelesh approved these changes

    @kjeur kjeur Awaiting requested review from kjeur kjeur is a code owner

    Assignees

    @tadelesh tadelesh

    Labels
    Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure new-api-version resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @AntonioHernandez16 @tadelesh @raych1 @raosuhas @AzureRestAPISpecReview