Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Publish private branch 'dev/monica/ap' #24394

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

moadus
Copy link
Contributor

@moadus moadus commented Jun 12, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@moadus
Copy link
Contributor Author

moadus commented Jun 12, 2023

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12997

@openapi-workflow-bot
Copy link

Hi, @moadus Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 12, 2023

    Swagger Validation Report

    ️❌BreakingChange: 34 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    azurearcdata.json 2021-06-01-preview(fbc0af1) 2021-06-01-preview(main)
    azurearcdata.json 2021-07-01-preview(fbc0af1) 2021-07-01-preview(main)
    activeDirectoryConnectors.json 2022-03-01-preview(fbc0af1) 2022-03-01-preview(main)
    operations.json 2022-03-01-preview(fbc0af1) 2022-03-01-preview(main)
    sqlManagedInstances.json 2022-03-01-preview(fbc0af1) 2022-03-01-preview(main)
    activeDirectoryConnectors.json 2022-06-15-preview(fbc0af1) 2022-06-15-preview(main)
    operations.json 2022-06-15-preview(fbc0af1) 2022-06-15-preview(main)
    sqlManagedInstances.json 2022-06-15-preview(fbc0af1) 2022-06-15-preview(main)
    activeDirectoryConnectors.json 2023-01-15-preview(fbc0af1) 2023-01-15-preview(main)
    operations.json 2023-01-15-preview(fbc0af1) 2023-01-15-preview(main)
    sqlManagedInstances.json 2023-01-15-preview(fbc0af1) 2023-01-15-preview(main)
    azurearcdata.json 2021-08-01(fbc0af1) 2021-08-01(main)
    operations.json 2021-11-01(fbc0af1) 2021-11-01(main)
    sqlManagedInstances.json 2021-11-01(fbc0af1) 2021-11-01(main)

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1407:11
    Old: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1407:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1444:11
    Old: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1444:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-03-01-preview/activeDirectoryConnectors.json#L227:7
    Old: Microsoft.AzureArcData/preview/2022-03-01-preview/activeDirectoryConnectors.json#L227:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-03-01-preview/operations.json#L42:11
    Old: Microsoft.AzureArcData/preview/2022-03-01-preview/operations.json#L42:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L176:7
    Old: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L176:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L191:7
    Old: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L193:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L201:7
    Old: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L205:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L211:7
    Old: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L217:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L232:7
    Old: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L240:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-06-15-preview/activeDirectoryConnectors.json#L226:7
    Old: Microsoft.AzureArcData/preview/2022-06-15-preview/activeDirectoryConnectors.json#L226:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-06-15-preview/operations.json#L42:11
    Old: Microsoft.AzureArcData/preview/2022-06-15-preview/operations.json#L42:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-06-15-preview/sqlManagedInstances.json#L175:7
    Old: Microsoft.AzureArcData/preview/2022-06-15-preview/sqlManagedInstances.json#L175:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-06-15-preview/sqlManagedInstances.json#L190:7
    Old: Microsoft.AzureArcData/preview/2022-06-15-preview/sqlManagedInstances.json#L192:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-06-15-preview/sqlManagedInstances.json#L200:7
    Old: Microsoft.AzureArcData/preview/2022-06-15-preview/sqlManagedInstances.json#L204:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-06-15-preview/sqlManagedInstances.json#L210:7
    Old: Microsoft.AzureArcData/preview/2022-06-15-preview/sqlManagedInstances.json#L216:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2022-06-15-preview/sqlManagedInstances.json#L231:7
    Old: Microsoft.AzureArcData/preview/2022-06-15-preview/sqlManagedInstances.json#L239:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2023-01-15-preview/activeDirectoryConnectors.json#L226:7
    Old: Microsoft.AzureArcData/preview/2023-01-15-preview/activeDirectoryConnectors.json#L226:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2023-01-15-preview/operations.json#L42:11
    Old: Microsoft.AzureArcData/preview/2023-01-15-preview/operations.json#L42:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2023-01-15-preview/sqlManagedInstances.json#L196:7
    Old: Microsoft.AzureArcData/preview/2023-01-15-preview/sqlManagedInstances.json#L196:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2023-01-15-preview/sqlManagedInstances.json#L206:7
    Old: Microsoft.AzureArcData/preview/2023-01-15-preview/sqlManagedInstances.json#L208:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2023-01-15-preview/sqlManagedInstances.json#L216:7
    Old: Microsoft.AzureArcData/preview/2023-01-15-preview/sqlManagedInstances.json#L220:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/preview/2023-01-15-preview/sqlManagedInstances.json#L237:7
    Old: Microsoft.AzureArcData/preview/2023-01-15-preview/sqlManagedInstances.json#L243:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1125:11
    Old: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1125:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1862:7
    Old: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1864:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1877:7
    Old: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1881:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1887:7
    Old: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1893:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1897:7
    Old: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1905:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1918:7
    Old: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L1928:7
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/stable/2021-11-01/operations.json#L42:11
    Old: Microsoft.AzureArcData/stable/2021-11-01/operations.json#L42:11
    1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.AzureArcData/stable/2021-11-01/sqlManagedInstances.json#L164:7
    Old: Microsoft.AzureArcData/stable/2021-11-01/sqlManagedInstances.json#L164:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.3) new version base version
    package-2021-11-01 package-2021-11-01(fbc0af1) package-2021-11-01(main)
    package-2021-08-01 package-2021-08-01(fbc0af1) package-2021-08-01(main)
    package-preview-2021-07-01 package-preview-2021-07-01(fbc0af1) package-preview-2021-07-01(main)
    package-preview-2021-06-01 package-preview-2021-06-01(fbc0af1) package-preview-2021-06-01(main)
    package-preview-2022-03 package-preview-2022-03(fbc0af1) package-preview-2022-03(main)
    package-preview-2022-06 package-preview-2022-06(fbc0af1) package-preview-2022-06(main)
    package-preview-2023-01 package-preview-2023-01(fbc0af1) package-preview-2023-01(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1017
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1080
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1124
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1168
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1029
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1092
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1140
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1184
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L733
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L796
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L844
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'DataControllers' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L888
    ⚠️ PutInOperationName 'PUT' operation 'DataControllers_PutDataController' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1017
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1035
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1089
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1133
    ⚠️ PatchInOperationName 'PATCH' operation 'DataControllers_PatchDataController' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1168
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1177
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1228
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1400
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1446
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1514
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.AzureArcData/preview/2021-06-01-preview/azurearcdata.json#L1612
    ⚠️ PutInOperationName 'PUT' operation 'DataControllers_PutDataController' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1029
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1047
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1101
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1149
    ⚠️ PatchInOperationName 'PATCH' operation 'DataControllers_PatchDataController' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1184
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1193
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1244
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 7 Errors, 0 Warnings failed [Detail]
    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L272:22
    ExampleUrl: preview/2021-07-01-preview/examples/DeleteSqlManagedInstance.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L568:22
    ExampleUrl: preview/2021-07-01-preview/examples/DeleteSqlServerInstance.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L864:22
    ExampleUrl: preview/2021-07-01-preview/examples/DeletePostgresInstance.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.AzureArcData/preview/2021-07-01-preview/azurearcdata.json#L1112:22
    ExampleUrl: preview/2021-07-01-preview/examples/DeleteDataController.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L272:22
    ExampleUrl: stable/2021-08-01/examples/DeleteSqlManagedInstance.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L568:22
    ExampleUrl: stable/2021-08-01/examples/DeleteSqlServerInstance.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.AzureArcData/stable/2021-08-01/azurearcdata.json#L816:22
    ExampleUrl: stable/2021-08-01/examples/DeleteDataController.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 12, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking



    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1438570. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-azurearcdata [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group FailoverGroupsOperations
      info	[Changelog]   - Added operation group SqlServerDatabasesOperations
      info	[Changelog]   - Model SqlManagedInstanceK8SSpec has a new parameter security
      info	[Changelog]   - Model SqlManagedInstanceK8SSpec has a new parameter settings
      info	[Changelog]   - Model SqlServerInstanceProperties has a new parameter cores
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1438570. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-azurearcdata [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1438570. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/azurearcdata/armazurearcdata [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `ArcSQLServerLicenseTypeLicenseOnly`, `ArcSQLServerLicenseTypePAYG`, `ArcSQLServerLicenseTypeServerCAL` added to enum type `ArcSQLServerLicenseType`
      info	[Changelog] - New value `EditionTypeBusinessIntelligence` added to enum type `EditionType`
      info	[Changelog] - New value `HostTypeAWSKubernetesService`, `HostTypeAWSVMWareVirtualMachine`, `HostTypeAzureKubernetesService`, `HostTypeAzureVMWareVirtualMachine`, `HostTypeAzureVirtualMachine`, `HostTypeContainer`, `HostTypeGCPKubernetesService`, `HostTypeGCPVMWareVirtualMachine` added to enum type `HostType`
      info	[Changelog] - New enum type `DatabaseState` with values `DatabaseStateCopying`, `DatabaseStateEmergency`, `DatabaseStateOffline`, `DatabaseStateOfflineSecondary`, `DatabaseStateOnline`, `DatabaseStateRecovering`, `DatabaseStateRecoveryPending`, `DatabaseStateRestoring`, `DatabaseStateSuspect`
      info	[Changelog] - New enum type `FailoverGroupPartnerSyncMode` with values `FailoverGroupPartnerSyncModeAsync`, `FailoverGroupPartnerSyncModeSync`
      info	[Changelog] - New enum type `InstanceFailoverGroupRole` with values `InstanceFailoverGroupRoleForcePrimaryAllowDataLoss`, `InstanceFailoverGroupRoleForceSecondary`, `InstanceFailoverGroupRolePrimary`, `InstanceFailoverGroupRoleSecondary`
      info	[Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateAccepted`, `ProvisioningStateCanceled`, `ProvisioningStateFailed`, `ProvisioningStateSucceeded`
      info	[Changelog] - New enum type `RecoveryMode` with values `RecoveryModeBulkLogged`, `RecoveryModeFull`, `RecoveryModeSimple`
      info	[Changelog] - New function `*ClientFactory.NewFailoverGroupsClient() *FailoverGroupsClient`
      info	[Changelog] - New function `*ClientFactory.NewSQLServerDatabasesClient() *SQLServerDatabasesClient`
      info	[Changelog] - New function `NewFailoverGroupsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FailoverGroupsClient, error)`
      info	[Changelog] - New function `*FailoverGroupsClient.BeginCreate(context.Context, string, string, string, FailoverGroupResource, *FailoverGroupsClientBeginCreateOptions) (*runtime.Poller[FailoverGroupsClientCreateResponse], error)`
      info	[Changelog] - New function `*FailoverGroupsClient.BeginDelete(context.Context, string, string, string, *FailoverGroupsClientBeginDeleteOptions) (*runtime.Poller[FailoverGroupsClientDeleteResponse], error)`
      info	[Changelog] - New function `*FailoverGroupsClient.Get(context.Context, string, string, string, *FailoverGroupsClientGetOptions) (FailoverGroupsClientGetResponse, error)`
      info	[Changelog] - New function `*FailoverGroupsClient.NewListPager(string, string, *FailoverGroupsClientListOptions) *runtime.Pager[FailoverGroupsClientListResponse]`
      info	[Changelog] - New function `NewSQLServerDatabasesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SQLServerDatabasesClient, error)`
      info	[Changelog] - New function `*SQLServerDatabasesClient.Create(context.Context, string, string, string, SQLServerDatabaseResource, *SQLServerDatabasesClientCreateOptions) (SQLServerDatabasesClientCreateResponse, error)`
      info	[Changelog] - New function `*SQLServerDatabasesClient.Delete(context.Context, string, string, string, *SQLServerDatabasesClientDeleteOptions) (SQLServerDatabasesClientDeleteResponse, error)`
      info	[Changelog] - New function `*SQLServerDatabasesClient.Get(context.Context, string, string, string, *SQLServerDatabasesClientGetOptions) (SQLServerDatabasesClientGetResponse, error)`
      info	[Changelog] - New function `*SQLServerDatabasesClient.NewListPager(string, string, *SQLServerDatabasesClientListOptions) *runtime.Pager[SQLServerDatabasesClientListResponse]`
      info	[Changelog] - New function `*SQLServerDatabasesClient.Update(context.Context, string, string, string, SQLServerDatabaseUpdate, *SQLServerDatabasesClientUpdateOptions) (SQLServerDatabasesClientUpdateResponse, error)`
      info	[Changelog] - New struct `ArcSQLServerDatabaseListResult`
      info	[Changelog] - New struct `FailoverGroupListResult`
      info	[Changelog] - New struct `FailoverGroupProperties`
      info	[Changelog] - New struct `FailoverGroupResource`
      info	[Changelog] - New struct `FailoverGroupSpec`
      info	[Changelog] - New struct `K8SActiveDirectory`
      info	[Changelog] - New struct `K8SActiveDirectoryConnector`
      info	[Changelog] - New struct `K8SNetworkSettings`
      info	[Changelog] - New struct `K8SSecurity`
      info	[Changelog] - New struct `K8SSettings`
      info	[Changelog] - New struct `K8StransparentDataEncryption`
      info	[Changelog] - New struct `SQLServerDatabaseResource`
      info	[Changelog] - New struct `SQLServerDatabaseResourceProperties`
      info	[Changelog] - New struct `SQLServerDatabaseResourcePropertiesBackupInformation`
      info	[Changelog] - New struct `SQLServerDatabaseResourcePropertiesDatabaseOptions`
      info	[Changelog] - New struct `SQLServerDatabaseUpdate`
      info	[Changelog] - New field `Security`, `Settings` in struct `SQLManagedInstanceK8SSpec`
      info	[Changelog] - New field `Cores` in struct `SQLServerInstanceProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 86 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1438570. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-azurearcdata [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1438570. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/azurearcdata/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.AzureArcData [View full logs]  [Release SDK Changes]
      warn	Skip artifact folder because it doesn't exist: artifacts/packages
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1438570. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️azurearcdata [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 1438570. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.azurearcdata.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.azurearcdata.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 12, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/azurearcdata/armazurearcdata https://apiview.dev/Assemblies/Review/51f8953678b847538e1870450a429503
    Java azure-resourcemanager-azurearcdata https://apiview.dev/Assemblies/Review/9081778c33e5463292f2a2b65bde64d7
    JavaScript @azure/arm-azurearcdata https://apiview.dev/Assemblies/Review/60b30e5df83a463487900a61d1fa477a

    @openapi-workflow-bot
    Copy link

    Hi @moadus, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @moadus, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @moadus
    Copy link
    Contributor Author

    moadus commented Jun 12, 2023

    . If the PR is flagged for breaking change, let the reviewer know it's to comply with the additionalProperties validation.
    https://portal.microsofticm.com/imp/v3/incidents/details/395439420/home

    the model validation failures that are being reported are already GA'ed and these are the very old versions of the API. Hence, we request for an exception on model validation changes and request you to approve the PR.

    This has been approved in https://github.com/Azure/azure-rest-api-specs-pr/pull/12997

    @JackTn
    Copy link
    Member

    JackTn commented Jun 12, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @JackTn
    Copy link
    Member

    JackTn commented Jun 12, 2023

    . If the PR is flagged for breaking change, let the reviewer know it's to comply with the additionalProperties validation. https://portal.microsofticm.com/imp/v3/incidents/details/395439420/home

    the model validation failures that are being reported are already GA'ed and these are the very old versions of the API. Hence, we request for an exception on model validation changes and request you to approve the PR.

    This has been approved in Azure/azure-rest-api-specs-pr#12997

    The breaking change and model validation errors has been approved before.

    @JackTn JackTn added Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation and removed Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates labels Jun 12, 2023
    @JackTn
    Copy link
    Member

    JackTn commented Jun 12, 2023

    @msyyc take a look on this pr and help to merge it , Thanks
    image

    @moadus inform you

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager RPaaS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants