Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge csharp feature branch into main ai inference branch #29763
base: dargilco/ai-model-inference
Are you sure you want to change the base?
Merge csharp feature branch into main ai inference branch #29763
Changes from 20 commits
51fb73b
fd54bf9
c53ca69
08c7c64
ab6c309
4f8a7ea
be84fda
4f56fb3
db6580b
a5b3fbc
234a992
1c552f3
8e420b9
420cdf6
8c122c5
e6e24a1
c33085f
bc2ead4
cea8c46
e5f72fe
69c429f
9353cd8
404726c
440f104
acd2c9a
7e90c46
6525a08
c625ccb
b3ff7cf
3cad35a
4d8fe2c
442e62e
eba14da
4a3dfd2
392243f
156d4e0
72ff5d0
063b051
dd47e68
1f62242
7254471
d752df6
4039eb1
33fb66c
d2d069e
7b1e6e1
65239b3
323366c
1562993
bd9d308
7e3d4fd
9b2fbf0
376a388
b2d19d3
56e81a8
b1d22e9
fb263d7
2ef0546
aa97e50
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be limited to C# only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see "Krzysztof Cwalina" [email protected] is OOF until 7/22... he was asking why we are not generating the protocol methods. I asked if they are needed by all SDKs, and why. I don't think he answered that question (perhaps he left for vacation before he could answer). But anyway, this is where we would enable them. Okay to leave it "false" for now.