-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge csharp feature branch into main ai inference branch #29763
base: dargilco/ai-model-inference
Are you sure you want to change the base?
Merge csharp feature branch into main ai inference branch #29763
Conversation
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
…nto trangevi/ai-model-inference
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.12) | new version | base version |
---|---|---|
Face.json | v1.1-preview.1(404726c) | v1.1-preview.1(main) |
assistants_generated.json | 2024-02-15-preview(404726c) | 2024-02-15-preview(main) |
assistants_generated.json | 2024-05-01-preview(404726c) | 2024-05-01-preview(main) |
botservice.json | 2023-09-15-preview(404726c) | 2023-09-15-preview(main) |
generated.json | 2023-06-01-preview(404726c) | 2023-06-01-preview(main) |
generated.json | 2023-07-01-preview(404726c) | 2023-07-01-preview(main) |
generated.json | 2024-02-15-preview(404726c) | 2024-02-15-preview(main) |
generated.json | 2024-03-01-preview(404726c) | 2024-03-01-preview(main) |
generated.json | 2024-04-01-preview(404726c) | 2024-04-01-preview(main) |
generated.json | 2024-05-01-preview(404726c) | 2024-05-01-preview(main) |
generated.json | 2023-05-15(404726c) | 2023-05-15(main) |
communicationservicescallautomation.json | 2024-06-15-preview(404726c) | 2024-06-15-preview(main) |
communicationservicesmessages.json | 2024-02-01(404726c) | 2024-02-01(main) |
AzureCommunicationServices.json | 2018-01-01(404726c) | 2018-01-01(main) |
SystemEvents.json | 2024-01-01(404726c) | 2024-01-01(main) |
fabric.json | 2023-11-01(404726c) | 2023-11-01(main) |
loadtestservice.json | 2024-05-01-preview(404726c) | 2024-05-01-preview(main) |
mfe.json | 2024-04-01(404726c) | 2024-04-01(main) |
powerbidedicated.json | 2017-10-01(404726c) | 2017-10-01(main) |
purviewdatamap.json | 2023-09-01(404726c) | 2023-09-01(main) |
easm.json | 2023-03-01-preview(404726c) | 2023-03-01-preview(main) |
easm.json | 2024-03-01-preview(404726c) | 2024-03-01-preview(main) |
searchindex.json | 2024-03-01-Preview(404726c) | 2024-03-01-Preview(main) |
openapi.json | 2024-05-01(404726c) | 2024-05-01(main) |
managedClusters.json | 2024-05-01(404726c) | 2024-05-01(main) |
guestconfiguration.json | 2024-04-05(404726c) | 2024-04-05(main) |
Qumulo.Storage.json | 2024-06-19(404726c) | 2024-06-19(main) |
openapi.json | 2024-06-01-preview(404726c) | 2024-06-01-preview(main) |
openapi.json | 2024-06-01(404726c) | 2024-06-01(main) |
privatedns.json | 2024-06-01(404726c) | 2024-06-01(main) |
changes.json | 2024-06-01-preview(404726c) | 2024-06-01-preview(main) |
AuthorizationRules.json | 2023-01-01-preview(404726c) | 2023-01-01-preview(main) |
CheckNameAvailability.json | 2023-01-01-preview(404726c) | 2023-01-01-preview(main) |
DisasterRecoveryConfig.json | 2023-01-01-preview(404726c) | 2023-01-01-preview(main) |
Queue.json | 2023-01-01-preview(404726c) | 2023-01-01-preview(main) |
Rules.json | 2023-01-01-preview(404726c) | 2023-01-01-preview(main) |
migrationconfigs.json | 2023-01-01-preview(404726c) | 2023-01-01-preview(main) |
namespace-preview.json | 2023-01-01-preview(404726c) | 2023-01-01-preview(main) |
networksets.json | 2023-01-01-preview(404726c) | 2023-01-01-preview(main) |
operations.json | 2023-01-01-preview(404726c) | 2023-01-01-preview(main) |
subscriptions.json | 2023-01-01-preview(404726c) | 2023-01-01-preview(main) |
topics.json | 2023-01-01-preview(404726c) | 2023-01-01-preview(main) |
Only 25 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L37:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L73:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L113:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L152:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L194:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L236:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L287:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L332:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L380:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L425:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L698:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L746:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L915:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L975:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L1020:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L1228:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L1273:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L1316:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L1378:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L1441:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L1494:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L1551:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L1602:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L1655:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: aks/stable/2024-05-01/managedClusters.json#L1708:5 |
Only 25 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L94:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L130:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L169:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L208:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L247:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L289:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L336:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L378:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L425:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L467:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L514:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L556:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L603:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L645:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L694:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L736:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L783:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L825:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L872:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L917:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L967:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L1006:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L1212:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L1269:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Oracle.Database/preview/2024-06-01-preview/openapi.json#L1323:5 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️🔄
LintDiff inProgress [Detail]
️❌
Avocado: 9 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.ContainerService/containerServices is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: resource-manager/Microsoft.ContainerService/aks/readme.md json: aks/stable/2017-07-01/containerService.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerService/containerServices/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: resource-manager/Microsoft.ContainerService/aks/readme.md json: aks/stable/2017-07-01/containerService.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerService/containerServices is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: resource-manager/Microsoft.ContainerService/aks/readme.md json: aks/stable/2017-07-01/containerService.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerService/managedClusters/{}/accessProfiles/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: resource-manager/Microsoft.ContainerService/aks/readme.md json: aks/stable/2017-08-31/managedClusters.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.ContainerService/locations/{}/orchestrators is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: resource-manager/Microsoft.ContainerService/aks/readme.md json: aks/stable/2019-08-01/location.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.ContainerService/openShiftManagedClusters is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: resource-manager/Microsoft.ContainerService/aks/readme.md json: aks/stable/2019-04-30/openShiftManagedClusters.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerService/openShiftManagedClusters is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: resource-manager/Microsoft.ContainerService/aks/readme.md json: aks/stable/2019-04-30/openShiftManagedClusters.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerService/openShiftManagedClusters/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: resource-manager/Microsoft.ContainerService/aks/readme.md json: aks/stable/2019-04-30/openShiftManagedClusters.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.ContainerService/locations/{}/osOptions/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: resource-manager/Microsoft.ContainerService/aks/readme.md json: aks/stable/2024-02-01/managedClusters.json |
️❌
SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 6 Errors, 0 Warnings failed [Detail]
️❌
SemanticValidation: 8 Errors, 0 Warnings failed [Detail]
️❌
SpellCheck: 7 Errors, 0 Warnings failed [Detail]
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
`model`?: string; | ||
}; | ||
|
||
...Record<unknown>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be limited to C# only?
namespace: "Azure.AI.Inference" | ||
clear-output-folder: true | ||
model-namespace: false | ||
generate-protocol-methods: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see "Krzysztof Cwalina" [email protected] is OOF until 7/22... he was asking why we are not generating the protocol methods. I asked if they are needed by all SDKs, and why. I don't think he answered that question (perhaps he left for vacation before he could answer). But anyway, this is where we would enable them. Okay to leave it "false" for now.
Signed-off-by: Travis Angevine <[email protected]>
1091b35
to
7b1e6e1
Compare
Signed-off-by: Travis Angevine <[email protected]>
937b6f0
to
65239b3
Compare
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
953d8e7
to
7e3d4fd
Compare
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
Signed-off-by: Travis Angevine <[email protected]>
6dd2ef6
to
2ef0546
Compare
Signed-off-by: Travis Angevine <[email protected]>
fae2563
to
aa97e50
Compare
Hi, @trangevi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.