-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppConfiguration 2024-06-01-preview #29824
base: main
Are you sure you want to change the base?
AppConfiguration 2024-06-01-preview #29824
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Generated ApiView
|
...resource-manager/Microsoft.AppConfiguration/preview/2024-09-01-preview/appconfiguration.json
Outdated
Show resolved
Hide resolved
...resource-manager/Microsoft.AppConfiguration/preview/2024-09-01-preview/appconfiguration.json
Outdated
Show resolved
Hide resolved
...resource-manager/Microsoft.AppConfiguration/preview/2024-09-01-preview/appconfiguration.json
Outdated
Show resolved
Hide resolved
consider using a discrminator to selectively create this object based on if it is KV \ snapshot etc. https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-discriminator-value #Resolved Refers to: specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/preview/2024-09-01-preview/appconfiguration.json:2094 in 9564a31. [](commit_id = 9564a31, deletion_comment = False) |
@hahahahahaiyiwen Some comments are still active, please address/resolve/close them as required. |
@ms-bogdan-rotaru comments all addressed. |
@hahahahahaiyiwen Please merge with base branch before requesting merge, currently the branch is out-of-date. |
…-api-specs into appconfig/Add2024-09-01-preview
...resource-manager/Microsoft.AppConfiguration/preview/2024-09-01-preview/appconfiguration.json
Outdated
Show resolved
Hide resolved
...resource-manager/Microsoft.AppConfiguration/preview/2024-09-01-preview/appconfiguration.json
Outdated
Show resolved
Hide resolved
...resource-manager/Microsoft.AppConfiguration/preview/2024-09-01-preview/appconfiguration.json
Outdated
Show resolved
Hide resolved
…to delete 202 response
...resource-manager/Microsoft.AppConfiguration/preview/2024-06-01-preview/appconfiguration.json
Outdated
Show resolved
Hide resolved
Hi, @hahahahahaiyiwen. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.