Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for more media message types #30346

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Add support for more media message types #30346

wants to merge 36 commits into from

Conversation

glorialimicrosoft
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 28, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for Python (label: BreakingChange-Python-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 28, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
JavaScript @azure-rest/communication-messages https://apiview.dev/Assemblies/Review/17216b4144934c31be61a27fc66f03b8?revisionId=d8affffa1ca74959949c504b480c3958
Java azure-communication-messages https://apiview.dev/Assemblies/Review/6562e5ee918f497cba32cbf009b4de95?revisionId=f7cf792e41e644f78732e4cd6f78b547
Python azure-communication-messages https://apiview.dev/Assemblies/Review/dcc08feaa2b148c6ac15554c6fe62f26?revisionId=6ecd430df6f5415aad17f81b0477f57b
Swagger Messages https://apiview.dev/Assemblies/Review/887848db6186426d86e411f58d789870?revisionId=e228511c42cc4f9abb4dcb979c63c173
TypeSpec Communication.Messages https://apiview.dev/Assemblies/Review/6a99d57cab7e453790383860e6565a69?revisionId=c5a67eae8aa14ad2b0ce42a3543e7522

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane TypeSpec Authored with TypeSpec labels Aug 28, 2024
This was referenced Aug 28, 2024
Draft
Draft
Draft
Draft
@glorialimicrosoft glorialimicrosoft marked this pull request as ready for review August 28, 2024 21:31
@glorialimicrosoft glorialimicrosoft requested a review from a team as a code owner August 28, 2024 21:31
@glorialimicrosoft glorialimicrosoft requested review from scgbear and marclerwick and removed request for a team August 28, 2024 21:31
@JeffreyRichter JeffreyRichter added BreakingChange-Approved-UserImpact Changes are not backward compatible and may cause customer disruption. APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. labels Aug 29, 2024
@glorialimicrosoft glorialimicrosoft added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Aug 29, 2024
@glorialimicrosoft glorialimicrosoft force-pushed the gelli/addSupportForMoreMediaMessageTypes branch from 75958fe to 3aa0658 Compare August 29, 2024 21:12
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Sep 23, 2024
@glorialimicrosoft
use image_v0, use caption as a client name for content, add #deprecat…
d6064de 
…ed directive on top of `MediaNotificationContent`

use image_v0 as the legacy image type for `MediaNotificationContent` which is being deprecated
use caption as a client name for content for media messages for Versions.c2024_08_30 and onwards
add #deprecated directive on top of `MediaNotificationContent`
@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Sep 27, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview removed BreakingChange-Approved-UserImpact Changes are not backward compatible and may cause customer disruption. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

@scgbear scgbear Awaiting requested review from scgbear scgbear is a code owner automatically assigned from Azure/api-stewardship-board

@marclerwick marclerwick Awaiting requested review from marclerwick marclerwick is a code owner automatically assigned from Azure/api-stewardship-board

Assignees
No one assigned
Labels
APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. BreakingChange-Python-Sdk data-plane new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glorialimicrosoft @JeffreyRichter @azure-sdk @AzureRestAPISpecReview