Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPAM, VNV, update Security Admin and Vnet specs #30560

Conversation

sssharma24
Copy link
Member

@sssharma24 sssharma24 commented Sep 13, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Sep 13, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Sep 13, 2024

@sssharma24
Copy link
Member Author

All the changes are from these 2 PRs which have been reviewed and approved by ARM reviewer:
https://github.com/Azure/azure-rest-api-specs-pr/pull/19000
https://github.com/Azure/azure-rest-api-specs-pr/pull/18922

@sssharma24 sssharma24 marked this pull request as ready for review September 16, 2024 20:49
@sssharma24 sssharma24 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2024
@qiaozha
Copy link
Member

qiaozha commented Sep 24, 2024

@tadelesh could help on the Go SDK breaking change.

@tadelesh
Copy link
Member

in this pr, some base resource refs have been changed which cause go sdk breaking. @sssharma24 did you get approval from breaking change review board?

@tadelesh tadelesh added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Sep 24, 2024
@sssharma24
Copy link
Member Author

@tadelesh the sdk go check actually passed and these changes have already been approved for preview versions as well. this is mostly just merging it to the stable

@tadelesh
Copy link
Member

could you

All the changes are from these 2 PRs which have been reviewed and approved by ARM reviewer: Azure/azure-rest-api-specs-pr#19000 Azure/azure-rest-api-specs-pr#18922

actually, i did not see the breaking change review in the private pr

@sssharma24
Copy link
Member Author

sssharma24 commented Sep 27, 2024

could you

All the changes are from these 2 PRs which have been reviewed and approved by ARM reviewer: Azure/azure-rest-api-specs-pr#19000 Azure/azure-rest-api-specs-pr#18922

actually, i did not see the breaking change review in the private pr

this is the main PR in priv repo with most changes and the breaking change benign tag #29998

@tadelesh
Copy link
Member

could you

All the changes are from these 2 PRs which have been reviewed and approved by ARM reviewer: Azure/azure-rest-api-specs-pr#19000 Azure/azure-rest-api-specs-pr#18922

actually, i did not see the breaking change review in the private pr

this is the main PR in priv repo with most changes and the breaking change benign tag #29998

thanks for the info, i approved go breaking changes.

@AzureRestAPISpecReview AzureRestAPISpecReview added SuppressionReviewRequired and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Sep 27, 2024
@sssharma24 sssharma24 merged commit 59bd02e into Azure:kamboj-prjwl/release-network-Microsoft.Network-2024-05-01 Sep 27, 2024
21 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants