Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new preview version for container instances #30879

Conversation

dobrebogdan
Copy link
Contributor

Creating a new preview api version with a new property "identityAcls" and related classes for container instances.

Copy link

openapi-pipeline-app bot commented Oct 7, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

Copy link

openapi-pipeline-app bot commented Oct 7, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/containerinstance/armcontainerinstance https://apiview.dev/Assemblies/Review/94480d0264ec4820b781f6275cf6a7a8?revisionId=5da9a8f2cabd4f6cb363ff40477f0002
Java azure-resourcemanager-containerinstance-generated https://apiview.dev/Assemblies/Review/e709fb4537c54c90a1f2c1e18ba101ab?revisionId=c027f225f2d84095b7148b9f40998d06
JavaScript @azure/arm-containerinstance https://apiview.dev/Assemblies/Review/ad27d08d33da42e195cb6b43c7dc4b68?revisionId=4bc0d0f7bdd64499a78a874472a0fc99
.Net Azure.ResourceManager.ContainerInstance There is no API change compared with the previous version
Swagger Microsoft.ContainerInstance https://apiview.dev/Assemblies/Review/57ed6af1fd4140b5b89c9b62c962949f?revisionId=2931d4443d954022949e49d7f5be8543

@dobrebogdan
Copy link
Contributor Author

Not using the latest api version as default due to some missing API paths compared to 2024-05 that trigger this error for the Avocado check: MISSING_APIS_IN_DEFAULT_TAG

@raosuhas raosuhas added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 9, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview Container Instances new-api-version resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants