Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CosmosDB RP API 2024-11-15 Version #31010

Merged
merged 19 commits into from
Nov 11, 2024
Merged

CosmosDB RP API 2024-11-15 Version #31010

merged 19 commits into from
Nov 11, 2024

Conversation

pjohari-ms
Copy link
Member

@pjohari-ms pjohari-ms commented Oct 14, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-08-15 to stable/2024-11-15.
Copy link

openapi-pipeline-app bot commented Oct 14, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 17, 2024
@ramoka178
Copy link
Contributor

    "enablePerRegionPerPartitionAutoscale": {

Standard guidance is: replace boolean/switch properties with a more meaningful enum whenever possible.

A boolean will forever have two valid values (true or false). A string enum type is always preferred. Also, properties should always provide better values just than True and False. For example two switches "isTypeA" and "isTypeB" should be replaced with one enum "type": [A, B, DefaultType]. Enums are always a more flexible and future proof option because they allow additional values to be added in the future in a non-breaking way, e.g. [Enabled, Disabled, Suspended, Deallocated].

Note: do NOT define a 'boolean enum' with two values 'True and False'. This might be easier to 'extend' in terms of types, but semantically its cofusing, and no better than a boolean.


Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2024-11-15/cosmos-db.json:7041 in 9bbe7c6. [](commit_id = 9bbe7c6, deletion_comment = False)

@ramoka178
Copy link
Contributor

    "enablePerRegionPerPartitionAutoscale": {

Please use enum as suggested in other comment


Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2024-11-15/cosmos-db.json:7203 in 9bbe7c6. [](commit_id = 9bbe7c6, deletion_comment = False)

@ramoka178
Copy link
Contributor

    "enablePerRegionPerPartitionAutoscale": {

Please use enum as suggested in other comment


Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2024-11-15/cosmos-db.json:7389 in 9bbe7c6. [](commit_id = 9bbe7c6, deletion_comment = False)

@ramoka178
Copy link
Contributor

Please fix Swagger PrettierCheck failure too.

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 22, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 22, 2024
@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 25, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 25, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 4, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 4, 2024
@raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 6, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 6, 2024
@JeffreyRichter JeffreyRichter added the BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. label Nov 6, 2024
@mikekistler mikekistler removed the BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. label Nov 6, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview removed the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 7, 2024
@mikekistler mikekistler added the BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. label Nov 8, 2024
…orEmbedding Policy to Container (#31476)

* adding specs for vector index

* fixing case mismatch

* review changes
@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Nov 8, 2024
@raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 8, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 8, 2024
@pjohari-ms
Copy link
Member Author

@raosuhas I have fixed all issues - the avocado check is failing because of APIs not present in an old API version. Is it possible to add a permanent suppression for this?

@pjohari-ms pjohari-ms added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Nov 8, 2024
@pjohari-ms pjohari-ms merged commit b4cbfe1 into main Nov 11, 2024
28 of 31 checks passed
@pjohari-ms pjohari-ms deleted the cosmosdb-20241115stable branch November 11, 2024 17:58
mikeharder pushed a commit to mikeharder/azure-rest-api-specs that referenced this pull request Nov 13, 2024
* Copy files from stable/2024-08-15

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-11-15

Updated the API version from stable/2024-08-15 to stable/2024-11-15.

* Added tag for 2024-11-15 in readme file

* Stable RP changes for PerRegionPerPartitionAutoscale (Azure#31030)

Co-authored-by: Shorya Kumar <[email protected]>

* Prettier fix

* Breaking change - sync with the newest ManagedCassandra changes introduced in preview versioning of the APIs

* Model validation + Notebook error versioning

* Reverted preview changes

* Fix issues related to notebook APIs

* Revert "Fix issues related to notebook APIs"

This reverts commit 7a52db4.

* Reverting changes to notebook.json

* [CosmosDB][2024-11-15] Vector Indexing - Added VectorIndexing and VectorEmbedding Policy to Container (Azure#31459)

* adding specs for vector index

* fixing case mismatch

* Ran Prettier after latest changes

* Added word to cSpell.json

* CosmosDB][2024-11-15] Vector Indexing - Added VectorIndexing and VectorEmbedding Policy to Container (Azure#31476)

* adding specs for vector index

* fixing case mismatch

* review changes

* Prettier again

---------

Co-authored-by: shorya-2719 <[email protected]>
Co-authored-by: Shorya Kumar <[email protected]>
Co-authored-by: vipulvishal-ms <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Cosmos new-api-version PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants