-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CosmosDB RP API 2024-11-15 Version #31010
Conversation
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-08-15 to stable/2024-11-15.
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
Co-authored-by: Shorya Kumar <[email protected]>
Standard guidance is: replace boolean/switch properties with a more meaningful enum whenever possible. A boolean will forever have two valid values (true or false). A string enum type is always preferred. Also, properties should always provide better values just than True and False. For example two switches "isTypeA" and "isTypeB" should be replaced with one enum "type": [A, B, DefaultType]. Enums are always a more flexible and future proof option because they allow additional values to be added in the future in a non-breaking way, e.g. [Enabled, Disabled, Suspended, Deallocated]. Note: do NOT define a 'boolean enum' with two values 'True and False'. This might be easier to 'extend' in terms of types, but semantically its cofusing, and no better than a boolean. Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2024-11-15/cosmos-db.json:7041 in 9bbe7c6. [](commit_id = 9bbe7c6, deletion_comment = False) |
specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2024-11-15/notebook.json
Show resolved
Hide resolved
Please fix Swagger PrettierCheck failure too. |
…orEmbedding Policy to Container (#31476) * adding specs for vector index * fixing case mismatch * review changes
@raosuhas I have fixed all issues - the avocado check is failing because of APIs not present in an old API version. Is it possible to add a permanent suppression for this? |
* Copy files from stable/2024-08-15 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-11-15 Updated the API version from stable/2024-08-15 to stable/2024-11-15. * Added tag for 2024-11-15 in readme file * Stable RP changes for PerRegionPerPartitionAutoscale (Azure#31030) Co-authored-by: Shorya Kumar <[email protected]> * Prettier fix * Breaking change - sync with the newest ManagedCassandra changes introduced in preview versioning of the APIs * Model validation + Notebook error versioning * Reverted preview changes * Fix issues related to notebook APIs * Revert "Fix issues related to notebook APIs" This reverts commit 7a52db4. * Reverting changes to notebook.json * [CosmosDB][2024-11-15] Vector Indexing - Added VectorIndexing and VectorEmbedding Policy to Container (Azure#31459) * adding specs for vector index * fixing case mismatch * Ran Prettier after latest changes * Added word to cSpell.json * CosmosDB][2024-11-15] Vector Indexing - Added VectorIndexing and VectorEmbedding Policy to Container (Azure#31476) * adding specs for vector index * fixing case mismatch * review changes * Prettier again --------- Co-authored-by: shorya-2719 <[email protected]> Co-authored-by: Shorya Kumar <[email protected]> Co-authored-by: vipulvishal-ms <[email protected]>
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.