[Defender (RiskIQ) - EASM] Api version 2024-10-01-preview #31045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashaspencer
requested review from
DominikMe and
marclerwick
and removed request for
a team
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
dashaspencer
changed the title
This was referenced Oct 16, 2024
added 7 commits
October 23, 2024 16:20
…ons to the client file, removing unused params from models, adjusting which fields are optional, adding RFC3339 to the dates, adding learning doc link to the ActionParameters.
AzureRestAPISpecReview
added
the
VersioningReviewRequired
added 8 commits
October 24, 2024 13:18
AzureRestAPISpecReview
removed
the
VersioningReviewRequired
mikekistler
approved these changes
Oct 25, 2024
mikekistler
added
the
APIStewardshipBoard-SignedOff
dashaspencer
added
the
PublishToCustomers
…-preview' into riskiq/Microsoft.Easm/2024-10-01-preview
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Oct 29, 2024
* Adding a new version * Fix double quote typo * Fix versioning copy/paste error * Adding missing versions. * Update client version. * Adding the generated json file. * Small syntax fixes. * Add override words for the new version as well * Fix pretty syntax. * Update readme * This might be ore correct * Fix response * Update the other one as well. * Fix policyName * Fix policyName in these as well * Let's see if this generalization works as well. * First round of addressing review feedback: moving clientName annotations to the client file, removing unused params from models, adjusting which fields are optional, adding RFC3339 to the dates, adding learning doc link to the ActionParameters. * Adjusting examples * More adjustments for wave 1 fixes. * More cleanup * Use the same object for policy put request and response. * Update the docs for the id. * Replace the rest of the models. * Set name to read and create * Trying to fix the swagger errors for DC endpoints * More adjustments for the name * Adjust validate endpoints to work with the same PUT model * Update other json files as well * Update other json files as well * Update other json files as well * Let's keep things simple. * Let's Try to force a build. --------- Co-authored-by: dashaspencer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
-- Remediation workflow: https://microsoft.sharepoint.com/:w:/t/RiskIQ-Product/EWgb3SvIrvpFiZqwxATEwgwB59J0ecBFaJjbo1L6bUF1RQ?e=5eFDf3
-- Policy Engine: https://microsoft.sharepoint.com/:w:/t/RiskIQ-Product/ESpesjHXSVxMrFdJN8_rEoMBPWmjGMRCFQ02gBBRMImY1g?e=AuoYGr
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.