[Microsoft.app] Release app microsoft.app 2024 10 02 preview

[jijohn14]

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

• New resource provider.
• New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
• Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
• Update existing version to fix OpenAPI spec quality issues in S360.
• Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
• Other, please clarify:
  • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

• I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
• I have reviewed following Resource Provider guidelines, including
  ARM resource provider contract and
  REST guidelines (estimated time: 4 hours).
  I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

• First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
• If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
• To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
• For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
  and https://aka.ms/ci-fix.
• For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
• If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
  This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
• If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

[Juliehzl]

The first commit needs to be an exact copy of the previous API version. All new changes should only be added in the subsequent commits. This allows the reviewer to get a clear understanding of the actual changes being introduced. With the way the PR is raised now, it is not possible for the reviewer to tell what the changes are. Please either abandon the PR and raise another one with the recommendation or create a new set of commits on this PR following the recommendation. If you are doing the later option please indicate which commit is the exact copy of the previous version.

@razvanbadea-msft Here is the first commit id bf061fc8170fc38a9a5a967dd1a0792ae8cf9678 which is a copy of previous api version. If you look at code change in our RP Microsoft.App only, you can see all new changes are added in subsequent commits https://github.com/Azure/azure-rest-api-specs/commits/release-app-Microsoft.App-2024-10-02-preview/specification/app/resource-manager starting from bf061fc. In the root folder, you can see many commits which is not related to Microsoft.App because @jijohn14 did a rebase to main branch which introduce the unexpected commits.

Our PR is open for long time and we are urgent to merge for Ignite. Can you help review with commits https://github.com/Azure/azure-rest-api-specs/commits/release-app-Microsoft.App-2024-10-02-preview/specification/app/resource-manager starting from bf061fc in Microsoft.App folder only? Thanks a lot. Sorry for inconvenience.

[Juliehzl]

@razvanbadea-msft Thanks for reviewing. Actually all changes are reviewed by ARM team previous with separate PRs to the feature branch release-app-Microsoft.App-2024-10-02-preview.

[razvanbadea-msft]

  Session Pool is using componentType as the discriminator. While the discriminator is a required property, this rule prevent it being present in the patch request body.

In the session pool the patch is using SessionPoolUpdatableProperties, is this suppression really needed? I do not see a discriminator used in this case

---

Refers to: specification/app/resource-manager/readme.md:86 in 8575f62. [](commit_id = 8575f62, deletion_comment = False)

[HAKIMBIBI67A]

ALI MUHAMMAD IHSAN

[azure-sdk]

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.App

[najian]

@razvanbadea-msft from PR add ManagedIdentitySettings to session pool 2024-10-02-preview by najian · Pull Request #30771 · Azure/azure-rest-api-specs (github.com)
ARM reviewer rkmanda commented on Oct 5 suggest "For the patch... rule that is breaking please add a suppression.."

  Session Pool is using componentType as the discriminator. While the discriminator is a required property, this rule prevent it being present in the patch request body.

In the session pool the patch is using SessionPoolUpdatableProperties, is this suppression really needed? I do not see a discriminator used in this case

Refers to: specification/app/resource-manager/readme.md:86 in 8575f62. [](commit_id = 8575f62, deletion_comment = False)