Changes due to problem in SDK Generation from typespec #31125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
AzureRestAPISpecReview
added
resource-manager
RPaaS
TypeSpec
This reverts commit 326b197.
AzureRestAPISpecReview
removed
resource-manager
RPaaS
VersioningReviewRequired
This was referenced Oct 23, 2024
This reverts commit 2b5f300.
AzureRestAPISpecReview
added
resource-manager
RPaaS
VersioningReviewRequired
specification/workloads/Workloads.SAPVirtualInstance.Management/main.tsp
Outdated
Show resolved
Hide resolved
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
AzureRestAPISpecReview
added
ARMReview
NotReadyForARMReview
ReadyForApiTest
jaskisin
added
BreakingChange-Approved-BugFix
ajaygit158
approved these changes
Nov 11, 2024
tadelesh
added
Approved-SdkBreakingChange-Go
pcsin
reviewed
Nov 12, 2024
| # package-dir: "Azure.ResourceManager.SapVirtualInstances" | ||
| # clear-output-folder: true | ||
| # model-namespace: false | ||
| # namespace: "{package-dir}" |
There was a problem hiding this comment.
Is this expected, we are commenting out c# sdk generation. #Closed
There was a problem hiding this comment.
For C# SDK, we are facing some generation build failures with Dotnet SDK, which we choose to pick after fixing the current issues
mikeharder
reviewed
Nov 12, 2024
specification/workloads/resource-manager/Microsoft.Workloads/SAPVirtualInstance/readme.md
Outdated
Show resolved
Hide resolved
jaskisin
force-pushed
the
workloadsapi20240901
branch
from
011f5b8
to
7f3a020
Compare
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
AzureRestAPISpecReview
added
WaitForARMFeedback
jaskisin
force-pushed
the
workloadsapi20240901
branch
from
2e55481
to
d1cba2c
Compare
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
jaskisin
force-pushed
the
workloadsapi20240901
branch
from
26e5725
to
ac83cbe
Compare
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
AzureRestAPISpecReview
added
the
ReadyForApiTest
pcsin
added
the
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
jaskisin
added
the
PublishToCustomers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.