Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version 2024-06-01-preview for Azure API Center resource manager API #31211

Merged

Conversation

azaslonov
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Oct 25, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 25, 2024
@azaslonov azaslonov added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 25, 2024
@azaslonov azaslonov removed the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 25, 2024
@azaslonov azaslonov added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 25, 2024
@ramoka178
Copy link
Contributor

ramoka178 commented Oct 25, 2024

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiCenter/services/{serviceName}/importFromApim": {

can it be more descriptive ? importFromApiManagement?


Refers to: specification/apicenter/resource-manager/Microsoft.ApiCenter/preview/2024-06-01-preview/apicenter.json:672 in e9b5fd5. [](commit_id = e9b5fd5, deletion_comment = False)

Removed it for now.

@ramoka178
Copy link
Contributor

ramoka178 commented Oct 25, 2024

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiCenter/services/{serviceName}/workspaces/{workspaceName}/apiSources/{apiSourceName}": {

no patch API needed?


Refers to: specification/apicenter/resource-manager/Microsoft.ApiCenter/preview/2024-06-01-preview/apicenter.json:1445 in e9b5fd5. [](commit_id = e9b5fd5, deletion_comment = False)

Nope, no PATCH.

@azaslonov azaslonov added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Nov 8, 2024
@azaslonov azaslonov enabled auto-merge (squash) November 8, 2024 22:24
@azaslonov
Copy link
Member Author

@ramoka178, this PR is ready to be merged, but I'm not sure what else needs to be done, instruction doesn't say anything beyond buddy approval and PublishToCustomers tag. Could you advise?

Copy link
Member

@Bruce-Moe Bruce-Moe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Bruce-Moe

This comment was marked as spam.

@azaslonov azaslonov enabled auto-merge (squash) November 9, 2024 01:43
@azaslonov azaslonov merged commit 895c9ab into main Nov 11, 2024
30 of 31 checks passed
@azaslonov azaslonov deleted the release-apicenter-Microsoft.ApiCenter-preview/2024-06-01-preview branch November 11, 2024 18:03
mikeharder added a commit to mikeharder/azure-rest-api-specs that referenced this pull request Nov 13, 2024
…r API (Azure#31211)

* Added version 2024-06-01-preview for Azure API Center resource manager API.
---------

Co-authored-by: Alexander Zaslonov <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Python-Sdk-Suppression BreakingChange-Python-Sdk-Suppression-Approved new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants