Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier hybridcompute #31463

Conversation

vedkale
Copy link
Member

@vedkale vedkale commented Nov 7, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

gubalasu and others added 30 commits September 27, 2024 10:17
* Copy 2024-02-01 version to create 2024-09-01 version

* Update readme.md

* Changes for the new api version

* Update readme.md

* Fix api versions in examples

* Update description

* Update cdn.json

Attempting to address lintdiff

* Update cdn.json

* Update cdn.json

* Fix validation

* Update cdn.json

* Update sdk-suppressions.yaml

* Update sdk-suppressions.yaml

* Update readme.md

* Update readme.md

* Update specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-09-01/cdn.json

Co-authored-by: Chenjie Shi <[email protected]>

* Update specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-09-01/cdn.json

Co-authored-by: Chenjie Shi <[email protected]>

---------

Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: Chenglong Liu <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
…1-preview (#30603)

* Copied Content from Previous Api Version

* Added MI features for IotHubs

* Moved iothubs from Patch to Create

* Reverted DPS Create Changes

* Updated Description

* Fixed Comments
* update document for DPG sdk-automation

* update

---------

Co-authored-by: Pan Shao <[email protected]>
* Fix PGSQL V2 missing auth type

* Update sdk-suppressions.yaml

---------

Co-authored-by: kazrael2119 <[email protected]>
)

* First commit - deep copy

* Added new field

* Editting Readme

* another update to readme

* Last update for readme.md

* Changed and compared to Mani's PR 5 months ago
* base commit

* added 2024-09-30 api version

* fixed tsv validation

* fixed prettier failures

---------

Co-authored-by: Manish Patil (from Dev Box) <[email protected]>
* Copy files from stable/2023-05-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-01-preview

Updated the API version from stable/2023-05-01 to preview/2024-10-01-preview.

* Added tag for 2024-10-01-preview in readme file

* added 2024-10-01-preview

* remove additionalProperties

* Copy files from stable/2023-05-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-01-preview

Updated the API version from stable/2023-05-01 to preview/2024-10-01-preview.

* Added tag for 2024-10-01-preview in readme file

* added 2024-10-01-preview

* remove additionalProperties

* resolved PR comment

* update from secrets to secretReferences

* suppress additionalProperties

* delete file

* update to 'arm-id' format

---------

Co-authored-by: jameszlim <[email protected]>
* feat(azurearcdata): Welcome 2024-05-01-preview

* fix(azurearcdata): update cSpell.json 2024-05-01-preview

* fix(azurearcdata): 2024-05-01 Update readme.md

* Update sqlServerAvailabilityGroups.json

* chore(azurearcdata): prettier

* Update sqlServerAvailabilityGroups.json

* chore(azurearcdata): prettier

* chore(azurearcdata): prettier

* chore(azurearcdata): sync from private

* Update sqlServerDatabases.json
* Add base 2024-10-01-preview typespec changes, examples

* Add SopOnNoConnect configuration for pool resource

* Add LRO for capture snapshot, snapshot type enum

* Add lastConnectedTime property on devbox

* update comment per feedback


---------

Co-authored-by: Sneha Nagendra <[email protected]>
Bumps the typespec group with 2 updates: [@azure-tools/typespec-client-generator-core](https://github.com/Azure/typespec-azure) and [@typespec/compiler](https://github.com/microsoft/typespec).


Updates `@azure-tools/typespec-client-generator-core` from 0.46.0 to 0.46.2
- [Release notes](https://github.com/Azure/typespec-azure/releases)
- [Commits](https://github.com/Azure/typespec-azure/compare/[email protected]...@azure-tools/[email protected])

Updates `@typespec/compiler` from 0.60.0 to 0.60.1
- [Release notes](https://github.com/microsoft/typespec/releases)
- [Commits](https://github.com/microsoft/typespec/compare/[email protected]...@typespec/[email protected])

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: typespec
- dependency-name: "@typespec/compiler"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: typespec
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Copy files from preview/2024-05-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-09-01-preview

Updated the API version from preview/2024-05-01-preview to preview/2024-09-01-preview.

* Added tag for 2024-09-01-preview in readme file

* Added missing tags from the last release.

* resource name pattern fix

* match original?

* updated delete response

* try

* common?

* try to match

* location header added and 200 removed from delete

* more fixes

* fix json

* change camel case to be all lower in uri

* missing type object errors

* camel case fixes

* fix paramaeter name to match case

* Fixing XmsPageableForListCalls violation from containerInstance.json

* removed post 204 response

* removed 204 from post

* fix some type obejct references

* last camel case

* vnet name with pattern

* updated sku to get nextLink

* fixed json

* updated nextlink in paged response

* Fixing OperationsApiResponseSchema violation from containerInstance.json

* Fixing OperationsApiSchemaUsesCommonTypes violation from containerInstance.json

* fixed lint errors

* Fixing LroLocationHeader, LroErrorContent and MissingTypeObject violation from containerInstance.json

* camel case last

* attempt at some object type failures

* capital g in resource group

* wrap in tag

* revert to only Ngroups initial change

* readonly location in patch

* readonly fix

* revert path change and use common tracked resource schema

* fix location resource and readonly

* file not referenced

* remove unreferenced property

* npx make prettier

* remove standby from update

* added ngroups to cspell

* npx prettier for all examples

* Addressing PR feedback.

* Baseline file from stable-2023-05-01 for reference.

* Revert: Baseline file from stable-2023-05-01 for reference.

* Fixing spell check and Lint error.

* spellcheck fix

* TrackedResource has a required field for location, which is not needed for PATCH operation. So reverted it.

* spellcheck fix2

* nit

* Location property in PAtch operation should be readOnly or immutable.

* addressed comments

* updated provisioningState

* added headers in the PUT response

* used common managedIdentity for nGroups

* Revert "used common managedIdentity for nGroups"

This reverts commit fb6a58f.

* added long-running-operation-options

* updated long-running-operation-options

* updated headers in response

* fixed lint errors

---------

Co-authored-by: John Richardson <[email protected]>
Co-authored-by: Shivam Gupta <[email protected]>
…LI development (#30079)

* Chaning the version of DistributedAvailabilityGroups in package-composite-v5 tag section.

* Moving new version of DAG to the bottom of v5 section.

---------

Co-authored-by: jovancevic123 <[email protected]>
* Add AOAI 2024-09-01-preview API version

* Add changes;

* Fix inference json and yml errors;

* Fix prettierCheck;

* Fix prettierCheck;

* Fix spell check;

---------

Co-authored-by: Yunsong Bai <[email protected]>
…points an… (#30290)

* Updating the API spec for confidential ledger for custom endpoints and custom roles change

* Updating endpoint name and few minor changes

* Updating API version and some minor spec updates

* Fixing validation errors

* Fixing swagger validation errors

* Updating JSON reference

* Fixing schema validation issues

* Fixing minor issue

* Fixing schema validation errors

* Fixing schema validation errors

* Fixing validation errors

* Fixing validation errors

* Fixinf validation errors

* Fixing errors

* Fixinf schema

* Updating user role schema

* Updating role name and action schema

* Updating schema

* Fixing schema validation

* Updating API parameters

* Fixinf schema errors

* Updating properties

* Updating definition

* Updating paramter names

* Fixinf schema errors

* Fixing schema validation

* Fixing schematic errors

* Fixing minor issue

* Fixing errors

* Fixing property errors

* Validation errors fixing

* Fixing schema definition errors

* Fixing validation errors

* Fixing type errors

* Fixing type errors

* Fixing type errors

* Fixing type errors

* Fixing type errors

* Fixing type errors

* Fixing type errors

* Fixing type errors

* Fixing type errors

* Fixing type errors

* Fixing type errors

* Addressing PR review comments

* Updating query body for patch runtime options

* Updating Assignedroles

* Addressing review comments from #30481

* Fixing schema

* Fixing schema

* Fixing schema

* Fixing schema

* Fixing schema

* Fixing schema

* Fixing schema

* Fixing schema

* Fixing schema

* Fixing stable version differences

* Fixing schema

* Fixing additional properties of metadata

* Fixing additional properties of Metadata

* Adding new endpoint to return multiple user roles

* Updating schema

* Updating schema

* Updating app/users endpoint

* Updating schema

* Adding new endpoint for user Id lookup for app/users endpoint

* Updating schema

* Updating API version and schema

* Updating user roles definition

* Updating user details parameter

* Updating user parameter

* Updating Addressing review comments

* Updated module parameter

* Updating get response for modules endpoint

* Updating response body in examples

* Updating new endpoint names

* Updating filenames

* Updating example

* Updating role name parameter

* Fixing the lint errors

* Reverting

* Addressing some of review comments
…op (#30401)

* Make the stop machine request body optional

* [tsp compile] Update scvmm.json for 2023-10-07

* [tsp compile] Update scvmm.json for 2024-06-01

* Create sdk-suppressions.yaml

---------

Co-authored-by: kazrael2119 <[email protected]>
…s. (#30831)

* Change 'The asynchronous responses are stored for 14 days.' to 24 days.

* Added TypeSpecRequirement suppression for Route v1.
… 2023-04-01 version to Typespec. (#30499)

* - initiated the first version of typespec.

* - deleted testing swagger for authoring conversations
- added testing json for authoring conversations 2023-04-15-preview

* - added long running operations

* - added a createOrUpdate operation with 201 response

* - modified the operationId in SuccesfulCopyProjectAuthorization.json
- compiled

* - added SuccessfulGetDeploymentDeleteFromResourcesStatus.json
- compiled

* - modified model EvaluationResults
- compiled

* - fixed Swagger SpellCheck
- compiled

* - adjusted the map of map structure of ConfusionMatrix
- compiled

* - modified the map of map structure of IntentsEvaluationSummary
- compiled

* - add 2023-04-01 version information

* - added testing json for 2023-04-01
- compiled

* - changed all the Azure.Core.Paged to model definition of array and nextLink (String)

* - modified the parameter name of some testing json of 2023-04-01

* - deleted the analyzeconversations-authoring folder under example of 2023-04-01

* - modified the name of models to add prefix ConversationAnalysisAuthoring
- compiled

* - add version 2023-04-15-preview to CustomConversationSummarization of ConversationalAnalysisAuthoringProjectKind
- compiled

* - changed the way of calling Azure.Core.Foundations.Error to definitions/error
- compiled

* - changed the appId type to uuid
- compiled

* - removed maxLength of projectName of ProjecteMetaData
- compiled

* - added version 2023-04-15-preview to storageInputContainerName of ProjectMetaData

* - added Versions 2023_04_15_preview to some properties
- compiled

* - add Versions v2023_04_15_preview to ConversationalAnalysisAuthoringCreateDeploymentOptions.properties.assignedResourceIds
- compiled

* - used npx command to fix TypeSpec Validation errors

* - fixed TypeSpec Validation
- compiled

* - made ConversationalAnalysisAuthoringCreateProjectOptions the request payload of the patch CreateProject operation, and made some of the properties optional
- compiled

* - fixed typespec validation in Language.AnalyzeConversations-authoring
- compiled

* - modified the titles of each testing json
- compiled

* - revert to the `main` version package-lock.json and package.json

* - modified the title of testing json SuccessfulSwapDeployment
- compiled

* - used npx tsv command to fix TypeSpec Validation

* - added resource template for ProjectMetaData
- used ResourceAction and LongRunningResourceAction for Resource ProjectMetaData (Operation authorize-copy and copy)
- compiled

* - added child Resource ProjectDeployment
- implemented Resource ProjectDeployment Template for getDeploymentsList
- compiled

* - added CopyProjectJobState as child Resource of ProjectMetaData
- implemented CopyProjectJobState by ResourceRead
- compiled

* - completed all the LongRunningResourceAction for resource ProjectMetadata
- compiled

* - used resource template for resource ProjectDeployment (Child of ProjectMetadata)
- used ResourceRead template for resource DeploymentJobState (Child of ProjectDeployment)
- compiled

* - added operation templates for resource ProjectTrainedModel
- compiled

* - added some JobState as children of ProjectTrainedModel
- used ResourceRead Template for these JobState resource
- compiled

* - added Resource resources and used some of its resource template
- compiled

* - add resource "train/jobs" for TrainingJobState
- used some resource template of TrainingJobState
- compiled

* - added DeploymentDeleteFromResourcesJobState and SwapDeploymentsJobState to fix duplicated DeploymentJobState resource issue
- compiled

* - added two more jobstate ExportProjectJobState and ImportProjectJobState as resource
- used ResourceRead template for thess two resources
- compiled

* - modified the operation name copy to copyProject
- added action("copy") for this
- compiled

* - used npx tsv command to resolve TypeSpec Validation

* - removed the "read" for @visibility of JobState.jobId
- compiled

* - added @actionSeparator("/:") to solve the RemovedPath and AddedPath issue
- compiled

* - reverted protected files to main version

* - removed all the "read" from @visibility in order to remove the readOnly properties in new swagger
- compiled

* - introduced the low-level LongRunning Operation to remove the status monitor in response
- compiled

* - removed all the FIXME of utcDateTime properties

* - used npx tsv command to resolve TypeSpec Validation

* - removed all the prefix of union and make the x-ms-enum same as old version
- compiled

* - gave concrete example to the uri in SuccessfulGetModelEvaluation testing json, trying to fix Swagger ModelValidation
- compiled

* - modified the namespace, adding Conversations at the end
- compiled
* Remove service name default

* no change

* add new type

* tsv

* move to auth

* format changes

* add non-empty

* chnge back

* push readme

* fix

* fix examples

* 9-15

* tsv

* non-empty string

* get rid of components

* schema registry id

* components examples

* Case

* schema registry id

* schema registry id

* fix surpression

* fix sub id

* changed

* schema reg ref

* schemaref

* fix schema ref

* Instance update

* format

* add batching

* Revert "add batching"

This reverts commit 3f67f94.

* remove otel config

---------

Co-authored-by: John Lian <[email protected]>
mikeharder and others added 7 commits November 6, 2024 14:30
…t dependencies (#31447)

- Intention is to pin all TSP packages, not just leaf nodes
- Ensures branch "tsp-next" resolves the correct packages
* Renamed a few models for Java SDK

* Using ErrorResponse from Azure.core.foundations over the customized TranslationError object

* Fixing the DocumentStatus name

* Updating ErrorResponse to Error

* Another update from ErrorResponse to Error

* Updating generateMetadata to true for typespec-ts

* Fixing the openapi

* Reverting the use of Azure.core.Foundation.Error object

* Reverting TranslationErrorResponse model

* Just fixing the order of model definitions

* Another fix in model
#31450)

Bumps the typespec group with 1 update: [@azure-tools/typespec-client-generator-core](https://github.com/Azure/typespec-azure).


Updates `@azure-tools/typespec-client-generator-core` from 0.48.0 to 0.48.1
- [Release notes](https://github.com/Azure/typespec-azure/releases)
- [Commits](https://github.com/Azure/typespec-azure/compare/[email protected]...@azure-tools/[email protected])

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: typespec
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Support MySQL additional connection properties

* Support MySQL additional connection properties
Copy link

openapi-pipeline-app bot commented Nov 7, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR modified the suppressions for Go SDK breaking changes (label: BreakingChange-Go-Sdk-Suppression). Refer to step 3 in the PR workflow diagram.
  • ❌ Your PR modified the suppressions for Python SDK breaking changes (label: BreakingChange-Python-Sdk-Suppression). Refer to step 3 in the PR workflow diagram.
  • ❌ Your PR modified the suppressions for Python track-2 SDK breaking changes (label: BreakingChange-Python-Sdk-Suppression). Refer to step 3 in the PR workflow diagram.
  • ❌ The required check named Swagger PrettierCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.