Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Intelligence 2024-11-30 GA #31522

Merged
merged 10 commits into from
Nov 16, 2024

Conversation

bojunehsu
Copy link
Member

Data Plane API Specification Update Pull Request

Document Intelligence 2024-11-30 GA.

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Copy link

openapi-pipeline-app bot commented Nov 13, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Nov 13, 2024

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think I got all the answers to my doubts.

@bojunehsu bojunehsu marked this pull request as ready for review November 14, 2024 06:04
@bojunehsu bojunehsu requested a review from a team as a code owner November 14, 2024 06:04
@bojunehsu bojunehsu requested review from marclerwick and removed request for a team November 14, 2024 06:04
Copy link
Member

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments on aspects of the API where it is not following the Azure guidelines. We may have discussed these in prior reviews but I could not find mention of it going back through the review notes. Please respond with an explanation so we have the reasoning documented.

@mikekistler
Copy link
Member

Tagging @allenjzhang and @mario-guerra to review the TypeSpec for best practices.

Copy link
Member

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@mikekistler mikekistler added the APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. label Nov 14, 2024
@bojunehsu bojunehsu enabled auto-merge (squash) November 16, 2024 01:53
@bojunehsu bojunehsu added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Nov 16, 2024
@bojunehsu bojunehsu merged commit dd4ae36 into main Nov 16, 2024
27 of 29 checks passed
@bojunehsu bojunehsu deleted the paulhsu/DocumentIntelligence-2024-11-30 branch November 16, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. data-plane new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants