-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add null terminator for char* based json string unescape, and precondition on input length #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsonkhan
requested review from
antkmsft,
RickWinter,
vhvb1989 and
gearama
as code owners
August 8, 2022 19:46
LarryOsterman
approved these changes
Aug 10, 2022
antkmsft
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look good once covered by tests.
Functionality LGTM, I see no issues.
How does the code coverage look like? Strangely, I ger 404 when clicking on CI Details link.
(codecov still won't show us that we're not testing for null terminator)
antkmsft
reviewed
Aug 10, 2022
danewalton
added a commit
to danewalton/azure-sdk-for-c
that referenced
this pull request
Sep 15, 2022
…ition on input length (Azure#2303) * Add null terminator for char* based json string unescape, and precondition on input length * Add remark comment about precondition and null terimination * Update doc comment typo * Remove the test cases about insufficient space. * Fix clang formatting. * Add null terminator tests. * Test that the null terminator is there at the end. * Fix build errors.
danewalton
added a commit
to danewalton/azure-sdk-for-c
that referenced
this pull request
Sep 15, 2022
…ition on input length (Azure#2303) * Add null terminator for char* based json string unescape, and precondition on input length * Add remark comment about precondition and null terimination * Update doc comment typo * Remove the test cases about insufficient space. * Fix clang formatting. * Add null terminator tests. * Test that the null terminator is there at the end. * Fix build errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2301