Updating Java SDK to include inline attachments #41591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogeshmo
approved these changes
Aug 21, 2024
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
…ttps://github.com/natekimball-msft/azure-sdk-for-java into natekimball/update-java-sdk-for-inline-attachments
kagbakpem
requested changes
Aug 23, 2024
...mmunication-email/src/main/java/com/azure/communication/email/implementation/EmailsImpl.java
Outdated
Show resolved
Hide resolved
DominikMe
reviewed
Aug 26, 2024
.../azure-communication-email/src/samples/java/com/azure/communication/email/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
3 tasks
kagbakpem
approved these changes
Sep 20, 2024
natekimball-msft
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Sep 20, 2024
### Packages impacted by this PR azure/communication-email ### Issues associated with this PR N/A ### Describe the problem that is addressed by this PR N/A ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? N/A - update to include contentId property for EmailAttachment to support inline attachments. ### Are there test cases added in this PR? _(If not, why?)_ Yes ### Provide a list of related PRs _(if any)_ [Java SDK PR](Azure/azure-sdk-for-java#41591) [.NET SDK PR](Azure/azure-sdk-for-net#45360) [REST API PR (complete)](Azure/azure-rest-api-specs#29699) ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ Git command? git push --set-upstream origin natekimball/update-js-sdk-for-inline-attachments ### Checklists - [X] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [X] Added a changelog (if necessary)
mssfang
pushed a commit
to mssfang/azure-sdk-for-java
that referenced
this pull request
Oct 21, 2024
* updating Java SDK to include inline attachments * minor updates * updating classes with correct API version * updating tests * assets.json * reverting version number * content should be string * actually it should be BinaryData, my bad * merge miss * fixing linting errors and sample * linting error * another linting error * adding older methods to bypass linting errors * reordering enum for linting error in pipeline * cleaning up trailing whitespace * appending setContentId to end of constructor call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update introduces the new EmailAttachment property
contentId, the presence of which will be used to mark an attachment for inline rendering. ThecontentIdproperty should be referenced in the HTML body of the email attachment.Link to swagger spec API: Azure/azure-rest-api-specs#29699
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines