Remove core-http from perf tests #26276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
requested review from
HarshaNalluru,
timovv,
EmmaZhu,
XiaoningLiu,
jeremymeng,
vinjiang,
jiacfan,
ljian3377 and
deyaaeldeen
as code owners
github-actions
bot
added
Azure.Core
Storage
| this.blobServiceClient = BlobServiceClient.fromConnectionString(connectionString); | ||
| const options = this.configureClientOptions({ additionalPolicies: [] }); | ||
|
|
||
| const pipeline = this.blobServiceClient["storageClientContext"].pipeline; |
There was a problem hiding this comment.
Hmmm, I can see why you're having to do this.
Why doesn't storage's client options extend from common client options?
That way we'd get the additionalPolicies array directly.
There was a problem hiding this comment.
Storage never used our common options because they had some custom ones, and now it would conflict a bit since they have the old "HttpClient" shape from core-http that is maintained for back compat. :(
HarshaNalluru
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure-tests/perf-storage-blob@azure-tests/perf-core-rest-pipeline@azure/test-utils-perfIssues associated with this PR
#24525
Describe the problem that is addressed by this PR
Remove last references to
core-httpfrom the tree as it will soon be deprecated.