Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ACS Email python SDK for inline attachments #37069

Conversation

natekimball-msft
Copy link
Member

Description

This update introduces the new EmailAttachment property contentId, the presence of which will be used to mark an attachment for inline rendering. The contentId property should be referenced in the HTML body of the email attachment.

Link to swagger spec API: Azure/azure-rest-api-specs#29699

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@DominikMe DominikMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with comments

sdk/communication/azure-communication-email/README.md Outdated Show resolved Hide resolved
sdk/communication/cspell.json Outdated Show resolved Hide resolved
@kagbakpem kagbakpem merged commit 142916f into Azure:main Sep 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants