MaximumDuplicateDetectionHistoryTimeWindow should be 7 days and not 1 (…

…#593)

* Fixes #592 - MaximumDuplicateDetectionHistoryTimeWindow should be 7 days and not 1

src/Microsoft.Azure.ServiceBus/Management/ManagementClientConstants.cs

@@ -33,7 +33,7 @@ internal class ManagementClientConstants
         public static readonly TimeSpan MinimumLockDuration = TimeSpan.FromSeconds(5);
         public static readonly TimeSpan MaximumLockDuration = TimeSpan.FromMinutes(5);
         public static readonly TimeSpan MinimumAllowedAutoDeleteOnIdle = TimeSpan.FromMinutes(5);
-        public static readonly TimeSpan MaximumDuplicateDetectionHistoryTimeWindow = TimeSpan.FromDays(1);
+        public static readonly TimeSpan MaximumDuplicateDetectionHistoryTimeWindow = TimeSpan.FromDays(7);
         public static readonly TimeSpan MinimumDuplicateDetectionHistoryTimeWindow = TimeSpan.FromSeconds(20);
         public static readonly int MinAllowedMaxDeliveryCount = 1;
         public static readonly int MaxUserMetadataLength = 1024;

src/Microsoft.Azure.ServiceBus/Management/QueueDescription.cs

@@ -35,7 +35,7 @@ public QueueDescription(string path)
         /// <summary>
         /// Path of the queue relative to the namespace base address.
         /// </summary>
-        /// <remarks>Max length is 260 chars. Cannot start or end with a slash. 
+        /// <remarks>Max length is 260 chars. Cannot start or end with a slash.
         /// Cannot have restricted characters: '@','?','#','*'</remarks>
         public string Path
         {
@@ -81,7 +81,7 @@ public TimeSpan LockDuration
         /// </summary>
         /// <remarks>
         /// If true, the receiver can only recieve messages using <see cref="SessionClient.AcceptMessageSessionAsync()"/>.
-        /// Defaults to false. 
+        /// Defaults to false.
         /// </remarks>
         public bool RequiresSession { get; set; } = false;
 
@@ -91,7 +91,7 @@ public TimeSpan LockDuration
         /// <remarks>
         /// This is the default value used when <see cref="Message.TimeToLive"/> is not set on a
         ///  message itself. Messages older than their TimeToLive value will expire and no longer be retained in the message store.
-        ///  Subscribers will be unable to receive expired messages. 
+        ///  Subscribers will be unable to receive expired messages.
         ///  Default value is <see cref="TimeSpan.MaxValue"/>.
         ///  </remarks>
         public TimeSpan DefaultMessageTimeToLive
@@ -138,7 +138,7 @@ public TimeSpan AutoDeleteOnIdle
         /// The <see cref="TimeSpan"/> duration of duplicate detection history that is maintained by the service.
         /// </summary>
         /// <remarks>
-        /// The default value is 1 minute. Max value is 1 day and minimum is 20 seconds.
+        /// The default value is 1 minute. Max value is 7 days and minimum is 20 seconds.
         /// </remarks>
         public TimeSpan DuplicateDetectionHistoryTimeWindow
         {
@@ -158,7 +158,7 @@ public TimeSpan DuplicateDetectionHistoryTimeWindow
         /// <summary>
         /// The maximum delivery count of a message before it is dead-lettered.
         /// </summary>
-        /// <remarks>The delivery count is increased when a message is received in <see cref="ReceiveMode.PeekLock"/> mode 
+        /// <remarks>The delivery count is increased when a message is received in <see cref="ReceiveMode.PeekLock"/> mode
         /// and didn't complete the message before the message lock expired.
         /// Default value is 10. Minimum value is 1.</remarks>
         public int MaxDeliveryCount
@@ -206,7 +206,7 @@ internal set
         /// <summary>
         /// The path of the recipient entity to which all the messages sent to the queue are forwarded to.
         /// </summary>
-        /// <remarks>If set, user cannot manually receive messages from this queue. The destination entity 
+        /// <remarks>If set, user cannot manually receive messages from this queue. The destination entity
         /// must be an already existing entity.</remarks>
         public string ForwardTo
         {

src/Microsoft.Azure.ServiceBus/Management/TopicDescription.cs

@@ -33,7 +33,7 @@ public TopicDescription(string path)
         /// <remarks>
         /// This is the default value used when <see cref="Message.TimeToLive"/> is not set on a
         ///  message itself. Messages older than their TimeToLive value will expire and no longer be retained in the message store.
-        ///  Subscribers will be unable to receive expired messages. 
+        ///  Subscribers will be unable to receive expired messages.
         ///  Default value is <see cref="TimeSpan.MaxValue"/>.
         ///  </remarks>
         public TimeSpan DefaultMessageTimeToLive
@@ -88,7 +88,7 @@ public TimeSpan AutoDeleteOnIdle
         /// The <see cref="TimeSpan"/> duration of duplicate detection history that is maintained by the service.
         /// </summary>
         /// <remarks>
-        /// The default value is 1 minute. Max value is 1 day and minimum is 20 seconds.
+        /// The default value is 1 minute. Max value is 7 days and minimum is 20 seconds.
         /// </remarks>
         public TimeSpan DuplicateDetectionHistoryTimeWindow
         {
@@ -108,7 +108,7 @@ public TimeSpan DuplicateDetectionHistoryTimeWindow
         /// <summary>
         /// Path of the topic relative to the namespace base address.
         /// </summary>
-        /// <remarks>Max length is 260 chars. Cannot start or end with a slash. 
+        /// <remarks>Max length is 260 chars. Cannot start or end with a slash.
         /// Cannot have restricted characters: '@','?','#','*'</remarks>
         public string Path
         {
@@ -153,8 +153,8 @@ internal set
         public bool EnablePartitioning { get; set; } = false;
 
         /// <summary>
-        /// Defines whether ordering needs to be maintained. If true, messages sent to topic will be 
-        /// forwarded to the subscription in order. 
+        /// Defines whether ordering needs to be maintained. If true, messages sent to topic will be
+        /// forwarded to the subscription in order.
         /// </summary>
         /// <remarks>Defaults to false.</remarks>
         public bool SupportOrdering { get; set; } = false;
@@ -190,7 +190,7 @@ public string UserMetadata
 
         /// <summary>
         /// List of properties that were retrieved using GetTopic but are not understood by this version of client is stored here.
-        /// The list will be sent back when an already retrieved TopicDescription will be used in UpdateTopic call. 
+        /// The list will be sent back when an already retrieved TopicDescription will be used in UpdateTopic call.
         /// </summary>
         internal List<object> UnknownProperties { get; set; }
 
@@ -207,7 +207,7 @@ public override bool Equals(object obj)
 
         public bool Equals(TopicDescription otherDescription)
         {
-            if (otherDescription is TopicDescription other 
+            if (otherDescription is TopicDescription other
                 && this.Path.Equals(other.Path, StringComparison.OrdinalIgnoreCase)
                 && this.AutoDeleteOnIdle.Equals(other.AutoDeleteOnIdle)
                 && this.DefaultMessageTimeToLive.Equals(other.DefaultMessageTimeToLive)