chore: slice replace loop (#2278)

Azure · Jul 25, 2023 · 06264a1 · 06264a1
1 parent 55791d6
commit 06264a1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/cmd/zt_scenario_helpers_for_test.go b/cmd/zt_scenario_helpers_for_test.go
@@ -223,10 +223,7 @@ func (scenarioHelper) generateCommonRemoteScenarioForWASB(a *assert.Assertions,
 	createNewDirectoryStub(a, containerURL, prefix+"sub1/sub3/sub5")
 	createNewDirectoryStub(a, containerURL, prefix+"sub2")
 
-	for _, dirPath := range []string{prefix + "sub1", prefix + "sub1/sub3", prefix + "sub1/sub3/sub5", prefix + "sub2"} {
-		blobList = append(blobList, dirPath)
-	}
-
+	blobList = append(blobList, []string{prefix + "sub1", prefix + "sub1/sub3", prefix + "sub1/sub3/sub5", prefix + "sub2"}...)
 	// sleep a bit so that the blobs' lmts are guaranteed to be in the past
 	time.Sleep(time.Millisecond * 1050)
 	return

diff --git a/common/extensions_test.go b/common/extensions_test.go
@@ -115,15 +115,11 @@ func TestRedaction(t *testing.T) {
 	for input, expectedOutput := range redactionTests {
 		queryKeyNeedRedact := "sig"
 		expectedOutputParams := make([]string, 0)
-		for _, param := range strings.Split(expectedOutput, "&") {
-			expectedOutputParams = append(expectedOutputParams, param)
-		}
+		expectedOutputParams = append(expectedOutputParams, strings.Split(expectedOutput, "&")...)
 
 		isRedacted, actualOutput := RedactSecretQueryParam(input, queryKeyNeedRedact)
 		actualOutputParams := make([]string, 0)
-		for _, param := range strings.Split(actualOutput, "&") {
-			actualOutputParams = append(actualOutputParams, param)
-		}
+		actualOutputParams = append(actualOutputParams, strings.Split(actualOutput, "&")...)
 
 		a.Equal(len(actualOutputParams), len(expectedOutputParams))
 
@@ -171,4 +167,4 @@ func TestBlockblobBlockIDGeneration(t *testing.T) {
 		a.Equal(blockName, tmp)
 	}
 
-}
+}