Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skip version check before calling beginDetectNewVersion #2301

Merged
merged 1 commit into from
Jul 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -192,13 +192,15 @@ func Execute(logPathFolder, jobPlanFolder string, maxFileAndSocketHandles int, j
if err := rootCmd.Execute(); err != nil {
glcm.Error(err.Error())
} else {
// our commands all control their own life explicitly with the lifecycle manager
// only commands that don't explicitly exit actually reach this point (e.g. help commands and login commands)
select {
case <-beginDetectNewVersion():
// noop
case <-time.After(time.Second * 8):
// don't wait too long
if !azcopySkipVersionCheck {
// our commands all control their own life explicitly with the lifecycle manager
// only commands that don't explicitly exit actually reach this point (e.g. help commands and login commands)
select {
case <-beginDetectNewVersion():
// noop
case <-time.After(time.Second * 8):
// don't wait too long
}
}
glcm.Exit(nil, common.EExitCode.Success())
}
Expand Down
Loading