Fix ADLS Gen 2 ACL tests & copying #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft and
tasherif-msft
as code owners
gapra-msft
reviewed
Aug 31, 2023
| @@ -326,12 +326,18 @@ func (r *resourceBlobContainer) appendSourcePath(filePath string, useSas bool) { | |||
| } | |||
|
|
|||
| func (r *resourceBlobContainer) getAllProperties(a asserter) map[string]*objectProperties { | |||
| objects := scenarioHelper{}.enumerateContainerBlobProperties(a, r.containerClient) | |||
|
|
|||
| var fileSystem *azbfs.FileSystemURL | |||
There was a problem hiding this comment.
how hard would it be to just migrate this to the new datalake sdk preemptively?
gapra-msft
approved these changes
Aug 31, 2023
adreed-msft
added a commit
that referenced
this pull request
Sep 27, 2023
This reverts commit 1450346.
adreed-msft
added a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the DFS handling code to actually record all dfs endpoints as BlobFS and handle the swapping at the time it's needed, some faulty testing caused us to believe that this code was actually working. It was not.
This PR repairs both the ACL copying functionality and the testing for that functionality.