Create msi for windows #2819
Open
Create msi for windows #2819
+2,190
−2,078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphulkar-msft
requested review from
gapra-msft,
adreed-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
gapra-msft
reviewed
Oct 11, 2024
| artifactName: 'azCopy-binaries' | ||
| displayName: 'Publish binaries' | ||
| condition: succeededOrFailed() | ||
| # variables: |
There was a problem hiding this comment.
Should we undo this commentting here?
gapra-msft
reviewed
Oct 11, 2024
| @@ -0,0 +1,22 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"> | |||
| <Product Id="*" Name="azcopy" Language="1033" Version="10.26.0" Manufacturer="Microsoft" UpgradeCode="abeee33a-0cca-4060-89d7-0687f7374f7a"> | |||
There was a problem hiding this comment.
Will this version need to change every release? If so, we should add a section to the release process to double check this.
gapra-msft
reviewed
Oct 11, 2024
| @@ -0,0 +1,72 @@ | |||
| parameters: | |||
| working_dir: '' | |||
There was a problem hiding this comment.
Suggested change
| working_dir: '' | |
| - name: working_dir | |
| type: string |
nit. Similar changes for the other params,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.