Skip to content

Commit

Permalink
chore: lower case kind value to avoid diff everytime (#3911)
Browse files Browse the repository at this point in the history
## Description

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes #123
Fixes #456
Closes #123
Closes #456
-->

Closes #3909 

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.web.serverfarm](https://github.com/pankajagrawal16/bicep-registry-modules/actions/workflows/avm.res.web.serverfarm.yml/badge.svg?branch=3909%2Flowecase-kind)](https://github.com/pankajagrawal16/bicep-registry-modules/actions/workflows/avm.res.web.serverfarm.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [x] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

Co-authored-by: Buddy <[email protected]>
  • Loading branch information
pankajagrawal16 and tsc-buddy authored Dec 13, 2024
1 parent 47e8070 commit a0f7796
Show file tree
Hide file tree
Showing 6 changed files with 33 additions and 33 deletions.
26 changes: 13 additions & 13 deletions avm/res/web/serverfarm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ module serverfarm 'br/public:avm/res/web/serverfarm:<version>' = {
workspaceResourceId: '<workspaceResourceId>'
}
]
kind: 'App'
kind: 'app'
location: '<location>'
lock: {
kind: 'CanNotDelete'
Expand Down Expand Up @@ -197,7 +197,7 @@ module serverfarm 'br/public:avm/res/web/serverfarm:<version>' = {
]
},
"kind": {
"value": "App"
"value": "app"
},
"location": {
"value": "<location>"
Expand Down Expand Up @@ -279,7 +279,7 @@ param diagnosticSettings = [
workspaceResourceId: '<workspaceResourceId>'
}
]
param kind = 'App'
param kind = 'app'
param location = '<location>'
param lock = {
kind: 'CanNotDelete'
Expand Down Expand Up @@ -348,7 +348,7 @@ module serverfarm 'br/public:avm/res/web/serverfarm:<version>' = {
workspaceResourceId: '<workspaceResourceId>'
}
]
kind: 'App'
kind: 'app'
location: '<location>'
lock: {
kind: 'CanNotDelete'
Expand Down Expand Up @@ -400,7 +400,7 @@ module serverfarm 'br/public:avm/res/web/serverfarm:<version>' = {
]
},
"kind": {
"value": "App"
"value": "app"
},
"location": {
"value": "<location>"
Expand Down Expand Up @@ -458,7 +458,7 @@ param diagnosticSettings = [
workspaceResourceId: '<workspaceResourceId>'
}
]
param kind = 'App'
param kind = 'app'
param location = '<location>'
param lock = {
kind: 'CanNotDelete'
Expand Down Expand Up @@ -526,7 +526,7 @@ Defaults to false when creating Windows/app App Service Plan. Required if creati

- Required: No
- Type: bool
- Default: `[equals(parameters('kind'), 'Linux')]`
- Default: `[equals(parameters('kind'), 'linux')]`

### Parameter: `appServiceEnvironmentId`

Expand Down Expand Up @@ -667,15 +667,15 @@ Kind of server OS.

- Required: No
- Type: string
- Default: `'App'`
- Default: `'app'`
- Allowed:
```Bicep
[
'App'
'Elastic'
'FunctionApp'
'Linux'
'Windows'
'app'
'elastic'
'functionApp'
'linux'
'windows'
]
```

Expand Down
14 changes: 7 additions & 7 deletions avm/res/web/serverfarm/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@ param location string = resourceGroup().location

@description('Optional. Kind of server OS.')
@allowed([
'App'
'Elastic'
'FunctionApp'
'Windows'
'Linux'
'app'
'elastic'
'functionApp'
'windows'
'linux'
])
param kind string = 'App'
param kind string = 'app'

@description('Conditional. Defaults to false when creating Windows/app App Service Plan. Required if creating a Linux App Service Plan and must be set to true.')
param reserved bool = (kind == 'Linux')
param reserved bool = (kind == 'linux')

@description('Optional. The Resource ID of the App Service Environment to use for the App Service Plan.')
param appServiceEnvironmentId string = ''
Expand Down
18 changes: 9 additions & 9 deletions avm/res/web/serverfarm/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.30.23.60470",
"templateHash": "136819997431198276"
"version": "0.32.4.45862",
"templateHash": "13694467319022455305"
},
"name": "App Service Plan",
"description": "This module deploys an App Service Plan.",
Expand Down Expand Up @@ -232,21 +232,21 @@
},
"kind": {
"type": "string",
"defaultValue": "App",
"defaultValue": "app",
"allowedValues": [
"App",
"Elastic",
"FunctionApp",
"Windows",
"Linux"
"app",
"elastic",
"functionApp",
"windows",
"linux"
],
"metadata": {
"description": "Optional. Kind of server OS."
}
},
"reserved": {
"type": "bool",
"defaultValue": "[equals(parameters('kind'), 'Linux')]",
"defaultValue": "[equals(parameters('kind'), 'linux')]",
"metadata": {
"description": "Conditional. Defaults to false when creating Windows/app App Service Plan. Required if creating a Linux App Service Plan and must be set to true."
}
Expand Down
2 changes: 1 addition & 1 deletion avm/res/web/serverfarm/tests/e2e/max/main.test.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ module testDeployment '../../../main.bicep' = [
skuCapacity: 3
perSiteScaling: true
zoneRedundant: true
kind: 'App'
kind: 'app'
lock: {
name: 'lock'
kind: 'CanNotDelete'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ module testDeployment '../../../main.bicep' = [
skuName: 'P1v3'
skuCapacity: 3
zoneRedundant: true
kind: 'App'
kind: 'app'
lock: {
name: 'lock'
kind: 'CanNotDelete'
Expand Down
4 changes: 2 additions & 2 deletions avm/res/web/serverfarm/version.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.3",
"version": "0.4",
"pathFilters": [
"./main.json"
]
}
}

0 comments on commit a0f7796

Please sign in to comment.