Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avm/res/storage/storage-account Add additional built-in roles to Storage Module #2736

Merged
merged 13 commits into from
Aug 13, 2024

Conversation

ktremain
Copy link
Contributor

@ktremain ktremain commented Jul 17, 2024

Description

Add additional Builtin Roles to the Storage module
Closes #2698

Pipeline Reference

Pipeline
avm.res.storage.storage-account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jul 17, 2024
@matebarabas matebarabas added Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it and removed Needs: Triage 🔍 Maintainers need to triage still labels Aug 6, 2024
@ktremain ktremain marked this pull request as ready for review August 12, 2024 23:05
@ktremain ktremain requested review from a team as code owners August 12, 2024 23:05
@ktremain
Copy link
Contributor Author

@Azure/alz-core-team Please can you check on the Failure above (Set AVM GitHub PR labels) and approve once resolved. Thanks! :)

@AlexanderSehr AlexanderSehr merged commit 4a59f7c into Azure:main Aug 13, 2024
7 of 8 checks passed
@ktremain ktremain deleted the addBuiltInRoles branch August 13, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: storage-account missing BuiltInRoleName 'Storage File Data Privileged Contributor'
3 participants