Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite misspelled URL to PR, for PR labeling automation #3018

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Aug 9, 2024

On PR created trigger, GH provides the URL to the PR through the 'github.event.pull_request.url' variable. Unfortunately, there is a spelling issue in it: it has an "s" too much in it (pulls instead of pull), see 'https://github.com/Azure/bicep-registry-modules/pulls/3016'. Because of that, the PR labeling logic fail, a it can't find the PR

@rahalan rahalan added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working labels Aug 9, 2024
@rahalan rahalan self-assigned this Aug 9, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still and removed Needs: Triage 🔍 Maintainers need to triage still labels Aug 9, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@rahalan rahalan marked this pull request as ready for review August 9, 2024 11:29
@rahalan rahalan requested a review from a team as a code owner August 9, 2024 11:29
@rahalan rahalan added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Aug 9, 2024
@rahalan rahalan enabled auto-merge (squash) August 9, 2024 11:30
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@rahalan rahalan merged commit 7ec79ac into Azure:main Aug 9, 2024
4 checks passed
@rahalan rahalan deleted the users/rahalan/FixPrLogic branch August 9, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants