Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix for attributes in key-vault/vault #2758 #3039

Merged
merged 31 commits into from
Aug 13, 2024

Conversation

ChrisSidebotham
Copy link
Contributor

Description

Closes #2758

Pipeline Reference

Pipeline
avm.res.key-vault.vault

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@ChrisSidebotham ChrisSidebotham self-assigned this Aug 13, 2024
@ChrisSidebotham ChrisSidebotham added Needs: Core Team 🧞 This item needs the AVM Core Team to review it and removed Needs: Core Team 🧞 This item needs the AVM Core Team to review it labels Aug 13, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Aug 13, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@ChrisSidebotham ChrisSidebotham marked this pull request as ready for review August 13, 2024 12:28
@ChrisSidebotham ChrisSidebotham requested review from a team as code owners August 13, 2024 12:28
@AlexanderSehr AlexanderSehr merged commit 2fd6702 into Azure:main Aug 13, 2024
4 checks passed
@ChrisSidebotham ChrisSidebotham deleted the anchor branch August 14, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: key-vault/key issue
3 participants