feat: New Module avm-ptn-dev-ops-cicd-agents-and-runners #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a Dockerfile for creating a Linux Azure DevOps Agent Docker image for Azure Container Instances. The Dockerfile installs necessary dependencies and sets up the Azure CLI. This image can be built and pushed to a container registry for use in Azure DevOps pipelines. ```
The commit adds a PowerShell script `runPlaceHolderJob.ps1` that runs a placeholder job in an Azure Container Instance. The script takes parameters for the job name, resource group, and subscription ID. It checks if the job exists and waits for it to start before starting the job. If the job starts successfully, it sets the job status as "Success" in the deployment script outputs. If the job fails to start, it sets the job status as "Failed" in the deployment script outputs.
…sem/bicep-registry-modules into avm-ptn-lz-private-runners
This commit adds support for the `avm/ptn/dev-ops/cicd-agents-and-runners` module. It includes the necessary code changes in the `.github/CODEOWNERS` file and adds a new file `avm.ptn.dev-ops.cicd-agents-and-runners.yml` in the `.github/workflows` directory. The new workflow file defines a workflow for the `avm.ptn.dev-ops.cicd-agents-and-runners` module, with various inputs and jobs. Co-authored-by: Jack Tracey <[email protected]> Co-authored-by: Erika Gressi <[email protected]> Co-authored-by: Felipe Binotto <[email protected]>
…icd-agents-and-runners` This commit adds support for Azure Container Instances in the `avm/ptn/dev-ops/cicd-agents-and-runners` module. It includes the necessary code changes to specify the existing network container instance subnet name and the existing network container app subnet name. These changes are required for the deployment script to run the placeholder agent and the container app in the correct subnets. The subnets also need to have service delegation for Azure Container Instances and App environments respectively. Co-authored-by: Jack Tracey <[email protected]> Co-authored-by: Erika Gressi <[email protected]> Co-authored-by: Felipe Binotto <[email protected]>
…sem/bicep-registry-modules into avm-ptn-lz-private-runners
This commit adds support for the `avm/ptn/dev-ops/cicd-agents-and-runners` module. It includes the necessary code changes to specify the existing network container instance subnet name and the existing network container app subnet name. These changes are required for the deployment script to run the placeholder agent and the container app in the correct subnets. The subnets also need to have service delegation for Azure Container Instances and App environments respectively.
…ard' SKU for ACR This commit updates the `avm/ptn/dev-ops/cicd-agents-and-runners` module to use the 'Standard' SKU for the Azure Container Registry (ACR) instead of the 'Basic' SKU. This change is made based on the condition of `privateNetworking`, where if it is true, the ACR SKU will be set to 'Premium', otherwise it will be set to 'Standard'. This update ensures that the correct SKU is used for the ACR based on the networking configuration. Co-authored-by: Jack Tracey <[email protected]> Co-authored-by: Erika Gressi <[email protected]> Co-authored-by: Felipe Binotto <[email protected]>
This commit updates the `namePrefix` parameter in the `main.test.bicep` file. The previous value was set to `'sb'`, but it has been changed to `'#_namePrefix_#'`.
This commit updates the `avm/ptn/dev-ops/cicd-agents-and-runners` module. It includes code changes to set the `zoneRedundant` property to `true` and the `internal` property to `true` in the `main.bicep` file. These changes ensure that the module supports zone redundancy and internal networking when `privateNetworking` is enabled. The commit also updates the `main.json` file to change the `templateHash` value. Co-authored-by: Jack Tracey <[email protected]> Co-authored-by: Erika Gressi <[email protected]> Co-authored-by: Felipe Binotto <[email protected]>
This commit updates the `avm/ptn/dev-ops/cicd-agents-and-runners` module. It includes code changes to set the `zoneRedundant` property to `true` and the `internal` property to `true` in the `main.bicep` file. These changes ensure that the module supports zone redundancy and internal networking when `privateNetworking` is enabled. The commit also updates the `main.json` file to change the `templateHash` value.
This commit updates the `serviceShort` parameter in the `main.test.bicep` file. The previous value was set to `'devsr'`, but it has been changed to `'devaci'`.
This commit updates the `avm/ptn/dev-ops/cicd-agents-and-runners` module. It includes code changes to set the `zoneRedundant` property to `true` and the `internal` property to `true` in the `main.bicep` file. These changes ensure that the module supports zone redundancy and internal networking when `privateNetworking` is enabled. The commit also updates the `main.json` file to change the `templateHash` value.
…sem/bicep-registry-modules into avm-ptn-lz-private-runners
This commit updates the `avm/ptn/dev-ops/cicd-agents-and-runners` module. It includes code changes to set the `zoneRedundant` property to `true` and the `internal` property to `true` in the `main.bicep` file. These changes ensure that the module supports zone redundancy and internal networking when `privateNetworking` is enabled. The commit also updates the `main.json` file to change the `templateHash` value.
This commit updates the `avm/ptn/dev-ops/cicd-agents-and-runners` module. It includes code changes to set the `sku` property to `'Standard'` in the `dependencies.bicep` file. This change ensures that the NAT gateway resource uses the standard SKU.
…ort zone redundancy and internal networking This commit updates the `avm/ptn/dev-ops/cicd-agents-and-runners` module. It includes code changes to set the `zoneRedundant` property to `true` and the `internal` property to `true` in the `main.bicep` file. These changes ensure that the module supports zone redundancy and internal networking when `privateNetworking` is enabled.
…Pull and AcrPush roles to the user assigned identity and assign Storage Blob Data Contributor role to the user assigned identity
…tomLocation property
…e containerInstanceSubnetName property
…' prefix for resource group names in e2e tests
avm/ptn/dev-ops/cicd-agents-and-runners/tests/e2e/aca-aci/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/ptn/dev-ops/cicd-agents-and-runners/tests/e2e/aca-aci/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/ptn/dev-ops/cicd-agents-and-runners/tests/e2e/aca-aci/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/ptn/dev-ops/cicd-agents-and-runners/tests/e2e/aca-aci/main.test.bicep
Outdated
Show resolved
Hide resolved
…AzureDevOpsContainerJob.ps1' script instead of 'runAzureDevOpsPlaceHolderAgent.ps1'
…rivate DNS zone resource ID handling
…bleTelemetry parameter
…bleTelemetry parameter
…e containerInstanceSubnetName property
…e containerInstanceSubnetName property
…' prefix for resource group names in e2e tests
...ev-ops/cicd-agents-and-runners/tests/e2e/private-devops-existing-vnet-aci/dependencies.bicep
Outdated
Show resolved
Hide resolved
...ev-ops/cicd-agents-and-runners/tests/e2e/private-github-existing-vnet-aca/dependencies.bicep
Outdated
Show resolved
Hide resolved
...n/dev-ops/cicd-agents-and-runners/tests/e2e/private-devops-existing-vnet-aci/main.test.bicep
Outdated
Show resolved
Hide resolved
AlexanderSehr
approved these changes
Sep 8, 2024
jianingwang123
pushed a commit
to jianingwang123/bicep-registry-modules
that referenced
this pull request
Sep 12, 2024
## Description This pattern module will deploy self-hosted Azure DevOps Agents and / or GitHub Runners allowing selection of one of the following compute options: Azure Container Instance Azure Container Apps <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes Azure#123 Fixes Azure#456 Closes Azure#123 Closes Azure#456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/sebassem/bicep-registry-modules/actions/workflows/avm.ptn.dev-ops.cicd-agents-and-runners.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [X] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [X] I'm sure there are no other open Pull Requests for the same update/change - [X] I have run `Set-AVMModule` locally to generate the supporting module files. - [X] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Jack Tracey <[email protected]> Co-authored-by: Erika Gressi <[email protected]> Co-authored-by: Felipe Binotto <[email protected]>
](https://github.com/sebassem/bicep-registry-modules/actions/workflows/avm.ptn.dev-ops.cicd-agents-and-runners.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pattern module will deploy self-hosted Azure DevOps Agents and / or GitHub Runners allowing selection of one of the following compute options:
Azure Container Instance
Azure Container Apps
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.