Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avm/res/network/firewall-policy add missing interfaces #3181

Merged
merged 9 commits into from
Oct 23, 2024
Merged

feat: avm/res/network/firewall-policy add missing interfaces #3181

merged 9 commits into from
Oct 23, 2024

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Sep 6, 2024 •
edited
Loading

Description

Adding RBAC and locks support in avm/res/network/firewall-policy

Pipeline Reference

Pipeline
avm.res.network.firewall-policy

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • [ x] My corresponding pipelines / checks run clean and green without any errors or warnings

@krbar krbar self-assigned this Sep 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Sep 6, 2024
@krbar krbar changed the title fix: `avm/res/network/firewall-policy´ add missing interfaces fix: avm/res/network/firewall-policy add missing interfaces Sep 6, 2024
@krbar krbar marked this pull request as ready for review September 6, 2024 00:05
@krbar krbar requested review from a team as code owners September 6, 2024 00:05
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Sep 6, 2024
@krbar krbar changed the title fix: avm/res/network/firewall-policy add missing interfaces feat: avm/res/network/firewall-policy add missing interfaces Sep 6, 2024
@eriqua eriqua self-requested a review September 28, 2024 00:33
@eriqua eriqua assigned eriqua and PaulJohnston88 and unassigned eriqua Sep 28, 2024
@eriqua eriqua added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Sep 28, 2024
@eriqua
Copy link
Contributor

eriqua commented Oct 1, 2024

@PaulJohnston88 would you have availability to review this improvements and halp driving this PR to closure 💪 ?

@ReneHezser
Copy link
Contributor

ReneHezser commented Oct 4, 2024 •
edited
Loading

@krbar
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

@krbar
Copy link
Contributor Author

krbar commented Oct 6, 2024

@krbar We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

Updated and re-tested.

CC: @PaulJohnston88

eriqua
eriqua approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

PaulJohnston88
PaulJohnston88 approved these changes Oct 23, 2024
View reviewed changes
Copy link

@PaulJohnston88 PaulJohnston88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved. Thanks @krbar

@PaulJohnston88 PaulJohnston88 merged commit 9fc212e into main Oct 23, 2024
13 checks passed
@PaulJohnston88 PaulJohnston88 deleted the users/krbar/fpRBAC branch October 23, 2024 15:36
@PaulJohnston88 PaulJohnston88 linked an issue Oct 24, 2024 that may be closed by this pull request
[AVM Module Issue]: Firewall-policy resource module doesn't have locks implemented #3310
Closed
1 task
@PaulJohnston88 PaulJohnston88 mentioned this pull request Oct 24, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulJohnston88 PaulJohnston88 PaulJohnston88 approved these changes

@eriqua eriqua eriqua approved these changes

Assignees

@krbar krbar

@PaulJohnston88 PaulJohnston88

Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Firewall-policy resource module doesn't have locks implemented
4 participants
@krbar @eriqua @ReneHezser @PaulJohnston88