Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update cognitive services deployment properties to latest API schema #4034

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

jceval
Copy link
Contributor

@jceval jceval commented Dec 20, 2024

Description

This PR addresses API updates for the latest cognitive services account deployments schema.
https://learn.microsoft.com/en-us/azure/templates/Microsoft.CognitiveServices/accounts/deployments?pivots=deployment-language-bicep

Fixes #3549

Pipeline Reference

Pipeline
avm.res.cognitive-services.account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@jceval jceval requested review from a team as code owners December 20, 2024 19:36
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Dec 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Dec 20, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Dec 20, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@jceval jceval changed the title Feature/api update Update cognitive services deployment properties to latest API schema Dec 20, 2024
@jceval jceval self-assigned this Dec 20, 2024
@jceval jceval added Type: Feature Request ➕ New feature or request Status: In Triage 🔍 Picked up for triaging by an AVM core team member and removed Needs: Triage 🔍 Maintainers need to triage still Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Dec 20, 2024
@jceval jceval changed the title Update cognitive services deployment properties to latest API schema feat: Update cognitive services deployment properties to latest API schema Dec 20, 2024
@jceval jceval merged commit e6edf90 into Azure:main Dec 20, 2024
4 of 5 checks passed
@jceval jceval deleted the feature/api_update branch December 20, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Triage 🔍 Picked up for triaging by an AVM core team member Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: avm.res/cognitive-services/account deployments is missing new settings
2 participants