fix: Update helm chart to use Release.Namespace #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helayoty
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
=======================================
Coverage 63.87% 63.87%
=======================================
Files 14 14
Lines 1301 1301
=======================================
Hits 831 831
Misses 432 432
Partials 38 38 ☔ View full report in Codecov by Sentry. |
helayoty
force-pushed
the
helayoty/release-namespace
branch
from
4f210a4
to
50fea2f
Compare
helayoty
force-pushed
the
helayoty/release-namespace
branch
from
50fea2f
to
2f66110
Compare
Signed-off-by: Heba Elayoty <[email protected]>
helayoty
force-pushed
the
helayoty/release-namespace
branch
from
2f66110
to
faecc0a
Compare
Fei-Guo
approved these changes
Mar 29, 2024
helayoty
added a commit
that referenced
this pull request
Mar 29, 2024
**Reason for Change**: Update helm chart to use `Release.Namespace` instead of chart name. **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: Signed-off-by: Heba Elayoty <[email protected]>
helayoty
added a commit
that referenced
this pull request
Mar 29, 2024
**Reason for Change**: Update helm chart to use `Release.Namespace` instead of chart name. **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: Signed-off-by: Heba Elayoty <[email protected]>
helayoty
added a commit
that referenced
this pull request
Mar 29, 2024
**Reason for Change**: Update helm chart to use `Release.Namespace` instead of chart name. **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: Signed-off-by: Heba Elayoty <[email protected]>
helayoty
added a commit
that referenced
this pull request
Mar 29, 2024
**Reason for Change**: Update helm chart to use `Release.Namespace` instead of chart name. **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: Signed-off-by: Heba Elayoty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Update helm chart to use
Release.Namespaceinstead of chart name.Requirements
Issue Fixed:
Notes for Reviewers: