chore: Change adapter image into temp ACR registry #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bangqi Zhu <[email protected]>
bangqipropel
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
| @@ -134,7 +134,7 @@ jobs: | |||
| run: | | |||
| make docker-build-adapter | |||
| env: | |||
| REGISTRY: ${{ env.REGISTRY }} | |||
| REGISTRY: ${{ env.CLUSTER_NAME }}.azurecr.io | |||
There was a problem hiding this comment.
Currently this is working unchanged for e2e tests outside of publish-gh-image.yaml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
- Coverage 61.01% 60.94% -0.08%
==========================================
Files 29 29
Lines 2588 2591 +3
==========================================
Hits 1579 1579
- Misses 918 921 +3
Partials 91 91 ☔ View full report in Codecov by Sentry. |
bangqipropel
had a problem deploying
to
preset-env
GitHub Actions
Failure
bangqipropel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Requirements
Issue Fixed:
Notes for Reviewers: